silverstripe / silverstripe-cms

code/Model/SiteTreeFileExtension.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\CMS\Model;
 
 use SilverStripe\Assets\File;
-use SilverStripe\Core\Convert;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\ReadonlyField;
 use SilverStripe\ORM\DataExtension;

Doc Comments +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     /**
      * Generate an HTML list which provides links to where a file is used.
      *
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function BackLinkHTMLList()
     {

code/Forms/SiteTreeURLSegmentField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Core\Convert;
 use SilverStripe\Forms\TextField;
-use SilverStripe\View\Requirements;
 
 /**
  * Used to edit the SiteTree->URLSegment property, and suggest input based on the serverside rules

Doc Comments +3 added lines

@@ -137,6 +137,9 @@
         return $this->defaultUrl;
     }
 
+    /**
+     * @param string $url
+     */
     public function setDefaultURL($url)
     {
         $this->defaultUrl = $url;

code/Controllers/CMSPageEditController.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
      *
      * @param array $data
      * @param Form $form
-     * @return DBHTMLText|HTTPResponse
+     * @return null|HTTPResponse
      */
     public function addtocampaign($data, $form)
     {

code/Controllers/SilverStripeNavigatorItem.php

Doc Comments +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
     protected $recordLink;
 
     /**
-     * @param DataObject|CMSPreviewable $record
+     * @param CMSPreviewable $record
      */
     public function __construct(CMSPreviewable $record)
     {
@@ -76,7 +76,7 @@ 
     }
 
     /**
-     * @return DataObject
+     * @return CMSPreviewable
      */
     public function getRecord()
     {

code/Model/VirtualPage.php

Doc Comments +3 added lines

@@ -379,6 +379,9 @@
         return null;
     }
 
+    /**
+     * @param string $field
+     */
     public function getField($field)
     {
         if ($this->isFieldVirtualised($field)) {

code/Reports/RecentlyEditedReport.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\CMS\Model\SiteTree;
 use SilverStripe\ORM\FieldType\DBDatetime;
-use SilverStripe\ORM\DataObject;
 use SilverStripe\Reports\Report;
 
 class RecentlyEditedReport extends Report

code/Controllers/SilverStripeNavigator.php

Doc Comments +2 added lines, -2 removed lines

@@ -28,7 +28,7 @@ 
     protected $record;
 
     /**
-     * @param DataObject|\SilverStripe\ORM\CMSPreviewable $record
+     * @param CMSPreviewable $record
      */
     public function __construct(CMSPreviewable $record)
     {
@@ -79,7 +79,7 @@ 
     }
 
     /**
-     * @param DataObject|CMSPreviewable $record
+     * @param DataObject $record
      * @return array template data
      */
     public static function get_for_record($record)

code/Controllers/CMSPageAddController.php

Unused Use Statements -2 removed lines

@@ -4,7 +4,6 @@ 
 
 use SilverStripe\CMS\Model\SiteTree;
 use SilverStripe\Control\Controller;
-use SilverStripe\Control\Session;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\Form;
@@ -17,7 +16,6 @@ 
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\FieldType\DBField;
 use SilverStripe\ORM\ValidationResult;
-use SilverStripe\Security\Member;
 use SilverStripe\Security\Security;
 
 class CMSPageAddController extends CMSPageEditController

code/Controllers/CMSMain.php

Unused Use Statements -2 removed lines

@@ -4,7 +4,6 @@ 
 
 use SilverStripe\Admin\AdminRootController;
 use SilverStripe\Admin\CMSBatchActionHandler;
-use SilverStripe\Admin\LeftAndMain_SearchFilter;
 use SilverStripe\Admin\LeftAndMainFormRequestHandler;
 use SilverStripe\CMS\Model\VirtualPage;
 use SilverStripe\Core\Environment;
@@ -20,7 +19,6 @@ 
 use SilverStripe\CMS\Model\SiteTree;
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\Director;
-use SilverStripe\Control\Session;
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Control\HTTPResponse_Exception;

Doc Comments +7 added lines, -4 removed lines

@@ -361,6 +361,9 @@ 
         return 'edit';
     }
 
+    /**
+     * @param string $link
+     */
     public function LinkWithSearch($link)
     {
         // Whitelist to avoid side effects
@@ -501,7 +504,7 @@ 
     /**
      * Get callback to determine template customisations for nodes
      *
-     * @return callable
+     * @return \Closure
      */
     protected function getTreeNodeCustomisations()
     {
@@ -1290,7 +1293,7 @@ 
 
     /**
      * @param HTTPRequest $request
-     * @return string HTML
+     * @return HTTPResponse HTML
      */
     public function treeview($request)
     {
@@ -1299,7 +1302,7 @@ 
 
     /**
      * @param HTTPRequest $request
-     * @return string HTML
+     * @return HTTPResponse HTML
      */
     public function listview($request)
     {
@@ -1652,7 +1655,7 @@ 
      * Actually perform the publication step
      *
      * @param Versioned|DataObject $record
-     * @return mixed
+     * @return HTTPResponse|null
      */
     public function performPublish($record)
     {