Completed
Pull Request — 2.4 (#1428)
by Daniel
09:07
created
code/Report.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -314,6 +314,7 @@  discard block
 block discarded – undo
314 314
 	
315 315
 	/**
316 316
 	 * Return the SS_Report objects making up the given list.
317
+	 * @param string $list
317 318
 	 * @return An array of SS_Report objects
318 319
 	 */
319 320
 	static function get_reports($list) {
@@ -365,6 +366,10 @@  discard block
 block discarded – undo
365 366
 	
366 367
 	protected $obj, $method, $params;
367 368
 	
369
+	/**
370
+	 * @param SS_Report $obj
371
+	 * @param string $method
372
+	 */
368 373
 	function __construct($obj, $method, $params) {
369 374
 		$this->obj = $obj;
370 375
 		$this->method = $method;
@@ -373,6 +378,7 @@  discard block
 block discarded – undo
373 378
 	
374 379
 	/**
375 380
 	 * Provide a method that will return a list of columns that can be used to sort.
381
+	 * @param string $sortColMethod
376 382
 	 */
377 383
 	function setSortColumnMethod($sortColMethod) {
378 384
 		$this->sortColMethod = $sortColMethod;
Please login to merge, or discard this patch.
code/ReportAdmin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * @TODO What does this do?
89 89
 	 *
90 90
 	 * @param unknown_type $params
91
-	 * @param unknown_type $editForm
91
+	 * @param Form $editForm
92 92
 	 * @return unknown
93 93
 	 */
94 94
 	protected function showWithEditForm($params, $editForm) {
Please login to merge, or discard this patch.
code/SecurityAdmin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
 	}
128 128
 
129 129
 	/**
130
-	 * @return FieldSet
130
+	 * @return Form
131 131
 	 */
132 132
 	function RootForm() {
133 133
 		$memberList = new MemberTableField(
Please login to merge, or discard this patch.
code/SideReport.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -11,6 +11,9 @@
 block discarded – undo
11 11
 	protected $controller, $report;
12 12
 	protected $parameters;
13 13
 	
14
+	/**
15
+	 * @param CMSMain $controller
16
+	 */
14 17
 	function __construct($controller, $report) {
15 18
 		$this->controller = $controller;
16 19
 		$this->report = $report;
Please login to merge, or discard this patch.
code/sitefeatures/Akismet.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -113,6 +113,11 @@
 block discarded – undo
113 113
 			}
114 114
 		}
115 115
 	
116
+	/**
117
+	 * @param string $request
118
+	 * @param string $host
119
+	 * @param string $path
120
+	 */
116 121
 	private function http_post($request, $host, $path)
117 122
 		{
118 123
 		$http_request  = "POST " . $path . " HTTP/1.1\r\n";
Please login to merge, or discard this patch.
code/sitefeatures/PageCommentInterface.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,6 +120,7 @@  discard block
 block discarded – undo
120 120
 	 * See {@link PageCommentInterface::$use_ajax_commenting}
121 121
 	 *
122 122
 	 * @param bool
123
+	 * @param boolean $state
123 124
 	 */
124 125
 	static function set_use_ajax_commenting($state) {
125 126
 		self::$use_ajax_commenting = $state;
@@ -154,7 +155,7 @@  discard block
 block discarded – undo
154 155
 	 * valid permission code in order to post (used to customize the error 
155 156
 	 * message).
156 157
 	 * 
157
-	 * @return bool
158
+	 * @return string
158 159
 	 */
159 160
 	function PostingRequiresPermission() {
160 161
 		return self::$comments_require_permission;
Please login to merge, or discard this patch.
code/staticpublisher/FilesystemPublisher.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -271,6 +271,9 @@
 block discarded – undo
271 271
 	
272 272
 	/**
273 273
 	 * Generate the templated content for a PHP script that can serve up the given piece of content with the given age and expiry
274
+	 * @param string $content
275
+	 * @param integer $age
276
+	 * @param string $lastModified
274 277
 	 */
275 278
 	protected function generatePHPCacheFile($content, $age, $lastModified) {
276 279
 		$template = file_get_contents(BASE_PATH . '/cms/code/staticpublisher/CachedPHPPage.tmpl');
Please login to merge, or discard this patch.
code/staticpublisher/StaticPublisher.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -34,6 +34,7 @@
 block discarded – undo
34 34
 	/**
35 35
 	 * Either turns on (boolean true) or off (boolean false) the progress indicators.
36 36
 	 * @see StaticPublisher::$echo_progress
37
+	 * @param boolean $progress
37 38
 	 */
38 39
 	static function set_echo_progress($progress) {
39 40
 		self::$echo_progress = (boolean)$progress;
Please login to merge, or discard this patch.