SilverStripe\CKANRegistry\Model\ResourceFilter

Complexity

Total Complexity

3

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	17	1
A	forTemplate()	0	8	2

<?php

namespace SilverStripe\CKANRegistry\Model;

use InvalidArgumentException;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\FormField;
use SilverStripe\Forms\HiddenField;
use SilverStripe\Forms\ListboxField;
use SilverStripe\Forms\TextField;
use SilverStripe\i18n\i18n;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\ValidationResult;

/**
 * Represents a filter for a data resource, which accepts user inputted data and generates a query string (?key=value)
 * to use in a request against a CKAN API for that particular resource in order to filter the results shown in a
 * representation of that data.
 */
class ResourceFilter extends DataObject
{
    /**
     * Types of FormFields that a filter could display as on the user facing side. Generally a list of
     * {@see SilverStripe\Forms\FormField} mapped to human readable identifiers such as would be passed to a
     * {@see DropDownField} as the source constructor parameter
     *
     * @config
     * @var array
     */
    private static $filter_types = [

The private property $filter_types is not used, and could be removed.

        TextField::class => 'Text',
        DropdownField::class => 'Select one from list',
    ];

    private static $table_name = 'CKANFilter';

The private property $table_name is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        'Name' => 'Varchar',
        'Type' => 'Varchar',
        'AllFields' => 'Boolean',
        'TypeOptions' => 'Text',
    ];

    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'FilterFor' => Resource::class,
    ];

    private static $many_many = [

The private property $many_many is not used, and could be removed.

        'FilterFields' => ResourceField::class,
    ];

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $typeTitle = $fields->dataFieldByName('Type')->Title();
        $fields->replaceField('Type', DropdownField::create(
            'Type',
            $typeTitle,
            $this->config()->get('filter_types')
        ));
        $fields->replaceField('TypeOptions', HiddenField::create('TypeOptions'));
        $fields->push(ListboxField::create(
            'FilterFields',
            'Columns to search',
            $this->FilterFor()->Fields()->map('ID', 'ReadableName')

The method FilterFor() does not exist on SilverStripe\CKANRegistry\Model\ResourceFilter. Since you implemented __call, consider adding a @method annotation.

        ));
        $fields->removeByName('FilterForID');
        return $fields;
    }

    public function forTemplate()
    {
        $options = json_decode($this->TypeOptions, true);

The property TypeOptions does not exist on SilverStripe\CKANRegistry\Model\ResourceFilter. Since you implemented __get, consider adding a @property annotation.

        $field = Injector::inst()->createWithArgs($this->Type, $options);

The property Type does not exist on SilverStripe\CKANRegistry\Model\ResourceFilter. Since you implemented __get, consider adding a @property annotation.

        if ($field instanceof FormField) {
            throw new InvalidArgumentException("$this->Type is not a FormField");
        }
        return $field;
    }
}