ResourceFieldItemRequestTest::testSortingOnResourceSave() - Code Metrics - Inspection of "Merge pull request #120 from creative-commoners/pu..." - silverstripe/silverstripe-ckan-registry - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a58aad...63ae86 )

unknown

created 2019-01-14 05:17 UTC

testSortingOnResourceSave() A

↳ Parent: ResourceFieldItemRequestTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	59
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	37
nc	1
nop	0
dl	0
loc	59
rs	9.328
c	0
b	0
f	0

How to fix Long Method

<?php
namespace SilverStripe\CKANRegistry\Tests\Forms\GridField\GridFieldDetailForm;

use SilverStripe\Admin\LeftAndMain;
use SilverStripe\CKANRegistry\Forms\GridField\GridFieldDetailForm\ResourceFieldItemRequest;
use SilverStripe\CKANRegistry\Model\Resource;
use SilverStripe\CKANRegistry\Model\ResourceField;
use SilverStripe\CKANRegistry\Page\CKANRegistryPage;
use SilverStripe\CKANRegistry\Service\ResourcePopulator;
use SilverStripe\CKANRegistry\Service\ResourcePopulatorInterface;
use SilverStripe\Control\Controller;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\Form;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldConfig;
use SilverStripe\Forms\GridField\GridFieldDetailForm;
use SilverStripe\Security\SecurityToken;

class ResourceFieldItemRequestTest extends SapphireTest
{
    protected static $fixture_file = 'ResourceFieldItemRequest.yml';

    protected function setUp()
    {
        $populator = $this->createMock(ResourcePopulator::class);
        Injector::inst()->registerService($populator, ResourcePopulatorInterface::class);

        $populator->method('populateFields')->willReturnSelf();
        $populator->method('populateMetadata')->willReturnSelf();

        parent::setUp();
    }

    public function testSortingOnResourceSave()
    {
        $this->moveFieldFixture('subject', 1);

        /** @var Resource $resource */
        $resource = $this->objFromFixture(Resource::class, 'teachers');

        $this->assertArrayEqualsInOrder(
            [
                'Subject' => '1',
                'First name' => '2',
                'Last name' => '3',
                'City' => '4',
                'School' => '5',
                'Gender' => '6',
            ],
            $resource->Fields()->sort('Position', 'ASC')->map('OriginalLabel', 'Position')->toArray()
        );

        $this->moveFieldFixture('firstname', 5);

        $this->assertArrayEqualsInOrder(
            [
                'Subject' => '1',
                'Last name' => '2',
                'City' => '3',
                'School' => '4',
                'First name' => '5',
                'Gender' => '6',
            ],
            $resource->Fields()->sort('Position', 'ASC')->map('OriginalLabel', 'Position')->toArray()
        );

        $this->moveFieldFixture('subject', 9);

        $this->assertArrayEqualsInOrder(
            [
                'Last name' => '1',
                'City' => '2',
                'School' => '3',
                'First name' => '4',
                'Gender' => '5',
                'Subject' => '9',
            ],
            $resource->Fields()->sort('Position', 'ASC')->map('OriginalLabel', 'Position')->toArray()
        );

        $this->moveFieldFixture('gender', 1);

        $this->assertArrayEqualsInOrder(
            [
                'Gender' => '1',
                'Last name' => '2',
                'City' => '3',
                'School' => '4',
                'First name' => '5',
                'Subject' => '9',
            ],
            $resource->Fields()->sort('Position', 'ASC')->map('OriginalLabel', 'Position')->toArray()
        );
    }

    protected function moveFieldFixture($fixture, $newPosition)
    {
        // Locate the resource fixture and the specified fixture
        /** @var Resource $resource */
        $resource = $this->objFromFixture(Resource::class, 'teachers');
        $field = $this->objFromFixture(ResourceField::class, $fixture);

        // Form a request
        $token = SecurityToken::create();
        $request = new HTTPRequest('POST', 'ItemEditForm', [], [
            'Position' => $newPosition,
            'action_doSave' => 1,
            $token->getName() => $token->getValue(),
        ]);
        $request->setSession(Controller::curr()->getRequest()->getSession());

        // Build the gridfield and component
        $config = GridFieldConfig::create();
        $detailForm = new GridFieldDetailForm;
        $config->addComponent($detailForm->setItemRequestClass(ResourceFieldItemRequest::class));
        $gridField = new GridField('Test', 'Test', $resource->Fields(), $config);
        $formMock = $this->createMock(Form::class);
        $formMock->method('FormAction')->willReturn('test');
        $gridField->setForm($formMock);
        $controllerMock = $this->createMock(Controller::class);
        $controllerMock->method('Link')->willReturn('test');
        $controllerMock->method('getRequest')->willReturn($request);

        // Create an item request
        $itemRequest = new ResourceFieldItemRequest(
            $gridField,
            $detailForm,
            $field,
            $controllerMock,
            'Test'
        );

        // Handle our request
        $itemRequest->handleRequest($request);
    }

    protected function assertArrayEqualsInOrder($expected, $actual)
    {
        $message = 'Failed asserting array in order. Expected '.print_r($expected, true).
            '. Actual: '.print_r($actual, true);

        foreach ($actual as $key => $value) {
            $expectedKey = key($expected);
            $expectedValue = array_shift($expected);
            $this->assertSame($expectedKey, $key, $message);
            $this->assertEquals($expectedValue, $value, $message);
        }

        $this->assertEmpty($expected, $message);
    }
}


1			<?php
2			namespace SilverStripe\CKANRegistry\Tests\Forms\GridField\GridFieldDetailForm;
3
4			use SilverStripe\Admin\LeftAndMain;
5			use SilverStripe\CKANRegistry\Forms\GridField\GridFieldDetailForm\ResourceFieldItemRequest;
6			use SilverStripe\CKANRegistry\Model\Resource;
7			use SilverStripe\CKANRegistry\Model\ResourceField;
8			use SilverStripe\CKANRegistry\Page\CKANRegistryPage;
9			use SilverStripe\CKANRegistry\Service\ResourcePopulator;
10			use SilverStripe\CKANRegistry\Service\ResourcePopulatorInterface;
11			use SilverStripe\Control\Controller;
12			use SilverStripe\Control\HTTPRequest;
13			use SilverStripe\Core\Injector\Injector;
14			use SilverStripe\Dev\SapphireTest;
15			use SilverStripe\Forms\Form;
16			use SilverStripe\Forms\GridField\GridField;
17			use SilverStripe\Forms\GridField\GridFieldConfig;
18			use SilverStripe\Forms\GridField\GridFieldDetailForm;
19			use SilverStripe\Security\SecurityToken;
20
21			class ResourceFieldItemRequestTest extends SapphireTest
22			{
23			protected static $fixture_file = 'ResourceFieldItemRequest.yml';
24
25			protected function setUp()
26			{
27			$populator = $this->createMock(ResourcePopulator::class);
28			Injector::inst()->registerService($populator, ResourcePopulatorInterface::class);
29
30			$populator->method('populateFields')->willReturnSelf();
31			$populator->method('populateMetadata')->willReturnSelf();
32
33			parent::setUp();
34			}
35
36			public function testSortingOnResourceSave()
37			{
38			$this->moveFieldFixture('subject', 1);
39
40			/** @var Resource $resource */
41			$resource = $this->objFromFixture(Resource::class, 'teachers');
42
43			$this->assertArrayEqualsInOrder(
44			[
45			'Subject' => '1',
46			'First name' => '2',
47			'Last name' => '3',
48			'City' => '4',
49			'School' => '5',
50			'Gender' => '6',
51			],
52			$resource->Fields()->sort('Position', 'ASC')->map('OriginalLabel', 'Position')->toArray()
53			);
54
55			$this->moveFieldFixture('firstname', 5);
56
57			$this->assertArrayEqualsInOrder(
58			[
59			'Subject' => '1',
60			'Last name' => '2',
61			'City' => '3',
62			'School' => '4',
63			'First name' => '5',
64			'Gender' => '6',
65			],
66			$resource->Fields()->sort('Position', 'ASC')->map('OriginalLabel', 'Position')->toArray()
67			);
68
69			$this->moveFieldFixture('subject', 9);
70
71			$this->assertArrayEqualsInOrder(
72			[
73			'Last name' => '1',
74			'City' => '2',
75			'School' => '3',
76			'First name' => '4',
77			'Gender' => '5',
78			'Subject' => '9',
79			],
80			$resource->Fields()->sort('Position', 'ASC')->map('OriginalLabel', 'Position')->toArray()
81			);
82
83			$this->moveFieldFixture('gender', 1);
84
85			$this->assertArrayEqualsInOrder(
86			[
87			'Gender' => '1',
88			'Last name' => '2',
89			'City' => '3',
90			'School' => '4',
91			'First name' => '5',
92			'Subject' => '9',
93			],
94			$resource->Fields()->sort('Position', 'ASC')->map('OriginalLabel', 'Position')->toArray()
95			);
96			}
97
98			protected function moveFieldFixture($fixture, $newPosition)
99			{
100			// Locate the resource fixture and the specified fixture
101			/** @var Resource $resource */
102			$resource = $this->objFromFixture(Resource::class, 'teachers');
103			$field = $this->objFromFixture(ResourceField::class, $fixture);
104
105			// Form a request
106			$token = SecurityToken::create();
107			$request = new HTTPRequest('POST', 'ItemEditForm', [], [
108			'Position' => $newPosition,
109			'action_doSave' => 1,
110			$token->getName() => $token->getValue(),
111			]);
112			$request->setSession(Controller::curr()->getRequest()->getSession());
113
114			// Build the gridfield and component
115			$config = GridFieldConfig::create();
116			$detailForm = new GridFieldDetailForm;
117			$config->addComponent($detailForm->setItemRequestClass(ResourceFieldItemRequest::class));
118			$gridField = new GridField('Test', 'Test', $resource->Fields(), $config);
119			$formMock = $this->createMock(Form::class);
120			$formMock->method('FormAction')->willReturn('test');
121			$gridField->setForm($formMock);
122			$controllerMock = $this->createMock(Controller::class);
123			$controllerMock->method('Link')->willReturn('test');
124			$controllerMock->method('getRequest')->willReturn($request);
125
126			// Create an item request
127			$itemRequest = new ResourceFieldItemRequest(
128			$gridField,
129			$detailForm,
130			$field,
131			$controllerMock,
132			'Test'
133			);
134
135			// Handle our request
136			$itemRequest->handleRequest($request);
137			}
138
139			protected function assertArrayEqualsInOrder($expected, $actual)
140			{
141			$message = 'Failed asserting array in order. Expected '.print_r($expected, true).
142			'. Actual: '.print_r($actual, true);
143
144			foreach ($actual as $key => $value) {
145			$expectedKey = key($expected);
146			$expectedValue = array_shift($expected);
147			$this->assertSame($expectedKey, $key, $message);
148			$this->assertEquals($expectedValue, $value, $message);
149			}
150
151			$this->assertEmpty($expected, $message);
152			}
153			}
154

silverstripe / silverstripe-ckan-registry

Push — master ( a58aad...63ae86 )

testSortingOnResourceSave() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like