silverstripe / silverstripe-ckan-registry

src/Model/ResourceFilter/Dropdown.php

<?php

namespace SilverStripe\CKANRegistry\Model\ResourceFilter;

use SilverStripe\CKANRegistry\Forms\PresentedOptionsField;
use SilverStripe\CKANRegistry\Model\ResourceFilter;
use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\TextField;

/**
 * Provides a single select option for CKAN resources to be filtered by
 */
class Dropdown extends ResourceFilter
{
    private static $db = [

The private property $db is not used, and could be removed.

        'Options' => 'Varchar',
    ];

    private static $table_name = 'CKANFilter_Dropdown';

The private property $table_name is not used, and could be removed.

    private static $singular_name = 'Dropdown';

The private property $singular_name is not used, and could be removed.

    protected $fieldType = DropdownField::class;

    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            $fields->addFieldToTab('Root.Main', PresentedOptionsField::create(
                'Options',
                $this->FilterFor,

The property FilterFor does not exist on SilverStripe\CKANRegistry\Model\ResourceFilter\Dropdown. Since you implemented __get, consider adding a @property annotation.

                _t(__CLASS__ . '.OPTIONS', 'Presented options')
            ));
        });

        return parent::getCMSFields();
    }
}