ResourceDropdownFilter::getCMSFields() - Code Metrics - Inspection of "Ability to add filters, and configure them" - silverstripe/silverstripe-ckan-registry - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#51)

by Robbie

created 2018-12-17 13:30 UTC

ResourceDropdownFilter::getCMSFields() A

↳ Parent: ResourceDropdownFilter

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	0
dl	0
loc	12
rs	10
c	0
b	0
f	0

<?php

namespace SilverStripe\CKANRegistry\Model;

use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\TextField;

class ResourceDropdownFilter extends ResourceFilter
{
    private static $db = [

        'Options' => 'Varchar'
    ];

    private static $singular_name = 'Dropdown Filter';


    protected $fieldType = DropdownField::class;

    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            $fields->push(TextField::create(
                'Options',
                _t(__CLASS__ . '.Options', 'Dropdown options')
            ));

            $fields->removeByName('FilterForID');
        });

        return parent::getCMSFields();
    }
}


1			<?php
2
3			namespace SilverStripe\CKANRegistry\Model;
4
5			use SilverStripe\Forms\DropdownField;
6			use SilverStripe\Forms\FieldList;
7			use SilverStripe\Forms\TextField;
8
9			class ResourceDropdownFilter extends ResourceFilter
10			{
11			private static $db = [
			0 ignored issues – show introduced 2018-12-17 01:32 UTC by Report Bug Copy Issue Report The private property `$db` is not used, and could be removed. Loading history...
12			'Options' => 'Varchar'
13			];
14
15			private static $singular_name = 'Dropdown Filter';
			0 ignored issues – show introduced 2018-12-17 01:32 UTC by Report Bug Copy Issue Report The private property `$singular_name` is not used, and could be removed. Loading history...
16
17			protected $fieldType = DropdownField::class;
18
19			public function getCMSFields()
20			{
21			$this->beforeUpdateCMSFields(function (FieldList $fields) {
22			$fields->push(TextField::create(
23			'Options',
24			_t(__CLASS__ . '.Options', 'Dropdown options')
25			));
26
27			$fields->removeByName('FilterForID');
28			});
29
30			return parent::getCMSFields();
31			}
32			}
33

silverstripe / silverstripe-ckan-registry

Pull Request — master (#51)

ResourceDropdownFilter::getCMSFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like