silverstripe / silverstripe-campaign-admin

src/SiteTreeExtension.php

<?php

namespace SilverStripe\CampaignAdmin;

use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\Tab;
use SilverStripe\ORM\DataExtension;
use SilverStripe\Security\Permission;

/**
 * Handles adding the "Add to Campaign" button to a page's secondary actions menu
 */
class SiteTreeExtension extends DataExtension
{
    public function updateCMSActions(FieldList $actions)
    {
        // Add to campaign option if not-archived and has publish permission
        if ((!$this->owner->isPublished() && !$this->owner->isOnDraft())
            || !$this->owner->canPublish()
            || !Permission::check('CMS_ACCESS_CampaignAdmin')
        ) {
            return;
        }

        /** @var Tab $moreOptions */
        $moreOptions = $actions->fieldByName('ActionMenus.MoreOptions');

Are you sure the assignment to $moreOptions is correct as $actions->fieldByName('ActionMenus.MoreOptions') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

        if (!$moreOptions) {

$moreOptions is of type SilverStripe\Forms\Tab, thus it always evaluated to true.

            return;
        }

        $moreOptions->insertAfter(
            'Information',
            AddToCampaignHandler_FormAction::create()
                ->removeExtraClass('btn-primary')
                ->addExtraClass('btn-secondary')
        );
    }
}