BlogCategoryTest - Code Metrics - Inspection of "FIX Prevent duplicate tags and categories." - silverstripe/silverstripe-blog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#372)

by Michael

created 2016-02-05 23:20 UTC

BlogCategoryTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	144
Duplicated Lines	61.81 %

Coupling/Cohesion

Components	1
Dependencies	8

Metric	Value
wmc	10
lcom	1
cbo	8
dl	89
loc	144
rs	10

8 Methods

Rating	Name	Duplication	Size	Complexity
A	testCanEdit()	21	22	1
A	setUp()	0	6	1
A	tearDown()	0	6	1
A	testBlogPosts()	16	17	2
A	testCanView()	0	11	1
A	testCanCreate()	11	12	1
A	testCanDelete()	19	20	1
A	testDuplicateCategories()	22	22	2

How to fix Duplicated Code

<?php

/**
 * @mixin PHPUnit_Framework_TestCase
 */
class BlogCategoryTest extends FunctionalTest
namespace YourVendor;

class YourClass { }
{
    /**
     * @var string
     */
    public static $fixture_file = 'blog.yml';

    /**
     * {@inheritdoc}
     */
    public function setUp()
    {
        parent::setUp();

        SS_Datetime::set_mock_now('2013-10-10 20:00:00');
    }

    /**
     * {@inheritdoc}
     */
    public function tearDown()
    {
        SS_Datetime::clear_mock_now();

        parent::tearDown();
    }

    /**
     * Tests that any blog posts returned from $category->BlogPosts() many_many are published,
     * both by normal 'save & publish' functionality and by publish date.
     */
    public function testBlogPosts()

    {
        $member = Member::currentUser();

        if ($member) {
            $member->logout();
        }

        $this->objFromFixture('BlogPost', 'FirstBlogPost');

        /**
         * @var BlogCategory $category
         */
        $category = $this->objFromFixture('BlogCategory', 'FirstCategory');

        $this->assertEquals(5, $category->BlogPosts()->count(), 'Category blog post count');

    }

    public function testCanView()
    {
        $this->useDraftSite();

        $this->objFromFixture('Member', 'Admin');

        $editor = $this->objFromFixture('Member', 'Editor');
        $category = $this->objFromFixture('BlogCategory', 'SecondCategory');

        $this->assertFalse($category->canView($editor), 'Editor should not be able to view category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * The first blog can be viewed by anybody.
     */
    public function testCanEdit()

    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $category = $this->objFromFixture('BlogCategory', 'FirstCategory');

        $this->assertTrue($category->canEdit($admin), 'Admin should be able to edit category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($category->canEdit($editor), 'Editor should be able to edit category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $category = $this->objFromFixture('BlogCategory', 'SecondCategory');

        $this->assertTrue($category->canEdit($admin), 'Admin should be able to edit category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertFalse($category->canEdit($editor), 'Editor should not be able to edit category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $category = $this->objFromFixture('BlogCategory', 'ThirdCategory');

        $this->assertTrue($category->canEdit($admin), 'Admin should always be able to edit category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($category->canEdit($editor), 'Editor should be able to edit category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanCreate()

    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $category = singleton('BlogCategory');

        $this->assertTrue($category->canCreate($admin), 'Admin should be able to create category.');

        $this->assertTrue($category->canCreate($editor), 'Editor should be able to create category.');

    }

    public function testCanDelete()

    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $category = $this->objFromFixture('BlogCategory', 'FirstCategory');

        $this->assertTrue($category->canDelete($admin), 'Admin should be able to delete category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($category->canDelete($editor), 'Editor should be able to category category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $category = $this->objFromFixture('BlogCategory', 'SecondCategory');
        $this->assertTrue($category->canDelete($admin), 'Admin should be able to delete category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertFalse($category->canDelete($editor), 'Editor should not be able to delete category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $category = $this->objFromFixture('BlogCategory', 'ThirdCategory');
        $this->assertTrue($category->canDelete($admin), 'Admin should always be able to delete category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($category->canDelete($editor), 'Editor should be able to delete category.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testDuplicateCategories() {

        $blog = new Blog();
        $blog->Title = 'Testing for duplicate categories';
        $blog->write();

        $category = new BlogCategory();
        $category->Title = 'Test';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $category->BlogID = $blog->ID;
        $category->write();

        $category = new BlogCategory();
        $category->Title = 'Test';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $category->BlogID = $blog->ID;
        try {
            $category->write();
            $this->fail('Duplicate BlogCategory written');

        } catch (ValidationException $e) {
            $codeList = $e->getResult()->codeList();
            $this->assertCount(1, $codeList);

            $this->assertEquals(BlogTag::DUPLICATE_EXCEPTION, $codeList[0]);

        }
    }
}


1		<?php
2
3		/**
4		* @mixin PHPUnit_Framework_TestCase
5		*/
6		class BlogCategoryTest extends FunctionalTest
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		/**
9		* @var string
10		*/
11		public static $fixture_file = 'blog.yml';
12
13		/**
14		* {@inheritdoc}
15		*/
16		public function setUp()
17		{
18		parent::setUp();
19
20		SS_Datetime::set_mock_now('2013-10-10 20:00:00');
21		}
22
23		/**
24		* {@inheritdoc}
25		*/
26		public function tearDown()
27		{
28		SS_Datetime::clear_mock_now();
29
30		parent::tearDown();
31		}
32
33		/**
34		* Tests that any blog posts returned from $category->BlogPosts() many_many are published,
35		* both by normal 'save & publish' functionality and by publish date.
36		*/
37	View Code Duplication	public function testBlogPosts()
		0 ignored issues – show Duplication introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		$member = Member::currentUser();
40
41		if ($member) {
42		$member->logout();
43		}
44
45		$this->objFromFixture('BlogPost', 'FirstBlogPost');
46
47		/**
48		* @var BlogCategory $category
49		*/
50		$category = $this->objFromFixture('BlogCategory', 'FirstCategory');
51
52		$this->assertEquals(5, $category->BlogPosts()->count(), 'Category blog post count');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
53		}
54
55		public function testCanView()
56		{
57		$this->useDraftSite();
58
59		$this->objFromFixture('Member', 'Admin');
60
61		$editor = $this->objFromFixture('Member', 'Editor');
62		$category = $this->objFromFixture('BlogCategory', 'SecondCategory');
63
64		$this->assertFalse($category->canView($editor), 'Editor should not be able to view category.');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$editor` defined by `$this->objFromFixture('Member', 'Editor')` on line `61` can also be of type `object<DataObject>`; however, `DataObject::canView()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
65		}
66
67		/**
68		* The first blog can be viewed by anybody.
69		*/
70	View Code Duplication	public function testCanEdit()
		0 ignored issues – show Duplication introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		{
72		$this->useDraftSite();
73
74		$admin = $this->objFromFixture('Member', 'Admin');
75		$editor = $this->objFromFixture('Member', 'Editor');
76
77		$category = $this->objFromFixture('BlogCategory', 'FirstCategory');
78
79		$this->assertTrue($category->canEdit($admin), 'Admin should be able to edit category.');
		0 ignored issues – show Bug introduced 2015-11-21 06:19 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'Admin')` on line `74` can also be of type `object<DataObject>`; however, `DataObject::canEdit()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
80		$this->assertTrue($category->canEdit($editor), 'Editor should be able to edit category.');
		0 ignored issues – show Bug introduced 2015-11-21 06:19 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$editor` defined by `$this->objFromFixture('Member', 'Editor')` on line `75` can also be of type `object<DataObject>`; however, `DataObject::canEdit()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
81
82		$category = $this->objFromFixture('BlogCategory', 'SecondCategory');
83
84		$this->assertTrue($category->canEdit($admin), 'Admin should be able to edit category.');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'Admin')` on line `74` can also be of type `object<DataObject>`; however, `DataObject::canEdit()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
85		$this->assertFalse($category->canEdit($editor), 'Editor should not be able to edit category.');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$editor` defined by `$this->objFromFixture('Member', 'Editor')` on line `75` can also be of type `object<DataObject>`; however, `DataObject::canEdit()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
86
87		$category = $this->objFromFixture('BlogCategory', 'ThirdCategory');
88
89		$this->assertTrue($category->canEdit($admin), 'Admin should always be able to edit category.');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'Admin')` on line `74` can also be of type `object<DataObject>`; however, `DataObject::canEdit()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
90		$this->assertTrue($category->canEdit($editor), 'Editor should be able to edit category.');
		0 ignored issues – show Bug introduced 2015-11-21 06:19 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$editor` defined by `$this->objFromFixture('Member', 'Editor')` on line `75` can also be of type `object<DataObject>`; however, `DataObject::canEdit()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
91		}
92
93	View Code Duplication	public function testCanCreate()
		0 ignored issues – show Duplication introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		{
95		$this->useDraftSite();
96
97		$admin = $this->objFromFixture('Member', 'Admin');
98		$editor = $this->objFromFixture('Member', 'Editor');
99
100		$category = singleton('BlogCategory');
101
102		$this->assertTrue($category->canCreate($admin), 'Admin should be able to create category.');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
103		$this->assertTrue($category->canCreate($editor), 'Editor should be able to create category.');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
104		}
105
106	View Code Duplication	public function testCanDelete()
		0 ignored issues – show Duplication introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		{
108		$this->useDraftSite();
109
110		$admin = $this->objFromFixture('Member', 'Admin');
111		$editor = $this->objFromFixture('Member', 'Editor');
112
113		$category = $this->objFromFixture('BlogCategory', 'FirstCategory');
114
115		$this->assertTrue($category->canDelete($admin), 'Admin should be able to delete category.');
		0 ignored issues – show Bug introduced 2015-11-21 06:19 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'Admin')` on line `110` can also be of type `object<DataObject>`; however, `DataObject::canDelete()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
116		$this->assertTrue($category->canDelete($editor), 'Editor should be able to category category.');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$editor` defined by `$this->objFromFixture('Member', 'Editor')` on line `111` can also be of type `object<DataObject>`; however, `DataObject::canDelete()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
117
118		$category = $this->objFromFixture('BlogCategory', 'SecondCategory');
119		$this->assertTrue($category->canDelete($admin), 'Admin should be able to delete category.');
		0 ignored issues – show Bug introduced 2015-11-21 06:19 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'Admin')` on line `110` can also be of type `object<DataObject>`; however, `DataObject::canDelete()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
120		$this->assertFalse($category->canDelete($editor), 'Editor should not be able to delete category.');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$editor` defined by `$this->objFromFixture('Member', 'Editor')` on line `111` can also be of type `object<DataObject>`; however, `DataObject::canDelete()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
121
122		$category = $this->objFromFixture('BlogCategory', 'ThirdCategory');
123		$this->assertTrue($category->canDelete($admin), 'Admin should always be able to delete category.');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'Admin')` on line `110` can also be of type `object<DataObject>`; however, `DataObject::canDelete()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
124		$this->assertTrue($category->canDelete($editor), 'Editor should be able to delete category.');
		0 ignored issues – show Bug introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2016-02-04 22:09 UTC by Report Bug Copy Issue Report It seems like `$editor` defined by `$this->objFromFixture('Member', 'Editor')` on line `111` can also be of type `object<DataObject>`; however, `DataObject::canDelete()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
125		}
126
127	View Code Duplication	public function testDuplicateCategories() {
		0 ignored issues – show Duplication introduced 2016-02-05 23:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
128		$blog = new Blog();
129		$blog->Title = 'Testing for duplicate categories';
130		$blog->write();
131
132		$category = new BlogCategory();
133		$category->Title = 'Test';
		0 ignored issues – show Documentation introduced 2016-02-05 23:22 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<BlogCategory>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
134		$category->BlogID = $blog->ID;
135		$category->write();
136
137		$category = new BlogCategory();
138		$category->Title = 'Test';
		0 ignored issues – show Documentation introduced 2016-02-05 23:22 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<BlogCategory>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
139		$category->BlogID = $blog->ID;
140		try {
141		$category->write();
142		$this->fail('Duplicate BlogCategory written');
		0 ignored issues – show Bug introduced 2016-02-05 23:22 UTC by Report Bug Copy Issue Report The method `fail()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
143		} catch (ValidationException $e) {
144		$codeList = $e->getResult()->codeList();
145		$this->assertCount(1, $codeList);
		0 ignored issues – show Bug introduced 2016-02-05 23:22 UTC by Report Bug Copy Issue Report The method `assertCount()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
146		$this->assertEquals(BlogTag::DUPLICATE_EXCEPTION, $codeList[0]);
		0 ignored issues – show Bug introduced 2016-02-05 23:22 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<BlogCategoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
147		}
148		}
149		}
150

silverstripe / silverstripe-blog

Pull Request — master (#372)

BlogCategoryTest A

Complexity

Size/Duplication

Coupling/Cohesion

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like