BlogCategory

Complexity

Total Complexity

17

Size/Duplication

Total Lines	176
Duplicated Lines	98.86 %

Coupling/Cohesion

Components	1
Dependencies	9

8 Methods

Rating	Name	Duplication	Size	Complexity
A	BlogPosts()	8	8	1
A	getCMSFields()	10	10	1
B	validate()	21	21	6
A	getLink()	4	4	1
A	canView()	10	10	2
A	canCreate()	12	12	2
A	canDelete()	10	10	2
A	canEdit()	9	10	2

<?php

/**
 * A blog category for generalising blog posts.
 *
 * @package silverstripe
 * @subpackage blog
 *
 * @method Blog Blog()
 *
 * @property string $URLSegment
 * @property int $BlogID
 */
class BlogCategory extends DataObject implements CategorisationObject

This class seems to be duplicated in your project.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * Use an exception code so that attempted writes can continue on
     * duplicate errors. 600 is completely arbitrary.
     *
     * @const string
     * This must be a string because ValidationException has decided we can't use int
     */
    const DUPLICATE_EXCEPTION = "DUPLICATE";

    /**
     * @var array
     */
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'Title' => 'Varchar(255)',
    );

    /**
     * @var array
     */
    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'Blog' => 'Blog',
    );

    /**
     * @var array
     */
    private static $belongs_many_many = array(

Consider using a different property name as you override a private property of the parent class.

The property $belongs_many_many is not used and could be removed.

        'BlogPosts' => 'BlogPost',
    );

    /**
     * @var array
     */
    private static $extensions = array(

Consider using a different property name as you override a private property of the parent class.

The property $extensions is not used and could be removed.

        'URLSegmentExtension',
    );

    /**
     * @return DataList
     */
    public function BlogPosts()
    {
        $blogPosts = parent::BlogPosts();

It seems like you code against a specific sub-type and not the parent class DataObject as the method BlogPosts() does only exist in the following sub-classes of DataObject: BlogCategory, BlogTag. Maybe you want to instanceof check for one of these explicitly?

        $this->extend("updateGetBlogPosts", $blogPosts);

        return $blogPosts;
    }

    /**
     * {@inheritdoc}
     */
    public function getCMSFields()
    {
        $fields = new FieldList(
            TextField::create('Title', _t('BlogCategory.Title', 'Title'))
        );

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }

    /**
     * {@inheritdoc}
     */
    protected function validate()
    {
        $validation = parent::validate();
        if($validation->valid()) {
            // Check for duplicate categories
            $blog = $this->Blog();
            if($blog && $blog->exists()) {
                $existing = $blog->Categories()->filter('Title', $this->Title);

The property Title does not exist on object<BlogCategory>. Since you implemented __get, maybe consider adding a @property annotation.

                if($this->ID) {
                    $existing = $existing->exclude('ID', $this->ID);
                }
                if($existing->count() > 0) {
                    $validation->error(_t(
                        'BlogCategory.Duplicate',
                        'A blog category already exists with that name'
                    ), BlogCategory::DUPLICATE_EXCEPTION);
                }
            }
        }
        return $validation;
    }

    /**
     * Returns a relative link to this category.
     *
     * @return string
     */
    public function getLink()
    {
        return Controller::join_links($this->Blog()->Link(), 'category', $this->URLSegment);
    }


    /**
     * Inherits from the parent blog or can be overwritten using a DataExtension.
     *
     * @param null|Member $member
     *
     * @return bool
     */
    public function canView($member = null)
    {
        $extended = $this->extendedCan(__FUNCTION__, $member);

It seems like $member defined by parameter $member on line 123 can be null; however, DataObject::extendedCan() does not accept null, maybe add an additional type check?

        if ($extended !== null) {
            return $extended;
        }

        return $this->Blog()->canView($member);
    }

    /**
     * Inherits from the parent blog or can be overwritten using a DataExtension.
     *
     * @param null|Member $member
     *
     * @return bool
     */
    public function canCreate($member = null)
    {
        $extended = $this->extendedCan(__FUNCTION__, $member);

It seems like $member defined by parameter $member on line 141 can be null; however, DataObject::extendedCan() does not accept null, maybe add an additional type check?

        if ($extended !== null) {
            return $extended;
        }

        $permission = Blog::config()->grant_user_permission;

        return Permission::checkMember($member, $permission);
    }

    /**
     * Inherits from the parent blog or can be overwritten using a DataExtension.
     *
     * @param null|Member $member
     *
     * @return bool
     */
    public function canDelete($member = null)
    {
        $extended = $this->extendedCan(__FUNCTION__, $member);

It seems like $member defined by parameter $member on line 161 can be null; however, DataObject::extendedCan() does not accept null, maybe add an additional type check?

        if ($extended !== null) {
            return $extended;
        }

        return $this->Blog()->canEdit($member);
    }

    /**
     * Inherits from the parent blog or can be overwritten using a DataExtension.
     *
     * @param null|Member $member
     *
     * @return bool
     */
    public function canEdit($member = null)
    {
        $extended = $this->extendedCan(__FUNCTION__, $member);

It seems like $member defined by parameter $member on line 179 can be null; however, DataObject::extendedCan() does not accept null, maybe add an additional type check?

        if ($extended !== null) {
            return $extended;
        }

        return $this->Blog()->canEdit($member);
    }
}