BlogTagTest - Code Metrics - Inspection of "FIX: updated test suite to cover supported version..." - silverstripe/silverstripe-blog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#438)

by Sam

created 2017-05-11 00:30 UTC

BlogTagTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	203
Duplicated Lines	53.2 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	13
c	1
b	0
f	0
lcom	1
cbo	9
dl	108
loc	203
rs	10

11 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
A	tearDown()	0	6	1
A	testBlogPosts()	17	17	2
A	testAllowMultibyteUrlSegment()	12	12	1
A	testCanView()	0	17	1
A	testCanCreate()	12	12	1
A	testDuplicateTagsForURLSegment()	0	17	1
B	testDuplicateTags()	25	25	2
A	testCanEdit()	21	22	1
A	testCanDelete()	21	22	1
A	testBlogTagUrlSegmentsAreAutomaticallyUpdated()	0	11	1

How to fix Duplicated Code

<?php

namespace SilverStripe\Blog\Tests;

use SilverStripe\Blog\Model\Blog;
use SilverStripe\Blog\Model\BlogPost;
use SilverStripe\Blog\Model\BlogTag;
use SilverStripe\Control\Controller;
use SilverStripe\Dev\FunctionalTest;
use SilverStripe\ORM\FieldType\DBDatetime;
use SilverStripe\ORM\ValidationException;
use SilverStripe\Security\Member;

/**
 * @mixin PHPUnit_Framework_TestCase
 */
class BlogTagTest extends FunctionalTest
{
    /**
     * {@inheritDoc}
     * @var string
     */
    protected static $fixture_file = 'blog.yml';

    /**
     * {@inheritdoc}
     */
    public function setUp()
    {
        parent::setUp();

        DBDatetime::set_mock_now('2013-10-10 20:00:00');
    }

    /**
     * {@inheritdoc}
     */
    public function tearDown()
    {
        DBDatetime::clear_mock_now();

        parent::tearDown();
    }

    /**
     * Tests that any blog posts returned from $tag->BlogPosts() many_many are published, both by
     * normal 'save & publish' functionality and by publish date.
     */
    public function testBlogPosts()

    {
        $member = Member::currentUser();

        if ($member) {
            $member->logout();
        }

        $this->objFromFixture('SiteTree', 'FirstBlogPost');

        /**
         * @var BlogTag $tag
         */
        $tag = $this->objFromFixture('BlogTag', 'FirstTag');

        $this->assertEquals(1, $tag->BlogPosts()->count(), 'Tag blog post count');

    }

    /**
     * @see https://github.com/silverstripe/silverstripe-blog/issues/376
     */
    public function testAllowMultibyteUrlSegment()

    {
        $blog = $this->objFromFixture('SiteTree', 'FirstBlog');
        $tag = new BlogTag();
        $tag->BlogID = $blog->ID;
        $tag->Title = 'تست';
        $tag->write();
        // urlencoded
        $this->assertEquals('%D8%AA%D8%B3%D8%AA', $tag->URLSegment);

        $link = Controller::join_links($tag->Blog()->Link(), 'tag', '%D8%AA%D8%B3%D8%AA');
        $this->assertEquals($link, $tag->getLink());

    }

    /**
     * The first blog can be viewed by anybody.
     */
    public function testCanView()
    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $tag = $this->objFromFixture('BlogTag', 'FirstTag');

        $this->assertTrue($tag->canView($admin), 'Admin should be able to view tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($tag->canView($editor), 'Editor should be able to view tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $tag = $this->objFromFixture('BlogTag', 'SecondTag');

        $this->assertTrue($tag->canView($admin), 'Admin should be able to view tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertFalse($tag->canView($editor), 'Editor should not be able to view tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanEdit()

    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $tag = $this->objFromFixture('BlogTag', 'FirstTag');

        $this->assertTrue($tag->canEdit($admin), 'Admin should be able to edit tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($tag->canEdit($editor), 'Editor should be able to edit tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $tag = $this->objFromFixture('BlogTag', 'SecondTag');

        $this->assertTrue($tag->canEdit($admin), 'Admin should be able to edit tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertFalse($tag->canEdit($editor), 'Editor should not be able to edit tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $tag = $this->objFromFixture('BlogTag', 'ThirdTag');

        $this->assertTrue($tag->canEdit($admin), 'Admin should always be able to edit tags.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($tag->canEdit($editor), 'Editor should be able to edit tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanCreate()

    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $tag = singleton(BlogTag::class);

        $this->assertTrue($tag->canCreate($admin), 'Admin should be able to create tag.');

        $this->assertTrue($tag->canCreate($editor), 'Editor should be able to create tag.');

    }

    public function testCanDelete()

    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $tag = $this->objFromFixture('BlogTag', 'FirstTag');

        $this->assertTrue($tag->canDelete($admin), 'Admin should be able to delete tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($tag->canDelete($editor), 'Editor should be able to delete tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $tag = $this->objFromFixture('BlogTag', 'SecondTag');

        $this->assertTrue($tag->canDelete($admin), 'Admin should be able to delete tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertFalse($tag->canDelete($editor), 'Editor should not be able to delete tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $tag = $this->objFromFixture('BlogTag', 'ThirdTag');

        $this->assertTrue($tag->canDelete($admin), 'Admin should always be able to delete tags.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($tag->canDelete($editor), 'Editor should be able to delete tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testDuplicateTagsForURLSegment()
    {
        $blog = new Blog();
        $blog->Title = 'Testing for duplicates blog';
        $blog->write();
        $tag1 = new BlogTag();
        $tag1->Title = 'cat-test';
        $tag1->BlogID = $blog->ID;
        $tag1->write();
        $this->assertEquals('cat-test', $tag1->URLSegment);


        $tag2 = new BlogTag();
        $tag2->Title = 'cat test';
        $tag2->BlogID = $blog->ID;
        $tag2->write();
        $this->assertEquals('cat-test-1', $tag2->URLSegment);

    }

    public function testDuplicateTags()

    {
        $blog = new Blog();
        $blog->Title = 'Testing for duplicate tags';
        $blog->write();

        $tag = new BlogTag();
        $tag->Title = 'Test';
        $tag->BlogID = $blog->ID;
        $tag->URLSegment = 'test';
        $tag->write();

        $tag = new BlogTag();
        $tag->Title = 'Test';
        $tag->URLSegment = 'test';
        $tag->BlogID = $blog->ID;
        try {
            $tag->write();
            $this->fail('Duplicate BlogTag written');

        } catch (ValidationException $e) {
            $messages = $e->getResult()->getMessages();
            $this->assertCount(1, $messages);

            $this->assertEquals(BlogTag::DUPLICATE_EXCEPTION, $messages[0]['messageType']);

        }
    }

    public function testBlogTagUrlSegmentsAreAutomaticallyUpdated()
    {
        $tag = new BlogTag;
        $tag->Title = "a test";
        $tag->write();
        $this->assertEquals($tag->URLSegment, "a-test");


        $tag->Title = "another test";
        $tag->write();
        $this->assertEquals($tag->URLSegment, "another-test");

    }

}


1			<?php
2
3			namespace SilverStripe\Blog\Tests;
4
5			use SilverStripe\Blog\Model\Blog;
6			use SilverStripe\Blog\Model\BlogPost;
7			use SilverStripe\Blog\Model\BlogTag;
8			use SilverStripe\Control\Controller;
9			use SilverStripe\Dev\FunctionalTest;
10			use SilverStripe\ORM\FieldType\DBDatetime;
11			use SilverStripe\ORM\ValidationException;
12			use SilverStripe\Security\Member;
13
14			/**
15			* @mixin PHPUnit_Framework_TestCase
16			*/
17			class BlogTagTest extends FunctionalTest
18			{
19			/**
20			* {@inheritDoc}
21			* @var string
22			*/
23			protected static $fixture_file = 'blog.yml';
24
25			/**
26			* {@inheritdoc}
27			*/
28			public function setUp()
29			{
30			parent::setUp();
31
32			DBDatetime::set_mock_now('2013-10-10 20:00:00');
33			}
34
35			/**
36			* {@inheritdoc}
37			*/
38			public function tearDown()
39			{
40			DBDatetime::clear_mock_now();

silverstripe / silverstripe-blog

Pull Request — master (#438)

BlogTagTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like