SilverStripe\Blog\Tests\BlogPostTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	104
Duplicated Lines	9.62 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	tearDown()	0	5	1
A	testCanView()	0	7	1
B	canViewProvider()	0	32	1
A	testCandidateAuthors()	0	15	1
A	testCanViewFuturePost()	10	10	1
A	testGetDate()	0	8	1

<?php

namespace SilverStripe\Blog\Tests;

use SilverStripe\Blog\Model\BlogPost;
use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\FieldType\DBDatetime;
use SilverStripe\Security\Member;

class BlogPostTest extends SapphireTest
{
    /**
     * {@inheritDoc}
     * @var string
     */
    protected static $fixture_file = 'blog.yml';

    /**
     * {@inheritdoc}
     */
    public function tearDown()
    {
        DBDatetime::clear_mock_now();
        parent::tearDown();
    }

    /**
     * @dataProvider canViewProvider
     */
    public function testCanView($date, $user, $page, $canView)
    {
        $userRecord = $this->objFromFixture(Member::class, $user);
        $pageRecord = $this->objFromFixture(BlogPost::class, $page);
        DBDatetime::set_mock_now($date);
        $this->assertEquals($canView, $pageRecord->canView($userRecord));

It seems like $userRecord defined by $this->objFromFixture(\SilverStripe\Security\Member::class, $user) on line 33 can also be of type object<SilverStripe\ORM\DataObject>; however, SilverStripe\ORM\DataObject::canView() does only seem to accept object<SilverStripe\Security\Member>|null, maybe add an additional type check?

    }

    /**
     * @return array
     */
    public function canViewProvider()
    {
        $someFutureDate = '2013-10-10 20:00:00';
        $somePastDate = '2009-10-10 20:00:00';
        return [
            // Check this post given the date has passed
            [$someFutureDate, 'Editor', 'PostA', true],
            [$someFutureDate, 'Contributor', 'PostA', true],
            [$someFutureDate, 'BlogEditor', 'PostA', true],
            [$someFutureDate, 'Writer', 'PostA', true],

            // Check unpublished pages
            [$somePastDate, 'Editor', 'PostA', true],
            [$somePastDate, 'Contributor', 'PostA', true],
            [$somePastDate, 'BlogEditor', 'PostA', true],
            [$somePastDate, 'Writer', 'PostA', true],

            // Test a page that was authored by another user

            // Check this post given the date has passed
            [$someFutureDate, 'Editor', 'FirstBlogPost', true],
            [$someFutureDate, 'Contributor', 'FirstBlogPost', true],
            [$someFutureDate, 'BlogEditor', 'FirstBlogPost', true],
            [$someFutureDate, 'Writer', 'FirstBlogPost', true],

            // Check future pages - non-editors shouldn't be able to see this
            [$somePastDate, 'Editor', 'FirstBlogPost', true],
            [$somePastDate, 'Contributor', 'FirstBlogPost', false],
            [$somePastDate, 'BlogEditor', 'FirstBlogPost', false],
            [$somePastDate, 'Writer', 'FirstBlogPost', false],
        ];
    }

    public function testCandidateAuthors()
    {
        $blogpost = $this->objFromFixture(BlogPost::class, 'PostC');

        $this->assertEquals(7, $blogpost->getCandidateAuthors()->count());

        //Set the group to draw Members from
        Config::inst()->update(BlogPost::class, 'restrict_authors_to_group', 'blogusers');

It seems like you code against a concrete implementation and not the interface SilverStripe\Config\Collections\ConfigCollectionInterface as the method update() does only exist in the following implementations of said interface: SilverStripe\Config\Collections\DeltaConfigCollection, SilverStripe\Config\Collections\MemoryConfigCollection.

        $this->assertEquals(3, $blogpost->getCandidateAuthors()->count());

        // Test cms field is generated
        $fields = $blogpost->getCMSFields();
        $this->assertNotEmpty($fields->dataFieldByName('Authors'));
    }

    public function testCanViewFuturePost()

This method seems to be duplicated in your project.

    {
        $blogPost = $this->objFromFixture(BlogPost::class, 'NullPublishDate');

        $editor = $this->objFromFixture(Member::class, 'BlogEditor');
        $this->assertTrue($blogPost->canView($editor));

It seems like $editor defined by $this->objFromFixture(\SilverStripe\Security\Member::class, 'BlogEditor') on line 95 can also be of type object<SilverStripe\ORM\DataObject>; however, SilverStripe\ORM\DataObject::canView() does only seem to accept object<SilverStripe\Security\Member>|null, maybe add an additional type check?

        $visitor = $this->objFromFixture(Member::class, 'Visitor');
        $this->assertFalse($blogPost->canView($visitor));

It seems like $visitor defined by $this->objFromFixture(\SilverStripe\Security\Member::class, 'Visitor') on line 98 can also be of type object<SilverStripe\ORM\DataObject>; however, SilverStripe\ORM\DataObject::canView() does only seem to accept object<SilverStripe\Security\Member>|null, maybe add an additional type check?

    }

    /**
     * The purpose of getDate() is to act as a proxy for PublishDate in the default RSS
     * template, rather than copying the entire template.
     */
    public function testGetDate()
    {
        $blogPost = $this->objFromFixture(BlogPost::class, 'NullPublishDate');
        $this->assertNull($blogPost->getDate());

        $blogPost = $this->objFromFixture(BlogPost::class, 'PostA');
        $this->assertEquals('2012-01-09 15:00:00', $blogPost->getDate());
    }
}