BlogTagTest::testAllowMultibyteUrlSegment() - Code Metrics - Inspection of "FIX #376 allow multibyte chars in url segment" - silverstripe/silverstripe-blog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#402)

by Michael

created 2016-05-31 02:09 UTC

BlogTagTest::testAllowMultibyteUrlSegment() A

↳ Parent: BlogTagTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	12
Ratio	100 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	12
loc	12
rs	9.4285
cc	1
eloc	9
nc	1
nop	0

<?php

/**
 * @mixin PHPUnit_Framework_TestCase
 */
class BlogTagTest extends FunctionalTest
namespace YourVendor;

class YourClass { }
{
    /**
     * @var string
     */
    public static $fixture_file = 'blog.yml';

    /**
     * {@inheritdoc}
     */
    public function setUp()
    {
        parent::setUp();

        SS_Datetime::set_mock_now('2013-10-10 20:00:00');
    }

    /**
     * {@inheritdoc}
     */
    public function tearDown()
    {
        SS_Datetime::clear_mock_now();

        parent::tearDown();
    }

    /**
     * Tests that any blog posts returned from $tag->BlogPosts() many_many are published, both by
     * normal 'save & publish' functionality and by publish date.
     */
    public function testBlogPosts()

    {
        $member = Member::currentUser();

        if ($member) {
            $member->logout();
        }

        $this->objFromFixture('BlogPost', 'FirstBlogPost');

        /**
         * @var BlogTag $tag
         */
        $tag = $this->objFromFixture('BlogTag', 'FirstTag');

        $this->assertEquals(1, $tag->BlogPosts()->count(), 'Tag blog post count');

    }

    /**
     * @see https://github.com/silverstripe/silverstripe-blog/issues/376
     */
    public function testAllowMultibyteUrlSegment()

    {
        $blog = $this->objFromFixture('Blog', 'FirstBlog');
        $tag = new BlogTag();
        $tag->BlogID = $blog->ID;
        $tag->Title = 'تست';
        $tag->write();
        // urlencoded
        $this->assertEquals('%D8%AA%D8%B3%D8%AA', $tag->URLSegment);

        $link = Controller::join_links($tag->Blog()->Link(), 'tag', '%D8%AA%D8%B3%D8%AA');
        $this->assertEquals($link, $tag->getLink());

    }

    /**
     * The first blog can be viewed by anybody.
     */
    public function testCanView()
    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $tag = $this->objFromFixture('BlogTag', 'FirstTag');

        $this->assertTrue($tag->canView($admin), 'Admin should be able to view tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($tag->canView($editor), 'Editor should be able to view tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $tag = $this->objFromFixture('BlogTag', 'SecondTag');

        $this->assertTrue($tag->canView($admin), 'Admin should be able to view tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertFalse($tag->canView($editor), 'Editor should not be able to view tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanEdit()

    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $tag = $this->objFromFixture('BlogTag', 'FirstTag');

        $this->assertTrue($tag->canEdit($admin), 'Admin should be able to edit tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($tag->canEdit($editor), 'Editor should be able to edit tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $tag = $this->objFromFixture('BlogTag', 'SecondTag');

        $this->assertTrue($tag->canEdit($admin), 'Admin should be able to edit tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertFalse($tag->canEdit($editor), 'Editor should not be able to edit tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $tag = $this->objFromFixture('BlogTag', 'ThirdTag');

        $this->assertTrue($tag->canEdit($admin), 'Admin should always be able to edit tags.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($tag->canEdit($editor), 'Editor should be able to edit tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanCreate()

    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $tag = singleton('BlogTag');

        $this->assertTrue($tag->canCreate($admin), 'Admin should be able to create tag.');

        $this->assertTrue($tag->canCreate($editor), 'Editor should be able to create tag.');

    }

    public function testCanDelete()

    {
        $this->useDraftSite();

        $admin = $this->objFromFixture('Member', 'Admin');
        $editor = $this->objFromFixture('Member', 'Editor');

        $tag = $this->objFromFixture('BlogTag', 'FirstTag');

        $this->assertTrue($tag->canDelete($admin), 'Admin should be able to delete tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($tag->canDelete($editor), 'Editor should be able to delete tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $tag = $this->objFromFixture('BlogTag', 'SecondTag');

        $this->assertTrue($tag->canDelete($admin), 'Admin should be able to delete tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertFalse($tag->canDelete($editor), 'Editor should not be able to delete tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $tag = $this->objFromFixture('BlogTag', 'ThirdTag');

        $this->assertTrue($tag->canDelete($admin), 'Admin should always be able to delete tags.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($tag->canDelete($editor), 'Editor should be able to delete tag.');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testDuplicateTagsForURLSegment() {
        $blog = new Blog();
        $blog->Title = 'Testing for duplicates blog';
        $blog->write();
        $tag1 = new BlogTag();
        $tag1->Title = 'cat-test';
        $tag1->BlogID = $blog->ID;
        $tag1->write();
        $this->assertEquals('cat-test', $tag1->URLSegment);


        $tag2 = new BlogTag();
        $tag2->Title = 'cat test';
        $tag2->BlogID = $blog->ID;
        $tag2->write();
        $this->assertEquals('cat-test-0', $tag2->URLSegment);


    }

    public function testDuplicateTags() {

        $blog = new Blog();
        $blog->Title = 'Testing for duplicate tags';
        $blog->write();

        $tag = new BlogTag();
        $tag->Title = 'Test';
        $tag->BlogID = $blog->ID;
        $tag->write();

        $tag = new BlogTag();
        $tag->Title = 'Test';
        $tag->BlogID = $blog->ID;
        try {
            $tag->write();
            $this->fail('Duplicate BlogTag written');

        } catch (ValidationException $e) {
            $codeList = $e->getResult()->codeList();
            $this->assertCount(1, $codeList);

            $this->assertEquals(BlogTag::DUPLICATE_EXCEPTION, $codeList[0]);

        }
    }

}


1		<?php
2
3		/**
4		* @mixin PHPUnit_Framework_TestCase
5		*/
6		class BlogTagTest extends FunctionalTest
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		/**
9		* @var string
10		*/
11		public static $fixture_file = 'blog.yml';
12
13		/**
14		* {@inheritdoc}
15		*/
16		public function setUp()
17		{
18		parent::setUp();
19
20		SS_Datetime::set_mock_now('2013-10-10 20:00:00');
21		}
22
23		/**
24		* {@inheritdoc}
25		*/
26		public function tearDown()
27		{
28		SS_Datetime::clear_mock_now();
29
30		parent::tearDown();
31		}
32
33		/**
34		* Tests that any blog posts returned from $tag->BlogPosts() many_many are published, both by
35		* normal 'save & publish' functionality and by publish date.
36		*/
37	View Code Duplication	public function testBlogPosts()
		0 ignored issues – show Duplication introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{

silverstripe / silverstripe-blog

Pull Request — master (#402)

BlogTagTest::testAllowMultibyteUrlSegment() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like