BlogTest::testRoles() - Code Metrics - Inspection of "Merge pull request #337 from scott1702/master" - silverstripe/silverstripe-blog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.2 ( 8a877d )

by Damian

created 2016-01-18 04:50 UTC

BlogTest::testRoles() B

↳ Parent: BlogTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	119
Code Lines	74

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	119
rs	8.2857
cc	1
eloc	74
nc	1
nop	0

How to fix Long Method

<?php

/**
 * @mixin PHPUnit_Framework_TestCase
 */
class BlogTest extends SapphireTest {
namespace YourVendor;

class YourClass { }
	/**
	 * @var string
	 */
	static $fixture_file = 'blog.yml';
class A {
    var $property;
}

	/**
	 * {@inheritdoc}
	 */
	public function setUp() {
		parent::setUp();

		Config::nest();
		SS_Datetime::set_mock_now('2013-10-10 20:00:00');

		/**
		 * @var Blog $blog
		 */
		$blog = $this->objFromFixture('Blog', 'FirstBlog');

		$blog->publish('Stage', 'Live');
	}

	/**
	 * {@inheritdoc}
	 */
	public function tearDown() {
		SS_Datetime::clear_mock_now();
		Config::unnest();

		parent::tearDown();
	}

	public function testGetExcludedSiteTreeClassNames() {
		$member = Member::currentUser();

		if($member) {
			$member->logout();
		}

		/**
		 * @var Blog $blog
		 */
		$blog = $this->objFromFixture('Blog', 'FirstBlog');

		Config::inst()->update('BlogPost', 'show_in_sitetree', true);
		$classes = $blog->getExcludedSiteTreeClassNames();

		$this->assertNotContains('BlogPost', $classes, 'BlogPost class should be hidden.');

		Config::inst()->update('BlogPost', 'show_in_sitetree', false);
		$classes = $blog->getExcludedSiteTreeClassNames();

		$this->assertContains('BlogPost', $classes, 'BlogPost class should be hidden.');
	}

	public function testGetArchivedBlogPosts() {
		$member = Member::currentUser();

		if($member) {
			$member->logout();
		}

		/**
		 * @var Blog $blog
		 */
		$blog = $this->objFromFixture('Blog', 'FirstBlog');

		$archive = $blog->getArchivedBlogPosts(2013);

		$this->assertEquals(2, $archive->count(), 'Incorrect Yearly Archive count for 2013');

		$this->assertEquals('First Post', $archive->first()->Title, 'Incorrect First Blog post');

		$this->assertEquals('Second Post', $archive->last()->Title, 'Incorrect Last Blog post');


		$archive = $blog->getArchivedBlogPosts(2013, 10);

		$this->assertEquals(1, $archive->count(), 'Incorrect monthly archive count.');


		$archive = $blog->getArchivedBlogPosts(2013, 10, 01);

		$this->assertEquals(1, $archive->count(), 'Incorrect daily archive count.');

	}

	public function testArchiveLinks() {
		/**
		 * @var Blog $blog
		 */
		$blog = $this->objFromFixture('Blog', 'FirstBlog');

		$link = Controller::join_links($blog->Link('archive'), '2013', '10', '01');

		$this->assertEquals(200, $this->getStatusOf($link), 'HTTP Status should be 200');


		$link = Controller::join_links($blog->Link('archive'), '2013', '10');

		$this->assertEquals(200, $this->getStatusOf($link), 'HTTP Status should be 200');


		$link = Controller::join_links($blog->Link('archive'), '2013');

		$this->assertEquals(200, $this->getStatusOf($link), 'HTTP Status should be 200');


		$link = Controller::join_links($blog->Link('archive'), '2011', '10', '01');

		$this->assertEquals(200, $this->getStatusOf($link), 'HTTP Status should be 200');


		$link = Controller::join_links($blog->Link('archive'));
		$this->assertEquals(200, $this->getStatusOf($link), 'HTTP Status should be 200');


		$link = Controller::join_links($blog->Link('archive'), 'invalid-year');

		$this->assertEquals(404, $this->getStatusOf($link), 'HTTP Status should be 404');


		$link = Controller::join_links($blog->Link('archive'), '2013', '99');

		$this->assertEquals(404, $this->getStatusOf($link), 'HTTP Status should be 404');


		$link = Controller::join_links($blog->Link('archive'), '2013', '10', '99');

		$this->assertEquals(404, $this->getStatusOf($link), 'HTTP Status should be 404');


	}

	/*
	 * Test archive year
	 */
	public function testArchiveYear(){
		$blog = $this->objFromFixture('Blog', 'FirstBlog');
		$controller = new Blog_Controller($blog);
		$this->requestURL($controller, 'first-post/archive/');
		$this->assertEquals(2013, $controller->getArchiveYear(), 'getArchiveYear should return 2013');

	}

	/**
	 * @param string $link
	 *
	 * @return int
	 */
	protected function getStatusOf($link) {
		return Director::test($link)->getStatusCode();
	}

	public function testRoles() {
		/**
		 * @var Blog $firstBlog
		 */
		$firstBlog = $this->objFromFixture('Blog', 'FirstBlog');

		/**
		 * @var Blog $fourthBlog
		 */
		$fourthBlog = $this->objFromFixture('Blog', 'FourthBlog');

		/**
		 * @var BlogPost $postA
		 */
		$postA = $this->objFromFixture('BlogPost', 'PostA');

		/**
		 * @var BlogPost $postB
		 */
		$postB = $this->objFromFixture('BlogPost', 'PostB');

		/**
		 * @var BlogPost $postC
		 */
		$postC = $this->objFromFixture('BlogPost', 'PostC');

		/**
		 * @var Member $editor
		 */
		$editor = $this->objFromFixture('Member', 'BlogEditor');

		/**
		 * @var Member $writer
		 */
		$writer = $this->objFromFixture('Member', 'Writer');

		/**
		 * @var Member $contributor
		 */
		$contributor = $this->objFromFixture('Member', 'Contributor');

		/**
		 * @var Member $visitor
		 */
		$visitor = $this->objFromFixture('Member', 'Visitor');

		$this->assertEquals('Editor', $fourthBlog->RoleOf($editor));

		$this->assertEquals('Contributor', $fourthBlog->RoleOf($contributor));

		$this->assertEquals('Writer', $fourthBlog->RoleOf($writer));

		$this->assertEmpty($fourthBlog->RoleOf($visitor));

		$this->assertEquals('Author', $postA->RoleOf($writer));

		$this->assertEquals('Author', $postA->RoleOf($contributor));

		$this->assertEquals('Editor', $postA->RoleOf($editor));

		$this->assertEmpty($postA->RoleOf($visitor));


		// Test RoleOf with string values given
		$this->assertEquals('Editor', $fourthBlog->RoleOf((string)(int)$editor->ID));

		$this->assertEquals('Contributor', $fourthBlog->RoleOf((string)(int)$contributor->ID));

		$this->assertEquals('Writer', $fourthBlog->RoleOf((string)(int)$writer->ID));

		$this->assertEmpty($fourthBlog->RoleOf((string)(int)$visitor->ID));

		$this->assertEquals('Author', $postA->RoleOf((string)(int)$writer->ID));

		$this->assertEquals('Author', $postA->RoleOf((string)(int)$contributor->ID));

		$this->assertEquals('Editor', $postA->RoleOf((string)(int)$editor->ID));

		$this->assertEmpty($postA->RoleOf((string)(int)$visitor->ID));


		// Test RoleOf with int values given
		$this->assertEquals('Editor', $fourthBlog->RoleOf((int)$editor->ID));

		$this->assertEquals('Contributor', $fourthBlog->RoleOf((int)$contributor->ID));

		$this->assertEquals('Writer', $fourthBlog->RoleOf((int)$writer->ID));

		$this->assertEmpty($fourthBlog->RoleOf((int)$visitor->ID));

		$this->assertEquals('Author', $postA->RoleOf((int)$writer->ID));

		$this->assertEquals('Author', $postA->RoleOf((int)$contributor->ID));

		$this->assertEquals('Editor', $postA->RoleOf((int)$editor->ID));

		$this->assertEmpty($postA->RoleOf((int)$visitor->ID));


		$this->assertTrue($fourthBlog->canEdit($editor));

		$this->assertFalse($firstBlog->canEdit($editor));

		$this->assertTrue($fourthBlog->canAddChildren($editor));

		$this->assertFalse($firstBlog->canAddChildren($editor));

		$this->assertTrue($postA->canEdit($editor));

		$this->assertTrue($postB->canEdit($editor));

		$this->assertTrue($postC->canEdit($editor));

		$this->assertTrue($postA->canPublish($editor));

		$this->assertTrue($postB->canPublish($editor));

		$this->assertTrue($postC->canPublish($editor));


		$this->assertFalse($fourthBlog->canEdit($writer));

		$this->assertFalse($firstBlog->canEdit($writer));

		$this->assertTrue($fourthBlog->canAddChildren($writer));

		$this->assertFalse($firstBlog->canAddChildren($writer));

		$this->assertTrue($postA->canEdit($writer));

		$this->assertFalse($postB->canEdit($writer));

		$this->assertTrue($postC->canEdit($writer));

		$this->assertTrue($postA->canPublish($writer));

		$this->assertFalse($postB->canPublish($writer));

		$this->assertTrue($postC->canPublish($writer));


		$this->assertFalse($fourthBlog->canEdit($contributor));

		$this->assertFalse($firstBlog->canEdit($contributor));

		$this->assertTrue($fourthBlog->canAddChildren($contributor));

		$this->assertFalse($firstBlog->canAddChildren($contributor));

		$this->assertTrue($postA->canEdit($contributor));

		$this->assertFalse($postB->canEdit($contributor));

		$this->assertTrue($postC->canEdit($contributor));

		$this->assertFalse($postA->canPublish($contributor));

		$this->assertFalse($postB->canPublish($contributor));

		$this->assertFalse($postC->canPublish($contributor));


		$this->assertFalse($fourthBlog->canEdit($visitor));

		$this->assertFalse($firstBlog->canEdit($visitor));

		$this->assertFalse($fourthBlog->canAddChildren($visitor));

		$this->assertFalse($firstBlog->canAddChildren($visitor));

		$this->assertFalse($postA->canEdit($visitor));

		$this->assertFalse($postB->canEdit($visitor));

		$this->assertFalse($postC->canEdit($visitor));

		$this->assertFalse($postA->canPublish($visitor));

		$this->assertFalse($postB->canPublish($visitor));

		$this->assertFalse($postC->canPublish($visitor));

	}

	public function testFilteredCategories() {
		$blog = $this->objFromFixture('Blog', 'FirstBlog');
		$controller = new Blog_Controller($blog);
		
		// Root url
		$this->requestURL($controller, 'first-post');
		$this->assertIDsEquals(
			$blog->AllChildren()->column('ID'),
			$controller->PaginatedList()->column('ID')
		);


		// RSS
		$this->requestURL($controller, 'first-post/rss');
		$this->assertIDsEquals(
			$blog->AllChildren()->column('ID'),
			$controller->PaginatedList()->column('ID')
		);

		// Posts
		$firstPostID = $this->idFromFixture('BlogPost', 'FirstBlogPost');
		$secondPostID = $this->idFromFixture('BlogPost', 'SecondBlogPost');
		$firstFuturePostID = $this->idFromFixture('BlogPost', 'FirstFutureBlogPost');
		$secondFuturePostID = $this->idFromFixture('BlogPost', 'SecondFutureBlogPost');

		// Request first tag
		$this->requestURL($controller, 'first-post/tag/first-tag');
		$this->assertIDsEquals(
			array($firstPostID, $firstFuturePostID, $secondFuturePostID),
			$controller->PaginatedList()
		);

		// Request 2013 posts
		$this->requestURL($controller, 'first-post/archive/2013');
		$this->assertIDsEquals(
			array($firstPostID, $secondPostID, $secondFuturePostID),
			$controller->PaginatedList()
		);
	}

	/**
	 * Mock a request against a given controller
	 *
	 * @param ContentController $controller
	 * @param string $url
	 */
	protected function requestURL(ContentController $controller, $url) {
		$request = new SS_HTTPRequest('get', $url);
		$request->match('$URLSegment//$Action/$ID/$OtherID');
		$request->shift();
		$controller->init();
		$controller->handleRequest($request, new DataModel());
	}

	/**
	 * Assert these id lists match
	 *
	 * @param array|SS_List $left
	 * @param array|SS_List $right
	 */
	protected function assertIDsEquals($left, $right) {
		if($left instanceof SS_List) $left = $left->column('ID');
		if($right instanceof SS_List) $right = $right->column('ID');
		asort($left);
		asort($right);
		$this->assertEquals(array_values($left), array_values($right));

	}
}


1			<?php
2
3			/**
4			* @mixin PHPUnit_Framework_TestCase
5			*/
6			class BlogTest extends SapphireTest {
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			/**
8			* @var string
9			*/
10			static $fixture_file = 'blog.yml';
			0 ignored issues – show Coding Style introduced 2015-11-20 23:49 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$fixture_file`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
11
12			/**
13			* {@inheritdoc}
14			*/
15			public function setUp() {
16			parent::setUp();
17
18			Config::nest();
19			SS_Datetime::set_mock_now('2013-10-10 20:00:00');
20
21			/**
22			* @var Blog $blog
23			*/
24			$blog = $this->objFromFixture('Blog', 'FirstBlog');
25
26			$blog->publish('Stage', 'Live');
27			}
28
29			/**
30			* {@inheritdoc}
31			*/
32			public function tearDown() {
33			SS_Datetime::clear_mock_now();
34			Config::unnest();
35
36			parent::tearDown();
37			}
38

silverstripe / silverstripe-blog

Push — 2.2 ( 8a877d )

BlogTest::testRoles() B

Complexity

Size

Duplication

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like