FakeManager::__construct() - Code Metrics - Inspection of "Run shell script to set up SilverStripe Behat test..." - silverstripe/silverstripe-behat-extension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 1.0 (#109)

unknown

created 2016-02-16 23:16 UTC

FakeManager::__construct() A

↳ Parent: FakeManager

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	9
Ratio	100 %

Metric	Value
dl	9
loc	9
rs	9.6666
cc	2
eloc	5
nc	2
nop	1

<?php
/**
 * The "Fake-Manager" instantiates fake objects, mainly to replace webservices with
 * faked implementations. It also provides shortcuts for creating complex fake datasets
 * through {@link FakeDatabase}.
 *
 * This class needs to be instantiated early in the application bootstrap process.
 * By default that's implemented through the {@link TestSessionExtension}
 * and config.yml.
 *
 * The instantiation is conditional on there being a Behat test actually running
 * (by virtue of there being a TestSession instantiated) by a 'useFakeManager' flag
 * set through the "TestSession" module (@see {@link App\Test\Behaviour\FeatureContext->getTestSessionState()}).
 *
 * Since both the FeatureContext and actual application bootstrap share the same
 * {@link FakeDatabase} persisted on disk, they can share state.
 *
 * In terms of mock-data, at time of writing we're using the same sources as unit-test
 * mocks do.
 *
 * @author SilverStripe Iterators <[email protected]>
 * @author SilverStripe Science Ninjas <[email protected]>
 */
class FakeManager {

    /**
     *
     * @var type
     */
    protected $db;

    /**
     *
     * @var type
     */
    protected $addressRightGateway;

    /**
     *
     * @param FakeDatabase $db
     */
    function __construct($db = null) {

        $testState = Injector::inst()->get('TestSessionEnvironment')->getState();

        if(!$db) {
            $db = new FakeDatabase($testState->fakeDatabasePath);
        }

        $this->db = $db;

    }

    public function setDb($db) {
        $this->db = $db;
    }
    public function getDb() {
        return $this->db;
    }
}

1		<?php
2		/**
3		* The "Fake-Manager" instantiates fake objects, mainly to replace webservices with
4		* faked implementations. It also provides shortcuts for creating complex fake datasets
5		* through {@link FakeDatabase}.
6		*
7		* This class needs to be instantiated early in the application bootstrap process.
8		* By default that's implemented through the {@link TestSessionExtension}
9		* and config.yml.
10		*
11		* The instantiation is conditional on there being a Behat test actually running
12		* (by virtue of there being a TestSession instantiated) by a 'useFakeManager' flag
13		* set through the "TestSession" module (@see {@link App\Test\Behaviour\FeatureContext->getTestSessionState()}).
14		*
15		* Since both the FeatureContext and actual application bootstrap share the same
16		* {@link FakeDatabase} persisted on disk, they can share state.
17		*
18		* In terms of mock-data, at time of writing we're using the same sources as unit-test
19		* mocks do.
20		*
21		* @author SilverStripe Iterators <[email protected]>
22		* @author SilverStripe Science Ninjas <[email protected]>
23		*/
24		class FakeManager {
25
26		/**
27		*
28		* @var type
29		*/
30		protected $db;
31
32		/**
33		*
34		* @var type
35		*/
36		protected $addressRightGateway;
37
38		/**
39		*
40		* @param FakeDatabase $db
41		*/
42	View Code Duplication	function __construct($db = null) {
		0 ignored issues – show Best Practice introduced 2016-02-10 21:46 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Duplication introduced 2016-02-10 21:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		$testState = Injector::inst()->get('TestSessionEnvironment')->getState();
44
45		if(!$db) {
46		$db = new FakeDatabase($testState->fakeDatabasePath);
47		}
48
49		$this->db = $db;
		0 ignored issues – show Documentation Bug introduced 2016-02-10 21:46 UTC by Report Bug Copy Issue Report It seems like `$db` of type `object<FakeDatabase>` is incompatible with the declared type `object<type>` of property `$db`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
50		}
51
52		public function setDb($db) {
53		$this->db = $db;
54		}
55		public function getDb() {
56		return $this->db;
57		}
58		}

silverstripe / silverstripe-behat-extension

Pull Request — 1.0 (#109)

FakeManager::__construct() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like