SilverStripe\Auditor\MonologSysLogWriter

Complexity

Total Complexity

5

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	factory()	0	3	1
A	_write()	0	21	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 14 and the first side effect is on line 5.

namespace SilverStripe\Auditor;

require_once BASE_PATH . '/framework/thirdparty/Zend/Log/Writer/Abstract.php';
require_once BASE_PATH . '/vendor/autoload.php';

/**
 * Alternative monolog writer for SS_Log, for use when auditor module is in operation.
 *
 * Supplied, because there cannot be more than one SS_SysLogWriter has problems writing
 * to more than one facility at the same time. See this module's readme for more information.
 */
class MonologSysLogWriter extends \Zend_Log_Writer_Abstract {

	/**
	 * @var array Convert Zend_Log level to Monolog level.
	 */
    protected $priorities = array(
        \Zend_Log::EMERG  => \Monolog\Logger::EMERGENCY,
        \Zend_Log::ALERT  => \Monolog\Logger::ALERT,
        \Zend_Log::CRIT   => \Monolog\Logger::CRITICAL,
        \Zend_Log::ERR    => \Monolog\Logger::ERROR,
        \Zend_Log::WARN   => \Monolog\Logger::WARNING,
        \Zend_Log::NOTICE => \Monolog\Logger::NOTICE,
        \Zend_Log::INFO   => \Monolog\Logger::INFO,
        \Zend_Log::DEBUG  => \Monolog\Logger::DEBUG,
    );

	/**
	 * @var Monolog\Logger
	 */
	protected $monolog;

	/**
	 * @param string $ident String identifying the application within the syslog stream.
	 * @param $facility Syslog facility.
	 */
	public function __construct($ident = 'SilverStripe_log', $facility = LOG_USER) {
		$this->monolog = new \Monolog\Logger('application');

It seems like new \Monolog\Logger('application') of type object<Monolog\Logger> is incompatible with the declared type object<SilverStripe\Auditor\Monolog\Logger> of property $monolog.

		$syslog = new \Monolog\Handler\SyslogHandler($ident, $facility, \Monolog\Logger::DEBUG);
		$formatter = new \Monolog\Formatter\LineFormatter("%level_name%: %message% %context%");
		$syslog->setFormatter($formatter);
		$this->monolog->pushHandler($syslog);
	}

    static public function factory($config) {

As per PSR2, the static declaration should come after the visibility declaration.

		return new MonologSysLogWriter();
	}

	protected function _write($event) {
		if (!empty($this->priorities[$event['priority']])) {
			$level = $this->priorities[$event['priority']];
		} else {
			$level = \Monolog\Logger::INFO;
		}

		$message = sprintf(
			'%s (line %s in %s)',
			$event['message']['errstr'],
			$event['message']['errline'],
			$event['message']['errfile']
		);

		$context = [];
		if (!empty($event['info'])) {
			$context = $event['info'];
		}

		$this->monolog->log($level, $message, $context);
	}

}