EmbedResource::getPreviewURL() - Code Metrics - Inspection of "[WPI] Authenticator refactor" - silverstripe/silverstripe-asset-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#495)

by Simon

created 2017-06-04 01:40 UTC

EmbedResource::getPreviewURL() A

↳ Parent: EmbedResource

Complexity

Conditions	4
Paths	3

Size

Total Lines	16
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	16
rs	9.2
c	1
b	0
f	0
cc	4
eloc	7
nc	3
nop	0

<?php

namespace SilverStripe\AssetAdmin\Model;

use Embed\Adapters\Adapter;
use Embed\Embed;
use SilverStripe\Core\Manifest\ModuleLoader;

/**
 * Encapsulation of an embed tag, linking to an external media source.
 *
 * @see Embed
 */
class EmbedResource
{
    /**
     * Embed result
     *
     * @var Adapter
     */
    protected $embed;

    public function __construct($url)
    {
        $this->embed = Embed::create($url);
    }


    /**
     * Get width of this Embed
     *
     * @return int
     */
    public function getWidth()
    {
        return $this->embed->getWidth() ?: 100;
    }

    /**
     * Get height of this Embed
     *
     * @return int
     */
    public function getHeight()
    {
        return $this->embed->getHeight() ?: 100;
    }

    public function getPreviewURL()
    {
        // Use thumbnail url
        if ($this->embed->image) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->embed->image;
        }

        // Use direct image type
        if ($this->getType() === 'photo' && !empty($this->embed->url)) {
            return $this->embed->url;
        }

        // Default media
        return ModuleLoader::getModule('silverstripe/admin')
            ->getResourcePath('client/dist/images/src/default_media.png');
    }

    /**
     * Get human readable name for this resource
     *
     * @return string
     */
    public function getName()
    {
        if ($this->embed->title) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->embed->title;
        }

        return preg_replace('/\?.*/', '', basename($this->embed->getUrl()));
    }

    /**
     * Get Embed type
     *
     * @return string
     */
    public function getType()
    {
        return $this->embed->type;
    }
}


1			<?php
2
3			namespace SilverStripe\AssetAdmin\Model;
4
5			use Embed\Adapters\Adapter;
6			use Embed\Embed;
7			use SilverStripe\Core\Manifest\ModuleLoader;
8
9			/**
10			* Encapsulation of an embed tag, linking to an external media source.
11			*
12			* @see Embed
13			*/
14			class EmbedResource
15			{
16			/**
17			* Embed result
18			*
19			* @var Adapter
20			*/
21			protected $embed;
22
23			public function __construct($url)
24			{
25			$this->embed = Embed::create($url);
26			}
27
28
29			/**
30			* Get width of this Embed
31			*
32			* @return int
33			*/
34			public function getWidth()
35			{
36			return $this->embed->getWidth() ?: 100;
37			}
38
39			/**
40			* Get height of this Embed
41			*
42			* @return int
43			*/
44			public function getHeight()
45			{
46			return $this->embed->getHeight() ?: 100;
47			}
48
49			public function getPreviewURL()
50			{
51			// Use thumbnail url
52			if ($this->embed->image) {
			0 ignored issues – show Bug Best Practice introduced 2017-05-26 06:51 UTC by Report Bug Copy Issue Report The expression `$this->embed->image` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
53			return $this->embed->image;
54			}
55
56			// Use direct image type
57			if ($this->getType() === 'photo' && !empty($this->embed->url)) {
58			return $this->embed->url;
59			}
60
61			// Default media
62			return ModuleLoader::getModule('silverstripe/admin')
63			->getResourcePath('client/dist/images/src/default_media.png');
64			}
65
66			/**
67			* Get human readable name for this resource
68			*
69			* @return string
70			*/
71			public function getName()
72			{
73			if ($this->embed->title) {
			0 ignored issues – show Bug Best Practice introduced 2017-05-26 06:51 UTC by Report Bug Copy Issue Report The expression `$this->embed->title` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
74			return $this->embed->title;
75			}
76
77			return preg_replace('/\?.*/', '', basename($this->embed->getUrl()));
78			}
79
80			/**
81			* Get Embed type
82			*
83			* @return string
84			*/
85			public function getType()
86			{
87			return $this->embed->type;
88			}
89			}
90

silverstripe / silverstripe-asset-admin

Pull Request — master (#495)

EmbedResource::getPreviewURL() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like