FileFormBuilderTest::testEditFileForm() - Code Metrics - Inspection of "Remove `cms` and `campaign-admin` dependencies." - silverstripe/silverstripe-asset-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#458)

by Roman

created 2017-05-02 15:48 UTC

FileFormBuilderTest::testEditFileForm() A

↳ Parent: FileFormBuilderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	64
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	64
rs	9.3956
cc	1
eloc	38
nc	1
nop	0

How to fix Long Method

<?php

namespace SilverStripe\AssetAdmin\Tests\Forms;

use SilverStripe\AssetAdmin\Controller\AssetAdmin;
use SilverStripe\AssetAdmin\Extensions\CampaignAdminExtension;
use SilverStripe\AssetAdmin\Forms\FileFormFactory;
use SilverStripe\AssetAdmin\Forms\FolderFormFactory;
use SilverStripe\AssetAdmin\Forms\ImageFormFactory;
use SilverStripe\Assets\File;
use SilverStripe\Assets\Folder;
use SilverStripe\Assets\Image;
use SilverStripe\Assets\Tests\Storage\AssetStoreTest\TestAssetStore;
use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\LiteralField;

class FileFormBuilderTest extends SapphireTest
{
    protected static $fixture_file = 'FileFormBuilderTest.yml';

    public function setUp()

    {
        parent::setUp();

        // Set backend and base url
        TestAssetStore::activate('FileFormBuilderTest');

        /** @var File $testfile */
        $testfile = $this->objFromFixture(File::class, 'file1');
        $testfile->setFromLocalFile(__DIR__ .'/fixtures/testfile.txt', 'files/testfile.txt');
        $testfile->write();

        /** @var Image $testimage */
        $testimage = $this->objFromFixture(Image::class, 'image1');
        $testimage->setFromLocalFile(__DIR__.'/fixtures/testimage.png', 'files/testimage.png');
    }

    public function tearDown()
    {
        TestAssetStore::reset();
        parent::tearDown();
    }

    public function testEditFileForm()
    {
        // Ensure campaign-admin extension is not applied!
        Config::modify()->remove(FileFormFactory::class, 'extensions');

        $this->logInWithPermission('ADMIN');

        $file = $this->objFromFixture(File::class, 'file1');
        $controller = new AssetAdmin();
        $builder = new FileFormFactory();
        $form = $builder->getForm($controller, 'EditForm', ['Record' => $file]);

        // Verify file form is scaffolded correctly
        $this->assertEquals('EditForm', $form->getName());


        // Test fields exist
        /** @var LiteralField $fileSpecsField */
        $fileSpecsField = $form->Fields()->fieldByName('FileSpecs');
        $fileSpecs = $fileSpecsField->getContent();
        $this->assertEquals(

            '<div class="editor__specs">11 bytes <span class="editor__status-flag">Draft</span></div>',
            $fileSpecs
        );
        $filePath = $form->Fields()->fieldByName('Editor.Details.Path')->Value();
        $this->assertEquals('files/', $filePath);


        /** @var LiteralField $iconFullField */
        $iconFullField = $form->Fields()->fieldByName('PreviewImage');
        $state = $iconFullField->getSchemaStateDefaults();
        $this->assertEquals($file->Parent()->ID, $state['data']['parentid']);

        $this->assertContains('testfile.txt', $state['data']['url']);
        $this->assertTrue($state['data']['exists']);

        $this->assertContains('document_92.png', $state['data']['preview']);
        $this->assertEquals('document', $state['data']['category']);


        // Usage tab
        $uploaded = $form->Fields()->fieldByName('Editor.Usage.Created');
        $this->assertEquals(

            $file->Created,
            $uploaded->dataValue()
        );

        // Test actions exist
        $this->assertNotNull($form->Actions()->fieldByName('Actions.action_save'));

        $this->assertNotNull($form->Actions()->fieldByName('Actions.action_publish'));

        $this->assertNotNull($form->Actions()->fieldByName('PopoverActions.action_delete'));

        $this->assertNull($form->Actions()->fieldByName('PopoverActions.action_unpublish'));


        // Add to campaign should not be there by default
        $this->assertNull($form->Actions()->fieldByName('PopoverActions.action_addtocampaign'));


        // Add extension for campaign-admin
        Config::modify()->merge(
            FileFormFactory::class,
            'extensions',
            [ CampaignAdminExtension::class ]
        );

        $builder = new FileFormFactory();
        $form = $builder->getForm($controller, 'EditForm', ['Record' => $file]);

        // Add to campaign should now be available
        $this->assertNotNull($form->Actions()->fieldByName('PopoverActions.action_addtocampaign'));

    }

    public function testCreateFileForm()
    {
        $this->logInWithPermission('ADMIN');

        $file = $this->objFromFixture(File::class, 'file1');
        $controller = new AssetAdmin();
        $builder = new FileFormFactory();
        $form = $builder->getForm($controller, 'EditForm', ['Record' => $file]);

        // Test fields
        /** @var LiteralField $fileSpecsField */
        $fileSpecsField = $form->Fields()->fieldByName('FileSpecs');
        $this->assertEquals(

            '<div class="editor__specs">11 bytes <span class="editor__status-flag">Draft</span></div>',
            $fileSpecsField->getContent()
        );
        $this->assertEquals(

            'files/',
            $form->Fields()->fieldByName('Editor.Details.Path')->dataValue()
        );

        // Test actions
        $this->assertNotNull($form->Actions()->fieldByName('Actions.action_save'));

    }

    public function testEditImageForm()
    {
        $this->logInWithPermission('ADMIN');

        $image = $this->objFromFixture(Image::class, 'image1');
        // write so that PreviewImageField could load this later on
        $image->write();
        $controller = new AssetAdmin();
        $builder = new ImageFormFactory();
        $form = $builder->getForm($controller, 'EditForm', ['Record' => $image]);

        // Check thumbnail
        // Note: force_resample is turned off for testing
        /** @var LiteralField $iconFullField */
        $iconFullField = $form->Fields()->fieldByName('PreviewImage');
        $state = $iconFullField->getSchemaStateDefaults();
        $this->assertEquals($image->Parent()->ID, $state['data']['parentid']);

        $this->assertContains('testimage.png', $state['data']['url']);
        $this->assertTrue($state['data']['exists']);

        $this->assertContains('testimage.png', $state['data']['preview']);
        $this->assertEquals('image', $state['data']['category']);

    }

    public function testInsertImageForm()
    {
        $this->logInWithPermission('ADMIN');

        $image = $this->objFromFixture(Image::class, 'image1');
        $controller = new AssetAdmin();
        $builder = new ImageFormFactory();
        $form = $builder->getForm($controller, 'EditForm', ['Record' => $image, 'Type' => 'insert']);

        // Check thumbnail
        // Note: force_resample is turned off for testing
        $altTextField = $form->Fields()->dataFieldByName('AltText');
        $this->assertNotNull($altTextField);

    }

    public function testFolderForm()
    {
        $this->logInWithPermission('ADMIN');

        $folder = $this->objFromFixture(Folder::class, 'parent');
        $controller = new AssetAdmin();
        $builder = new FolderFormFactory($controller, $folder);

        $form = $builder->getForm($controller, 'EditForm', ['Record' => $folder]);

        // Check fields
        $this->assertNull($form->Fields()->fieldByName('FileSpecs'));

        $this->assertNull($form->Fields()->fieldByName('Editor.Details.ClickableURL'));

        $this->assertNull($form->Fields()->fieldByName('Editor.Usage'));


        /** @var LiteralField $iconFullField */
        $iconFullField = $form->Fields()->fieldByName('PreviewImage');
        $state = $iconFullField->getSchemaStateDefaults();
        $this->assertEquals($folder->Parent()->ID, $state['data']['parentid']);

        $this->assertTrue($state['data']['exists']);

        $this->assertContains('folder_icon_large.png', $state['data']['preview']);
        $this->assertEquals('folder', $state['data']['category']);


        // Check actions
        $this->assertNotNull($form->Actions()->fieldByName('action_save'));

        $this->assertNotNull($form->Actions()->dataFieldByName('action_delete'));

        $this->assertNull($form->Actions()->fieldByName('action_publish'));

        $this->assertNull($form->Actions()->dataFieldByName('action_publish'));

        $this->assertNull($form->Actions()->dataFieldByName('action_unpublish'));

    }

    public function testScaffolderFactory()
    {
        $controller = new AssetAdmin();
        $this->assertInstanceOf(FileFormFactory::class, $controller->getFormFactory(File::singleton()));

        $this->assertInstanceOf(ImageFormFactory::class, $controller->getFormFactory(Image::singleton()));

        $this->assertInstanceOf(FolderFormFactory::class, $controller->getFormFactory(Folder::singleton()));

    }
}


1		<?php
2
3		namespace SilverStripe\AssetAdmin\Tests\Forms;
4
5		use SilverStripe\AssetAdmin\Controller\AssetAdmin;
6		use SilverStripe\AssetAdmin\Extensions\CampaignAdminExtension;
7		use SilverStripe\AssetAdmin\Forms\FileFormFactory;
8		use SilverStripe\AssetAdmin\Forms\FolderFormFactory;
9		use SilverStripe\AssetAdmin\Forms\ImageFormFactory;
10		use SilverStripe\Assets\File;
11		use SilverStripe\Assets\Folder;
12		use SilverStripe\Assets\Image;
13		use SilverStripe\Assets\Tests\Storage\AssetStoreTest\TestAssetStore;
14		use SilverStripe\Core\Config\Config;
15		use SilverStripe\Dev\SapphireTest;
16		use SilverStripe\Forms\LiteralField;
17
18		class FileFormBuilderTest extends SapphireTest
19		{
20		protected static $fixture_file = 'FileFormBuilderTest.yml';
21
22	View Code Duplication	public function setUp()
		0 ignored issues – show Duplication introduced 2016-12-13 23:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		parent::setUp();
25
26		// Set backend and base url
27		TestAssetStore::activate('FileFormBuilderTest');
28
29		/** @var File $testfile */
30		$testfile = $this->objFromFixture(File::class, 'file1');
31		$testfile->setFromLocalFile(__DIR__ .'/fixtures/testfile.txt', 'files/testfile.txt');
32		$testfile->write();
33
34		/** @var Image $testimage */
35		$testimage = $this->objFromFixture(Image::class, 'image1');
36		$testimage->setFromLocalFile(__DIR__.'/fixtures/testimage.png', 'files/testimage.png');
37		}
38
39		public function tearDown()

silverstripe / silverstripe-asset-admin

Pull Request — master (#458)

FileFormBuilderTest::testEditFileForm() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like