FixtureContext::iShouldSeeTheForm() - Code Metrics - Inspection of "Insert media modal in react" - silverstripe/silverstripe-asset-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#307)

by Damian

created 2016-11-22 01:07 UTC

FixtureContext::iShouldSeeTheForm() A

↳ Parent: FixtureContext

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	7
Ratio	100 %

Importance

Changes

Metric	Value
dl	7
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	1

<?php

namespace SilverStripe\AssetAdmin\Tests\Behat\Context;

use Behat\Behat\Exception\PendingException;
use SilverStripe\BehatExtension\Context\FixtureContext as BaseFixtureContext;

/**
 * Context used to create fixtures in the SilverStripe ORM.
 */
class FixtureContext extends BaseFixtureContext
{

    /**
     * Select a gallery item by type and name
     *
     * @Given /^I (?:(?:click on)|(?:select)) the "([^"]+)" named "([^"]+)" in the gallery$/
     * @param string $type
     * @param string $name
     */
    public function stepISelectGalleryItem($type, $name) {

        $page = $this->getSession()->getPage();
        $gallery = $page->find(
            'xpath',
            "//div[contains(@class, 'gallery-item--{$type}')]//div[contains(text(), '{$name}')]"
        );
        assertNotNull($gallery, ucfirst($type) . " named $name could not be found");
        $gallery->click();
    }

    /**
     * @Then /^I should see the "([^"]*)" form$/
     * @param string $id HTML ID of form
     */
    public function iShouldSeeTheForm($id)

    {
        $page = $this->getSession()->getPage();
        $form = $page->find('css', "form#{$id}");
        assertNotNull($form, "form with id $id could not be found");
        assertTrue($form->isVisible(), "form with id $id is not visible");
    }
}


1		<?php
2
3		namespace SilverStripe\AssetAdmin\Tests\Behat\Context;
4
5		use Behat\Behat\Exception\PendingException;
6		use SilverStripe\BehatExtension\Context\FixtureContext as BaseFixtureContext;
7
8		/**
9		* Context used to create fixtures in the SilverStripe ORM.
10		*/
11		class FixtureContext extends BaseFixtureContext
12		{
13
14		/**
15		* Select a gallery item by type and name
16		*
17		* @Given /^I (?:(?:click on)\|(?:select)) the "([^"]+)" named "([^"]+)" in the gallery$/
18		* @param string $type
19		* @param string $name
20		*/
21	View Code Duplication	public function stepISelectGalleryItem($type, $name) {
		0 ignored issues – show Duplication introduced 2016-11-22 00:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		$page = $this->getSession()->getPage();
23		$gallery = $page->find(
24		'xpath',
25		"//div[contains(@class, 'gallery-item--{$type}')]//div[contains(text(), '{$name}')]"
26		);
27		assertNotNull($gallery, ucfirst($type) . " named $name could not be found");
28		$gallery->click();
29		}
30
31		/**
32		* @Then /^I should see the "([^"]*)" form$/
33		* @param string $id HTML ID of form
34		*/
35	View Code Duplication	public function iShouldSeeTheForm($id)
		0 ignored issues – show Duplication introduced 2016-11-22 00:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$page = $this->getSession()->getPage();
38		$form = $page->find('css', "form#{$id}");
39		assertNotNull($form, "form with id $id could not be found");
40		assertTrue($form->isVisible(), "form with id $id is not visible");
41		}
42		}
43

silverstripe / silverstripe-asset-admin

Pull Request — master (#307)

FixtureContext::iShouldSeeTheForm() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like