SilverStripe\AssetAdmin\Controller\AssetAdmin::apiUploadFile()

Complexity

Conditions	10
Paths	17

Size

Total Lines	60
Code Lines	38

Duplication

Lines	18
Ratio	30 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function apiUploadFile(HTTPRequest $request)
    {
        $data = $request->postVars();
        $upload = $this->getUpload();

        // CSRF check
        $token = SecurityToken::inst();
        if (empty($data[$token->getName()]) || !$token->check($data[$token->getName()])) {

This code seems to be duplicated across your project.

            return new HTTPResponse(null, 400);
        }

        // Check parent record
        /** @var Folder $parentRecord */
        $parentRecord = null;
        if (!empty($data['ParentID']) && is_numeric($data['ParentID'])) {

This code seems to be duplicated across your project.

            $parentRecord = Folder::get()->byID($data['ParentID']);
        }

        $tmpFile = $data['Upload'];
        if (!$upload->validate($tmpFile)) {

This code seems to be duplicated across your project.

            $result = ['message' => null];
            $errors = $upload->getErrors();
            if ($message = array_shift($errors)) {
                $result['message'] = [
                    'type' => 'error',
                    'value' => $message,
                ];
            }
            return (new HTTPResponse(json_encode($result), 400))
                ->addHeader('Content-Type', 'application/json');
        }

        $folder = $parentRecord ? $parentRecord->getFilename() : '/';

        try {
            $tuple = $upload->load($tmpFile, $folder);
        } catch (Exception $e) {
            $result = [
                'message' => [
                    'type' => 'error',
                    'value' => $e->getMessage(),
                ]
            ];
            return (new HTTPResponse(json_encode($result), 400))
                ->addHeader('Content-Type', 'application/json');
        }

        if ($upload->isError()) {
            $result['message'] = [

$result was never initialized. Although not strictly required by PHP, it is generally a good practice to add $result = array(); before regardless.

                'type' => 'error',
                'value' => implode(' ' . PHP_EOL, $upload->getErrors()),
            ];
            return (new HTTPResponse(json_encode($result), 400))
                ->addHeader('Content-Type', 'application/json');
        }

        $tuple['Name'] = basename($tuple['Filename']);
        return (new HTTPResponse(json_encode($tuple)))
            ->addHeader('Content-Type', 'application/json');
    }