UnpublishFileMutationCreator::attributes() - Code Metrics - Inspection of "WIP: Add unpublish" - silverstripe/silverstripe-asset-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#441)

by Michael

created 2017-04-29 10:44 UTC

UnpublishFileMutationCreator::attributes() A

↳ Parent: UnpublishFileMutationCreator

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	0

<?php

namespace SilverStripe\AssetAdmin\GraphQL;

use SilverStripe\Assets\File;
use SilverStripe\Versioned\Versioned;
use SilverStripe\GraphQL\MutationCreator;
use SilverStripe\GraphQL\OperationResolver;
use GraphQL\Type\Definition\ResolveInfo;
use GraphQL\Type\Definition\Type;

class UnpublishFileMutationCreator extends MutationCreator implements OperationResolver
{
    public function attributes() {
        return [
            'name '=> 'unpublishFile',
            'description' => 'Unpublishes a file',
        ];
    }

    public function type()
    {
        return function () {
            return $this->manager->getType('FileInterface');
        };
    }

    public function args()
    {
        return [
            'id' => [
                'type' => Type::nonNull(Type::id()),
            ],
        ];
    }

    public function resolve($object, array $args, $context, ResolveInfo $info)
    {
        if(!isset($args['id']) || !ctype_digit($args['id'])) {
            throw new \InvalidArgumentException('Invalid id');
        }

        $file = Versioned::get_by_stage(File::class, Versioned::LIVE)
            ->byId($args['id']);

        if(!$file) {
            throw new \InvalidArgumentException(sprintf(
                '%s#%s not published or doesn\'t exist',
                File::class,
                $args['id']
            ));
        }

        if(!$file->canUnpublish($context['currentUser'])) {

            throw new \InvalidArgumentException(sprintf(
                '%s#%s unpublish not allowed',
                File::class,
                $args['id']
            ));
        }

        $file->doUnpublish();

        return $file;
    }
}


1		<?php
2
3		namespace SilverStripe\AssetAdmin\GraphQL;
4
5		use SilverStripe\Assets\File;
6		use SilverStripe\Versioned\Versioned;
7		use SilverStripe\GraphQL\MutationCreator;
8		use SilverStripe\GraphQL\OperationResolver;
9		use GraphQL\Type\Definition\ResolveInfo;
10		use GraphQL\Type\Definition\Type;
11
12		class UnpublishFileMutationCreator extends MutationCreator implements OperationResolver
13		{
14		public function attributes() {
15		return [
16		'name '=> 'unpublishFile',
17		'description' => 'Unpublishes a file',
18		];
19		}
20
21		public function type()
22		{
23		return function () {
24		return $this->manager->getType('FileInterface');
25		};
26		}
27
28		public function args()
29		{
30		return [
31		'id' => [
32		'type' => Type::nonNull(Type::id()),
33		],
34		];
35		}
36
37		public function resolve($object, array $args, $context, ResolveInfo $info)
38		{
39		if(!isset($args['id']) \|\| !ctype_digit($args['id'])) {
40		throw new \InvalidArgumentException('Invalid id');
41		}
42
43		$file = Versioned::get_by_stage(File::class, Versioned::LIVE)
44		->byId($args['id']);
45
46		if(!$file) {
47		throw new \InvalidArgumentException(sprintf(
48		'%s#%s not published or doesn\'t exist',
49		File::class,
50		$args['id']
51		));
52		}
53
54	View Code Duplication	if(!$file->canUnpublish($context['currentUser'])) {
		0 ignored issues – show Duplication introduced 2017-04-22 03:31 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		throw new \InvalidArgumentException(sprintf(
56		'%s#%s unpublish not allowed',
57		File::class,
58		$args['id']
59		));
60		}
61
62		$file->doUnpublish();
63
64		return $file;
65		}
66		}
67

silverstripe / silverstripe-asset-admin

Pull Request — master (#441)

UnpublishFileMutationCreator::attributes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like