SilverStripe\AssetAdmin\Controller\AssetAdminFile

Complexity

Total Complexity

11

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	updateCMSEditLink()	0	6	1
C	humanizedChanges()	0	47	10

<?php

namespace SilverStripe\AssetAdmin\Controller;

use SilverStripe\Control\Director;
use SilverStripe\ORM\DataExtension;
use SilverStripe\ORM\Versioning\Versioned;
use SilverStripe\ORM\Versioning\DataDifferencer;

/**
 * Update File dataobjects to be editable in this asset admin
 */
class AssetAdminFile extends DataExtension
{
    public function updateCMSEditLink(&$link)
    {
        // Update edit link for this file to point to the new asset admin
        $controller = AssetAdmin::singleton();
        $link = Director::absoluteURL($controller->getFileEditLink($this->owner));

$this->owner of type object<SilverStripe\ORM\DataObject> is not a sub-type of object<SilverStripe\Assets\File>. It seems like you assume a child class of the class SilverStripe\ORM\DataObject to be always present.

    }

    /**
     * @param int $from
     * @param int $to
     *
     * @return string
     */
    public function humanizedChanges($from, $to) {
        if(!$from) {
            return _t('SilverStripe\\AssetAdmin\\Controller\\AssetAdmin.UPLOADEDFILE', "Uploaded file");
        }

        $fromRecord = Versioned::get_version($this->owner->class, $this->owner->ID, $from);
        $toRecord = Versioned::get_version($this->owner->class, $this->owner->ID, $to);

        $diff = new DataDifferencer($fromRecord, $toRecord);
        $changes = $diff->changedFieldNames();

        $k = array_search('LastEdited', $changes);

        if($k !== false) {
            unset($changes[$k]);
        }

        $output = array();

        foreach($changes as $change) {
            $human = $change;

$human is not used, you could remove the assignment.

            if($change == "ParentID") {
                // updated folder ID
                $human = _t('SilverStripe\\AssetAdmin\\Controller\\AssetAdminFile.MOVEDFOLDER', "Moved file");
            } else if($change == 'Title') {
                $human = _t('SilverStripe\\AssetAdmin\\Controller\\AssetAdminFile.RENAMEDTITLE', "Updated title to ") . $fromRecord->Title;
            } else if($change == 'Name') {
                $human = _t('SilverStripe\\AssetAdmin\\Controller\\AssetAdminFile.RENAMEDFILE', "Renamed file to ") . $fromRecord->Filename;
            } else if($change == 'File') {
                // check to make sure the files are actually different
                if($fromRecord->getHash() != $toRecord->getHash()) {
                    $human = _t('SilverStripe\\AssetAdmin\\Controller\\AssetAdminFile.RENAMEDFILE', "Replaced file");
                } else {
                    $human = false;
                }
            } else {
                $human = false;
            }

            if($human) {

The expression $human of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

                $output[] = $human;
            }
        }

        return implode(", ", $output);
    }
}