for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace SilverStripe\AssetAdmin\Forms;
use SilverStripe\Assets\File;
use SilverStripe\Control\Controller;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\LiteralField;
use SilverStripe\Forms\ReadonlyField;
class FileHistoryFormFactory extends FileFormFactory
{
protected function getFormFields(Controller $controller, $name, $context = [])
$record = $context['Record'];
return new FieldList(
LiteralField::create('Thumbnail', $this->getIconMarkup($record)),
LiteralField::create('FileSpecs', $this->getSpecsMarkup($record)),
ReadonlyField::create("Title", File::singleton()->fieldLabel('Title')),
ReadonlyField::create('Name', File::singleton()->fieldLabel('Filename')),
ReadonlyField::create("Path", _t('AssetTableField.PATH', 'Path'), $this->getPath($record))
);
}
protected function getFormActions(Controller $controller, $name, $context = [])
$record
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$actions = new FieldList();
// Update
$this->invokeWithExtensions('updateFormActions', $actions, $controller, $name, $context);
return $actions;
silverstripe /
silverstripe-asset-admin
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.