AssetFormFactory::getPopoverActions() - Code Metrics - Inspection of "Move create folder to right editor panel" - silverstripe/silverstripe-asset-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#415)

unknown

created 2017-04-07 03:06 UTC

AssetFormFactory::getPopoverActions() A

↳ Parent: AssetFormFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php

namespace SilverStripe\AssetAdmin\Forms;

use InvalidArgumentException;
use SilverStripe\Assets\File;
use SilverStripe\Control\Controller;
use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Extensible;
use SilverStripe\Core\Injector\Injectable;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\Form;
use SilverStripe\Forms\FormAction;
use SilverStripe\Forms\FormFactory;
use SilverStripe\Forms\HeaderField;
use SilverStripe\Forms\HiddenField;
use SilverStripe\Forms\PopoverField;
use SilverStripe\Forms\RequiredFields;
use SilverStripe\Forms\Tab;
use SilverStripe\Forms\TabSet;
use SilverStripe\Forms\TextField;

abstract class AssetFormFactory implements FormFactory
{
    use Extensible;
    use Injectable;
    use Configurable;

    /**
     * Insert into HTML content area
     */
    const TYPE_INSERT = 'insert';

    /**
     * Select file by ID only
     */
    const TYPE_SELECT = 'select';

    /**
     * Edit form: Default
     */
    const TYPE_ADMIN = 'admin';

    public function __construct()
    {
        $this->constructExtensions();
    }

    public function getForm(Controller $controller, $name = FormFactory::DEFAULT_NAME, $context = [])
    {
        // Validate context
        foreach ($this->getRequiredContext() as $required) {
            if (!isset($context[$required])) {
                throw new InvalidArgumentException("Missing required context $required");
            }
        }

        $fields = $this->getFormFields($controller, $name, $context);
        $actions = $this->getFormActions($controller, $name, $context);
        $validator = $this->getValidator($controller, $name, $context);
        $form = Form::create($controller, $name, $fields, $actions, $validator);

        // Extend form
        $this->invokeWithExtensions('updateForm', $form, $controller, $name, $context);

        // Populate form from record
        if (isset($context['Record'])) {
            $form->loadDataFrom($context['Record']);
        }

        return $form;
    }
    
    /**
     * Get the validator for the form to be built
     *
     * @param $controller
     * @param $formName
     * @param $context
     * @return RequiredFields
     */
    protected function getValidator(Controller $controller, $formName, $context = []) {

        $validator = new RequiredFields('Name');
        
        return $validator;
    }

    /**
     * Get form type from 'type' context
     *
     * @param array $context
     * @return string
     */
    protected function getFormType($context)
    {
        return empty($context['Type']) ? static::TYPE_ADMIN : $context['Type'];
    }

    /**
     * Gets the main tabs for the file edit form
     *
     * @param File $record
     * @return TabSet
     */
    protected function getFormFieldTabs($record, $context = [])
    {
        $tabs = TabSet::create('Editor', $this->getFormFieldDetailsTab($record));

        return $tabs;
    }

    /**
     * @param File $record
     * @return FormAction
     */
    protected function getSaveAction($record)

    {
        if ($record && $record->isInDB() && $record->canEdit()) {
            return FormAction::create('save', _t('CMSMain.SAVE', 'Save'))
                ->setIcon('save');
        }
        return null;
    }

    /**
     * Get delete action, if this record is deletable
     *
     * @param File $record
     * @return FormAction
     */
    protected function getDeleteAction($record)

    {
        // Delete action
        if ($record && $record->isInDB() && $record->canDelete()) {
            $deleteText = _t('SilverStripe\\AssetAdmin\\Controller\\AssetAdmin.DELETE_BUTTON', 'Delete');
            return FormAction::create('delete', $deleteText)
                ->setIcon('trash-bin');
        }
        return null;
    }
    
    /**
     * @param Controller $controller
     * @param $formName
     * @param array $context
     * @return FieldList
     */
    protected function getFormActions(Controller $controller, $formName, $context = [])
    {
        $record = isset($context['Record']) ? $context['Record'] : null;

        $actions = new FieldList();
        if ($saveAction = $this->getSaveAction($record)) {
            $actions->push($saveAction);
        }
        $menu = $this->getPopoverMenu($record);
        if ($menu && $menu->FieldList()->count()) {
            $actions->push($menu);
        }

        $this->invokeWithExtensions('updateFormActions', $actions, $controller, $formName, $context);
        return $actions;
    }

    /**
     * Get fields for this form
     *
     * @param Controller $controller
     * @param string $formName
     * @param array $context
     * @return FieldList
     */
    protected function getFormFields(Controller $controller, $formName, $context = [])
    {
        $record = isset($context['Record']) ? $context['Record'] : null;

        // Build standard fields for all folders / files
        /** @var File $record */
        $fields = new FieldList(
            HeaderField::create('TitleHeader', $record ? $record->Title : null, 1)
                ->addExtraClass('editor__heading'),
            $this->getFormFieldTabs($record, $context)
        );
        if ($record) {
            $fields->push(HiddenField::create('ID', $record->ID));
            $fields->insertAfter(
                'TitleHeader',
                PreviewImageField::create('PreviewImage')
                    ->setRecordID($record->ID)
                    ->addExtraClass('editor__file-preview')
            );
        }

        $this->invokeWithExtensions('updateFormFields', $fields, $controller, $formName, $context);
        return $fields;
    }
    
    /**
     * Build popup menu
     *
     * @param File $record
     * @return PopoverField
     */
    protected function getPopoverMenu($record)
    {
        // Build popover actions
        $popoverActions = $this->getPopoverActions($record);
        if ($popoverActions) {

            return PopoverField::create($popoverActions)
                ->setPlacement('top')
                ->setButtonTooltip(_t(
                    'SilverStripe\\AssetAdmin\\Forms\\FileFormFactory.OTHER_ACTIONS',
                    'Other actions'
                ));
        }
        return null;
    }
    
    /**
     * Get actions that go into the Popover menu
     *
     * @param $record
     * @return array
     */
    protected function getPopoverActions($record)
    {
        return array_filter([
            $this->getDeleteAction($record)
        ]);
    }
    
    /**
     * Build "details" formfield tab
     *
     * @param File $record
     * @param array $context
     * @return Tab
     */
    protected function getFormFieldDetailsTab($record, $context = [])
    {
        return Tab::create(
            'Details',
            TextField::create('Name', File::singleton()->fieldLabel('Filename'))
        );
    }

    public function getRequiredContext()
    {
        return ['Record'];
    }
}


1		<?php
2
3		namespace SilverStripe\AssetAdmin\Forms;
4
5		use InvalidArgumentException;
6		use SilverStripe\Assets\File;
7		use SilverStripe\Control\Controller;
8		use SilverStripe\Core\Config\Configurable;
9		use SilverStripe\Core\Extensible;
10		use SilverStripe\Core\Injector\Injectable;
11		use SilverStripe\Forms\FieldList;
12		use SilverStripe\Forms\Form;
13		use SilverStripe\Forms\FormAction;
14		use SilverStripe\Forms\FormFactory;
15		use SilverStripe\Forms\HeaderField;
16		use SilverStripe\Forms\HiddenField;
17		use SilverStripe\Forms\PopoverField;
18		use SilverStripe\Forms\RequiredFields;
19		use SilverStripe\Forms\Tab;
20		use SilverStripe\Forms\TabSet;
21		use SilverStripe\Forms\TextField;
22
23		abstract class AssetFormFactory implements FormFactory
24		{
25		use Extensible;
26		use Injectable;
27		use Configurable;
28
29		/**
30		* Insert into HTML content area
31		*/
32		const TYPE_INSERT = 'insert';
33
34		/**
35		* Select file by ID only
36		*/
37		const TYPE_SELECT = 'select';
38
39		/**
40		* Edit form: Default
41		*/
42		const TYPE_ADMIN = 'admin';
43
44		public function __construct()
45		{
46		$this->constructExtensions();
47		}
48
49		public function getForm(Controller $controller, $name = FormFactory::DEFAULT_NAME, $context = [])
50		{
51		// Validate context
52		foreach ($this->getRequiredContext() as $required) {
53		if (!isset($context[$required])) {
54		throw new InvalidArgumentException("Missing required context $required");
55		}
56		}
57
58		$fields = $this->getFormFields($controller, $name, $context);
59		$actions = $this->getFormActions($controller, $name, $context);
60		$validator = $this->getValidator($controller, $name, $context);
61		$form = Form::create($controller, $name, $fields, $actions, $validator);
62
63		// Extend form
64		$this->invokeWithExtensions('updateForm', $form, $controller, $name, $context);
65
66		// Populate form from record
67		if (isset($context['Record'])) {
68		$form->loadDataFrom($context['Record']);
69		}
70
71		return $form;
72		}
73
74		/**
75		* Get the validator for the form to be built
76		*
77		* @param $controller
78		* @param $formName
79		* @param $context
80		* @return RequiredFields
81		*/
82		protected function getValidator(Controller $controller, $formName, $context = []) {
		0 ignored issues – show Unused Code introduced 2017-04-04 04:07 UTC by Report Bug Copy Issue Report The parameter `$controller` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-04-07 03:08 UTC by Report Bug Copy Issue Report The parameter `$formName` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-04-04 04:07 UTC by Report Bug Copy Issue Report The parameter `$context` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
83		$validator = new RequiredFields('Name');
84
85		return $validator;
86		}
87
88		/**
89		* Get form type from 'type' context
90		*
91		* @param array $context
92		* @return string
93		*/
94		protected function getFormType($context)
95		{
96		return empty($context['Type']) ? static::TYPE_ADMIN : $context['Type'];
97		}
98
99		/**
100		* Gets the main tabs for the file edit form
101		*
102		* @param File $record
103		* @return TabSet
104		*/
105		protected function getFormFieldTabs($record, $context = [])
106		{
107		$tabs = TabSet::create('Editor', $this->getFormFieldDetailsTab($record));
108
109		return $tabs;
110		}
111
112		/**
113		* @param File $record
114		* @return FormAction
115		*/
116	View Code Duplication	protected function getSaveAction($record)
		0 ignored issues – show Duplication introduced 2016-10-19 02:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
117		{
118		if ($record && $record->isInDB() && $record->canEdit()) {
119		return FormAction::create('save', _t('CMSMain.SAVE', 'Save'))
120		->setIcon('save');
121		}
122		return null;
123		}
124
125		/**
126		* Get delete action, if this record is deletable
127		*
128		* @param File $record
129		* @return FormAction
130		*/
131	View Code Duplication	protected function getDeleteAction($record)
		0 ignored issues – show Duplication introduced 2016-10-17 01:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
132		{
133		// Delete action
134		if ($record && $record->isInDB() && $record->canDelete()) {
135		$deleteText = _t('SilverStripe\\AssetAdmin\\Controller\\AssetAdmin.DELETE_BUTTON', 'Delete');
136		return FormAction::create('delete', $deleteText)
137		->setIcon('trash-bin');
138		}
139		return null;
140		}
141
142		/**
143		* @param Controller $controller
144		* @param $formName
145		* @param array $context
146		* @return FieldList
147		*/
148		protected function getFormActions(Controller $controller, $formName, $context = [])
149		{
150		$record = isset($context['Record']) ? $context['Record'] : null;
151
152		$actions = new FieldList();
153		if ($saveAction = $this->getSaveAction($record)) {
154		$actions->push($saveAction);
155		}
156		$menu = $this->getPopoverMenu($record);
157		if ($menu && $menu->FieldList()->count()) {
158		$actions->push($menu);
159		}
160
161		$this->invokeWithExtensions('updateFormActions', $actions, $controller, $formName, $context);
162		return $actions;
163		}
164
165		/**
166		* Get fields for this form
167		*
168		* @param Controller $controller
169		* @param string $formName
170		* @param array $context
171		* @return FieldList
172		*/
173		protected function getFormFields(Controller $controller, $formName, $context = [])
174		{
175		$record = isset($context['Record']) ? $context['Record'] : null;
176
177		// Build standard fields for all folders / files
178		/** @var File $record */
179		$fields = new FieldList(
180		HeaderField::create('TitleHeader', $record ? $record->Title : null, 1)
181		->addExtraClass('editor__heading'),
182		$this->getFormFieldTabs($record, $context)
183		);
184		if ($record) {
185		$fields->push(HiddenField::create('ID', $record->ID));
186		$fields->insertAfter(
187		'TitleHeader',
188		PreviewImageField::create('PreviewImage')
189		->setRecordID($record->ID)
190		->addExtraClass('editor__file-preview')
191		);
192		}
193
194		$this->invokeWithExtensions('updateFormFields', $fields, $controller, $formName, $context);
195		return $fields;
196		}
197
198		/**
199		* Build popup menu
200		*
201		* @param File $record
202		* @return PopoverField
203		*/
204		protected function getPopoverMenu($record)
205		{
206		// Build popover actions
207		$popoverActions = $this->getPopoverActions($record);
208		if ($popoverActions) {
		0 ignored issues – show Bug Best Practice introduced 2017-04-04 04:07 UTC by Report Bug Copy Issue Report The expression `$popoverActions` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
209		return PopoverField::create($popoverActions)
210		->setPlacement('top')
211		->setButtonTooltip(_t(
212		'SilverStripe\\AssetAdmin\\Forms\\FileFormFactory.OTHER_ACTIONS',
213		'Other actions'
214		));
215		}
216		return null;
217		}
218
219		/**
220		* Get actions that go into the Popover menu
221		*
222		* @param $record
223		* @return array
224		*/
225		protected function getPopoverActions($record)
226		{
227		return array_filter([
228		$this->getDeleteAction($record)
229		]);
230		}
231
232		/**
233		* Build "details" formfield tab
234		*
235		* @param File $record
236		* @param array $context
237		* @return Tab
238		*/
239		protected function getFormFieldDetailsTab($record, $context = [])
240		{
241		return Tab::create(
242		'Details',
243		TextField::create('Name', File::singleton()->fieldLabel('Filename'))
244		);
245		}
246
247		public function getRequiredContext()
248		{
249		return ['Record'];
250		}
251		}
252

silverstripe / silverstripe-asset-admin

Pull Request — master (#415)

AssetFormFactory::getPopoverActions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like