Rating Changes - Inspection of "SS4 security changes and unit test fixes" - silverstripe/silverstripe-activedirectory - Measure and Improve Code Quality continuously with Scrutinizer

Completed

by Franco

created 2017-09-03 11:20 UTC

	⇢	B	LDAPLostPasswordHandler added
	⇢	A	FakeGatewayTest added
	⇢	A	LDAPServiceTest added
	⇢	A	SAMLLoginHandler added
	⇢	A	LDAPAuthenticatorTest added
	⇢	A	LDAPChangePasswordHandler added
	⇢	A	LDAPLoginHandler added
A	↘	B	LDAPAuthenticator got worse
A	↛		LDAPSecurityController removed
A	↛		LDAPServiceTest removed

	⇢	C	LDAPLostPasswordHandler::forgotPassword() added
	⇢	C	LDAPFakeGateway::search() added
	⇢	B	LDAPServiceTest::setUp() added
	⇢	B	LDAPLostPasswordHandler::lostPasswordForm() added
	⇢	A	LDAPServiceTest::testUpdateMemberFromLDAP() added
	⇢	A	LDAPAuthenticator::fallbackAuthenticate() added
	⇢	A	FakeGatewayTest::setUp() added
	⇢	A	LDAPAuthenticatorTest::setUp() added
	⇢	A	LDAPLoginHandler::loginForm() added
	⇢	A	LDAPAuthenticatorTest::testDisallowedEmailLogin() added
⋮			view more
C	↗	B	SAMLLoginForm::__construct() improved
C	↛		LDAPMemberLoginHandler::forgotPassword() removed
B	↛		LDAPSecurityController::lostpassword() removed
B	↛		LDAPSecurityController::passwordsent() removed
B	↛		LDAPServiceTest::setUp() removed
A	↛		LDAPServiceTest::testUpdateMemberFromLDAP() removed
A	↛		SAMLLoginForm::getMessageFromSession() removed
A	↛		SAMLLoginForm::logout() removed
A	↛		LDAPSecurityController::getPasswordResetLink() removed
A	↛		LDAPSecurityController::LostPasswordForm() removed
A	↛		LDAPAuthenticator::fallback_authenticate() removed
⋮			view more

silverstripe / silverstripe-activedirectory