SilverStripe\ActiveDirectory\Control\LDAPSecurityController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	136
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getPasswordResetLink()	0	7	1
A	ChangePasswordForm()	0	4	1
B	lostpassword()	0	33	4
A	LostPasswordForm()	0	12	1
A	Link()	0	4	1
B	passwordsent()	0	27	3

<?php

namespace SilverStripe\ActiveDirectory\Control;

use SilverStripe\ActiveDirectory\Authenticators\LDAPLoginForm;
use SilverStripe\Control\Controller;
use SilverStripe\Control\Director;
use SilverStripe\Core\Convert;
use SilverStripe\Core\Object;
use SilverStripe\Core\Config\Config;
use SilverStripe\Forms\EmailField;
use SilverStripe\Forms\FormAction;
use SilverStripe\Forms\FieldList;
use SilverStripe\Security\Security;

/**
 * Class LDAPSecurityController
 *
 * This controller overrides the default Security controller with functionality
 * for resetting passwords.
 *
 * @package activedirectory
 */
class LDAPSecurityController extends Security
{
    /**
     * @var array
     */
    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'index',
        'lostpassword',
        'LostPasswordForm',
        'ChangePasswordForm',
        'passwordsent'
    ];

    /**
     * This static function is *intentionally* overloaded from Security so
     * the user accesses this controller and uses the LDAP change password
     * form rather than the "standard" one provided by Security.
     *
     * @param Member $member
     * @param $autologinToken
     * @return string
     */
    public static function getPasswordResetLink($member, $autologinToken)
    {
        $autologinToken = urldecode($autologinToken);
        $selfControllerClass = __CLASS__;
        $selfController = new $selfControllerClass();
        return $selfController->Link('changepassword') . "?m={$member->ID}&t=$autologinToken";
    }

    /**
     * Factory method for the lost password form
     *
     * @return Form Returns the lost password form
     */
    public function ChangePasswordForm()
    {
        return Object::create('SilverStripe\\ActiveDirectory\\Forms\\LDAPChangePasswordForm', $this, 'ChangePasswordForm');

The return type of return \SilverStripe\Core\Object::create('SilverStripe\\ActiveDirectory\\Forms\\LDAPChangePasswordForm', $this, 'ChangePasswordForm'); (SilverStripe\ActiveDirectory\Control\LDAPSecurityController) is incompatible with the return type of the parent method SilverStripe\Security\Security::ChangePasswordForm of type SilverStripe\Security\ChangePasswordForm.

    }

    public function lostpassword()
    {
        $controller = $this->getResponseController(_t('LDAPSecurityController.LOSTPASSWORDHEADER', 'Lost password'));

        // if the controller calls Director::redirect(), this will break early
        if (($response = $controller->getResponse()) && $response->isFinished()) {
            return $response;
        }

        if (Config::inst()->get('SilverStripe\\ActiveDirectory\\Authenticators\\LDAPAuthenticator', 'allow_email_login') === 'yes') {
            $customisedController = $controller->customise([
                'Content' =>
                    _t(
                        'LDAPSecurityController.NOTERESETPASSWORDUSERNAMEOREMAIL',
                        'Enter your username or your email address and we will send you a link with which '
                        . 'you can reset your password'
                    ),
                'Form' => $this->LostPasswordForm(),
            ]);
        } else {
            $customisedController = $controller->customise([
                'Content' =>
                    _t(
                        'LDAPSecurityController.NOTERESETPASSWORDUSERNAME',
                        'Enter your username and we will send you a link with which you can reset your password'
                    ),
                'Form' => $this->LostPasswordForm(),
            ]);
        }

        //Controller::$currentController = $controller;

50% of this comment could be valid code. Did you maybe forget this after debugging?

        return $customisedController->renderWith($this->getTemplatesFor('lostpassword'));
    }

    /**
     * Factory method for the lost password form
     *
     * @return Form Returns the lost password form
     */
    public function LostPasswordForm()
    {
        $email = EmailField::create('Email', _t('Member.EMAIL', 'Email'));
        $action = FormAction::create('forgotPassword', _t('Security.BUTTONSEND', 'Send me the password reset link'));
        return LDAPLoginForm::create(
            $this,
            'LostPasswordForm',
            FieldList::create([$email]),
            FieldList::create([$action]),
            false
        );
    }

    /**
     * @param null $action
     * @return String
     */
    public function Link($action = null)
    {
        return Controller::join_links(Director::baseURL(), 'LDAPSecurity', $action);
    }

    /**
     * Show the "password sent" page, after a user has requested
     * to reset their password.
     *
     * @param SS_HTTPRequest $request The SS_HTTPRequest for this action.
     * @return string Returns the "password sent" page as HTML code.
     */
    public function passwordsent($request)
    {
        $controller = $this->getResponseController(_t('Security.LOSTPASSWORDHEADER', 'Lost Password'));

        // if the controller calls Director::redirect(), this will break early
        if (($response = $controller->getResponse()) && $response->isFinished()) {
            return $response;
        }

        $username = Convert::raw2xml(rawurldecode($request->param('ID')));

        $customisedController = $controller->customise([
            'Title' => _t(
                'LDAPSecurity.PASSWORDSENTHEADER',
                "Password reset link sent to '{username}'",
                ['username' => $username]

array('username' => $username) is of type array<string,array|string,{"username":"array|string"}>, but the function expects a string.

            ),
            'Content' =>
                _t(
                    'LDAPSecurity.PASSWORDSENTTEXT',
                    "Thank you! A reset link has been sent to '{username}', provided an account exists.",
                    ['username' => $username]

array('username' => $username) is of type array<string,array|string,{"username":"array|string"}>, but the function expects a string.

                ),
            'Username' => $username
        ]);
        return $customisedController->renderWith($this->getTemplatesFor('passwordsent'));
    }
}