LDAPDebugController

Complexity

Total Complexity

22

Size/Duplication

Total Lines	142
Duplicated Lines	38.03 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	8	2
A	index()	0	3	1
A	Options()	0	15	3
A	UsersSearchLocations()	16	16	3
A	GroupsSearchLocations()	16	16	3
A	DefaultGroup()	0	17	4
A	MappedGroups()	0	4	1
A	Nodes()	11	11	2
A	Groups()	11	11	2
A	Users()	0	4	1

<?php
/**
 * Class LDAPDebugController
 *
 * This controller is used to debug the LDAP connection.
 */
class LDAPDebugController extends ContentController

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * @var array
     */
    private static $allowed_actions = [

The property $allowed_actions is not used and could be removed.

        'index',
    ];

    /**
     * @var array
     */
    private static $dependencies = [

The property $dependencies is not used and could be removed.

        'ldapService' => '%$LDAPService'
    ];

    /**
     * @var LDAPService
     */
    public $ldapService;

    public function init()
    {
        parent::init();

        if (!Permission::check('ADMIN')) {
            Security::permissionFailure();
        }
    }

    /**
     * @param SS_HTTPRequest $request
     *
     * @return string
     */
    public function index(\SS_HTTPRequest $request) {
        return $this->renderWith(['LDAPDebugController']);
    }

    public function Options()
    {
        $list = new ArrayList();
        foreach (Config::inst()->get('LDAPGateway', 'options') as $field => $value) {

The expression \Config::inst()->get('LDAPGateway', 'options') of type array|integer|double|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

            if ($field === 'password') {
                $value = '***';
            }

            $list->push(new ArrayData([
                'Name' => $field,
                'Value' => $value
            ]));
        }
        return $list;
    }

    public function UsersSearchLocations()

This method seems to be duplicated in your project.

    {
        $locations = Config::inst()->get('LDAPService', 'users_search_locations');
        $list = new ArrayList();
        if ($locations) {
            foreach ($locations as $location) {

The expression $locations of type array|integer|double|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

                $list->push(new ArrayData([
                    'Value' => $location
                ]));
            }
        } else {
            $list->push($this->Options()->find('Name', 'baseDn'));
        }

        return $list;
    }

    public function GroupsSearchLocations()

This method seems to be duplicated in your project.

    {
        $locations = Config::inst()->get('LDAPService', 'groups_search_locations');
        $list = new ArrayList();
        if ($locations) {
            foreach ($locations as $location) {

The expression $locations of type array|integer|double|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

                $list->push(new ArrayData([
                    'Value' => $location
                ]));
            }
        } else {
            $list->push($this->Options()->find('Name', 'baseDn'));
        }

        return $list;
    }

    public function DefaultGroup()
    {
        $code = Config::inst()->get('LDAPService', 'default_group');
        if ($code) {
            $group = Group::get()->filter('Code', $code)->limit(1)->first();
            if (!($group && $group->exists())) {
                return sprintf(
                    'WARNING: LDAPService.default_group configured with \'%s\' but there is no Group with that Code in the database!',
                    $code
                );
            } else {
                return sprintf('%s (Code: %s)', $group->Title, $group->Code);
            }
        }

        return null;
    }

    public function MappedGroups()
    {
        return LDAPGroupMapping::get();
    }

    public function Nodes()

This method seems to be duplicated in your project.

    {
        $groups = $this->ldapService->getNodes(false);
        $list = new ArrayList();
        foreach ($groups as $record) {
            $list->push(new ArrayData([
                'DN' => $record['dn']
            ]));
        }
        return $list;
    }

    public function Groups()

This method seems to be duplicated in your project.

    {
        $groups = $this->ldapService->getGroups(false);
        $list = new ArrayList();
        foreach ($groups as $record) {
            $list->push(new ArrayData([
                'DN' => $record['dn']
            ]));
        }
        return $list;
    }

    public function Users()
    {
        return count($this->ldapService->getUsers());
    }
}