GroupProcessManager::addTaskGroup() - Code Metrics - silverstripe/doorman - Measure and Improve Code Quality continuously with Scrutinizer

GroupProcessManager::addTaskGroup() A
last analyzed 2021-05-30 20:53 UTC

↳ Parent: GroupProcessManager

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
c	0
b	0
f	0
rs	9.9332
cc	2
nc	2
nop	1

<?php

namespace AsyncPHP\Doorman\Manager;

use AsyncPHP\Doorman\Manager;
use AsyncPHP\Doorman\Task;

class GroupProcessManager implements Manager
{
    /**
     * @var Manager
     */
    protected $manager;

    /**
     * @var Task[][]
     */
    protected $waiting = array();

    /**
     * @var Task[][]
     */
    protected $queuing = array();

    /**
     * @param Manager $manager
     */
    public function __construct(Manager $manager)
    {
        $this->manager = $manager;
    }

    /**
     * @inheritdoc
     *
     * @param Task $task
     *
     * @return $this
     */
    public function addTask(Task $task)
    {
        array_push($this->waiting, array($task));

        return $this;
    }

    /**
     * Adds a group of tasks to be handled.
     *
     * @param Task[] $tasks
     *
     * @return $this
     */
    public function addTaskGroup(array $tasks)
    {
        foreach ($tasks as $task) {
            assert($task instanceof Task);
        }

        array_push($this->waiting, $tasks);

        return $this;
    }

    /**
     * @inheritdoc
     *
     * @return bool
     */
    public function tick()
    {
        if (!empty($this->queuing)) {
            $this->manager->addTask(array_shift($this->queuing));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        if ($this->manager->tick()) {
            return true;
        }

        if (empty($this->waiting)) {
            return false;
        }

        $this->queuing = array_shift($this->waiting);
function aContainsB(array $needle = null, array  $haystack) {
    if (!$needle) {
        return false;
    }

    return array_intersect($haystack, $needle) == $haystack;
}

        return true;
    }

    /**
     * Passes missing method calls to the decorated manager.
     *
     * @param string $method
     * @param array  $parameters
     *
     * @return mixed
     */
    public function __call($method, array $parameters)
    {
        return call_user_func_array(array($this->manager, $method), $parameters);
    }
}


1			<?php
2
3			namespace AsyncPHP\Doorman\Manager;
4
5			use AsyncPHP\Doorman\Manager;
6			use AsyncPHP\Doorman\Task;
7
8			class GroupProcessManager implements Manager
9			{
10			/**
11			* @var Manager
12			*/
13			protected $manager;
14
15			/**
16			* @var Task[][]
17			*/
18			protected $waiting = array();
19
20			/**
21			* @var Task[][]
22			*/
23			protected $queuing = array();
24
25			/**
26			* @param Manager $manager
27			*/
28			public function __construct(Manager $manager)
29			{
30			$this->manager = $manager;
31			}
32
33			/**
34			* @inheritdoc
35			*
36			* @param Task $task
37			*
38			* @return $this
39			*/
40			public function addTask(Task $task)
41			{
42			array_push($this->waiting, array($task));
43
44			return $this;
45			}
46
47			/**
48			* Adds a group of tasks to be handled.
49			*
50			* @param Task[] $tasks
51			*
52			* @return $this
53			*/
54			public function addTaskGroup(array $tasks)
55			{
56			foreach ($tasks as $task) {
57			assert($task instanceof Task);
58			}
59
60			array_push($this->waiting, $tasks);
61
62			return $this;
63			}
64
65			/**
66			* @inheritdoc
67			*
68			* @return bool
69			*/
70			public function tick()
71			{
72			if (!empty($this->queuing)) {
73			$this->manager->addTask(array_shift($this->queuing));
			0 ignored issues – show Documentation introduced 2021-04-20 05:23 UTC by Report Bug Copy Issue Report `array_shift($this->queuing)` is of type `array<integer,object<AsyncPHP\Doorman\Task>>\|null`, but the function expects a `object<AsyncPHP\Doorman\Task>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74			}
75
76			if ($this->manager->tick()) {
77			return true;
78			}
79
80			if (empty($this->waiting)) {
81			return false;
82			}
83
84			$this->queuing = array_shift($this->waiting);
			0 ignored issues – show Documentation Bug introduced 2021-04-20 05:23 UTC by Report Bug Copy Issue Report It seems like `array_shift($this->waiting)` can be `null`. However, the property `$queuing` is declared as `array`. Maybe change the type of the property to `array\|null` or add a type check? Our type inference engine has found an assignment of a scalar value (like a string, an integer or null) to a property which is an array. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property. To type hint that a parameter can be either an array or null, you can set a type hint of array and a default value of null. The PHP interpreter will then accept both an array or null for that parameter. function aContainsB(array $needle = null, array $haystack) { if (!$needle) { return false; } return array_intersect($haystack, $needle) == $haystack; } The function can be called with either null or an array for the parameter `$needle` but will only accept an array as `$haystack`. Loading history...
85
86			return true;
87			}
88
89			/**
90			* Passes missing method calls to the decorated manager.
91			*
92			* @param string $method
93			* @param array $parameters
94			*
95			* @return mixed
96			*/
97			public function __call($method, array $parameters)
98			{
99			return call_user_func_array(array($this->manager, $method), $parameters);
100			}
101			}
102

silverstripe / doorman

GroupProcessManager::addTaskGroup() A last analyzed 2021-05-30 20:53 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

GroupProcessManager::addTaskGroup() A
last analyzed 2021-05-30 20:53 UTC