Issues in variable_table.jsx (master) - Issues in master - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Issues (524)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

js/variable_table.jsx (2 issues)

Severity

Unknown 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

var _ = require('underscore');

var React = require("react");

/**
 * VariableTable displays variable => value pairs in a table. It also provides a button
 * to transition to the editing stage.
 *
 * @param array variables Contains the list of key=>values
 *   [
 *     { variable: key1, value: val1	},
 *     { variable: key2, value: val2	},
 *     ...
 *   ]
 * @param function edit Handler for triggering a transition to editing.
 * @param bool showValues Set to false to hide value column.
 * @param bool showHeading Set to false to hide the header row.
 * @param string variableHeading Set the heading for the variable column.
 * @param string valueHeading Set the heading for the value column.
 */
var VariableTable = React.createClass({

	getDefaultProps: function() {
		return {
			showValues: true,
			showHeading: true,
			variableHeading: "Variable <small>(string)</small>",
			valueHeading: "Value <small>(string)</small>"
		};
	},

	render: function() {
		var self = this;

		var showStatusColumn = false;
		if (this.props.readonlyVariables && !_.isEmpty(this.props.readonlyVariables)) {
			showStatusColumn = true;
		}

		var readonlyRows = _.map(this.props.readonlyVariables, function(item) {
			return (
				<VariableReadonlyTableRow
					key={item.variable + '_' + item.value}
					variable={item.variable}
					value={item.value}
					showValues={self.props.showValues}
				/>
			);
		});

		var rows = _.map(this.props.variables, function(item) {
			return (
				<VariableTableRow
					key={item.variable + '_' + item.value}
					variable={item.variable}
					value={item.value}
					showValues={self.props.showValues}
					showStatusColumn={showStatusColumn}
				/>
			);
		});

		var valueHeading = null;
		if (this.props.showValues) {
			valueHeading = (
				<th
					className="value"
					dangerouslySetInnerHTML={{__html:this.props.valueHeading}}

				/>
			);
		}

		var statusHeading = null;
		if (showStatusColumn === true) {
			statusHeading = <th className="status"></th>;
		}

		var heading = null;
		if (this.props.showHeading) {
			heading = (
				<thead>
					<tr>
						<th
							className="variable"
							dangerouslySetInnerHTML={{__html:this.props.variableHeading}}

						/>
						{valueHeading}
						{statusHeading}
					</tr>
				</thead>
			);
		}

		return (
			<div className="variables">
				<div className="variables-actions variable-table-actions">
					<button
						type="button"
						className="btn btn-primary"
						onClick={this.props.edit}
					>
					Edit
					</button>
				</div>
				<table className="variable-table table">
					{heading}
					<tbody>
						{readonlyRows}
						{rows}
					</tbody>
				</table>
			</div>
		);
	}
});

function VariableTableRow(props) {

	var value = null;
	if (props.showValues) {
		value = <td className="value">{props.value}</td>;
	}

	var status = null;
	if (props.showStatusColumn) {
		status = <td className="status text-center"></td>;
	}

	return (
		<tr>
			<td className="variable">{props.variable}</td>
			{value}
			{status}
		</tr>
	);
}

module.exports = VariableTable;

function VariableReadonlyTableRow(props) {
	var value = null;
	if (props.showValues) {
		value = <td className="value">{props.value}</td>;
	}

	return (
		<tr>
			<td className="variable">{props.variable}</td>
			{value}
			<td className="status text-center"><i className="fa fa-lock"></i>
			</td>
		</tr>
	);
}


1			var _ = require('underscore');
2
3			var React = require("react");
4
5			/**
6			* VariableTable displays variable => value pairs in a table. It also provides a button
7			* to transition to the editing stage.
8			*
9			* @param array variables Contains the list of key=>values
10			* [
11			* { variable: key1, value: val1 },
12			* { variable: key2, value: val2 },
13			* ...
14			* ]
15			* @param function edit Handler for triggering a transition to editing.
16			* @param bool showValues Set to false to hide value column.
17			* @param bool showHeading Set to false to hide the header row.
18			* @param string variableHeading Set the heading for the variable column.
19			* @param string valueHeading Set the heading for the value column.
20			*/
21			var VariableTable = React.createClass({
22
23			getDefaultProps: function() {
24			return {
25			showValues: true,
26			showHeading: true,
27			variableHeading: "Variable <small>(string)</small>",
28			valueHeading: "Value <small>(string)</small>"
29			};
30			},
31
32			render: function() {
33			var self = this;
34
35			var showStatusColumn = false;
36			if (this.props.readonlyVariables && !_.isEmpty(this.props.readonlyVariables)) {
37			showStatusColumn = true;
38			}
39
40			var readonlyRows = _.map(this.props.readonlyVariables, function(item) {
41			return (
42			<VariableReadonlyTableRow
43			key={item.variable + '_' + item.value}
44			variable={item.variable}
45			value={item.value}
46			showValues={self.props.showValues}
47			/>
48			);
49			});
50
51			var rows = _.map(this.props.variables, function(item) {
52			return (
53			<VariableTableRow
54			key={item.variable + '_' + item.value}
55			variable={item.variable}
56			value={item.value}
57			showValues={self.props.showValues}
58			showStatusColumn={showStatusColumn}
59			/>
60			);
61			});
62
63			var valueHeading = null;
64			if (this.props.showValues) {
65			valueHeading = (
66			<th
67			className="value"
68			dangerouslySetInnerHTML={{__html:this.props.valueHeading}}
			0 ignored issues – show introduced 2016-09-09 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Dangerous property 'dangerouslySetInnerHTML' found Loading history...
69			/>
70			);
71			}
72
73			var statusHeading = null;
74			if (showStatusColumn === true) {
75			statusHeading = <th className="status"></th>;
76			}
77
78			var heading = null;
79			if (this.props.showHeading) {
80			heading = (
81			<thead>
82			<tr>
83			<th
84			className="variable"
85			dangerouslySetInnerHTML={{__html:this.props.variableHeading}}
			0 ignored issues – show introduced 2016-09-09 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Dangerous property 'dangerouslySetInnerHTML' found Loading history...
86			/>
87			{valueHeading}
88			{statusHeading}
89			</tr>
90			</thead>
91			);
92			}
93
94			return (
95			<div className="variables">
96			<div className="variables-actions variable-table-actions">
97			<button
98			type="button"
99			className="btn btn-primary"
100			onClick={this.props.edit}
101			>
102			Edit
103			</button>
104			</div>
105			<table className="variable-table table">
106			{heading}
107			<tbody>
108			{readonlyRows}
109			{rows}
110			</tbody>
111			</table>
112			</div>
113			);
114			}
115			});
116
117			function VariableTableRow(props) {
118
119			var value = null;
120			if (props.showValues) {
121			value = <td className="value">{props.value}</td>;
122			}
123
124			var status = null;
125			if (props.showStatusColumn) {
126			status = <td className="status text-center"></td>;
127			}
128
129			return (
130			<tr>
131			<td className="variable">{props.variable}</td>
132			{value}
133			{status}
134			</tr>
135			);
136			}
137
138			module.exports = VariableTable;
139
140			function VariableReadonlyTableRow(props) {
141			var value = null;
142			if (props.showValues) {
143			value = <td className="value">{props.value}</td>;
144			}
145
146			return (
147			<tr>
148			<td className="variable">{props.variable}</td>
149			{value}
150			<td className="status text-center"><i className="fa fa-lock"></i>
151			</td>
152			</tr>
153			);
154			}
155

silverstripe / deploynaut

Issues (524)

Security Analysis not enabled

js/variable_table.jsx (2 issues)

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like