Issues in SummaryTable.jsx (master) - Issues in master - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Issues (524)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

js/SummaryTable.jsx (2 issues)

Labels

Coding Style 1

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

var React = require("react");

var SummaryTable = React.createClass({

	propTypes: {
		changes: React.PropTypes.objectOf(React.PropTypes.shape(
			React.PropTypes.objectOf(React.PropTypes.shape({
				from: React.PropTypes.string,
				to: React.PropTypes.string
			})).isRequired
		)).isRequired
	},

	render: function() {
		var changes = this.props.changes;

		var idx = 0;
		var summaryLines = Object.keys(changes).map(function(key) {
			idx++;


			var compareUrl = null;
			if (typeof changes[key].compareUrl !== 'undefined') {
				compareUrl = changes[key].compareUrl;
			}

			if (typeof changes[key].description !== 'undefined') {

				if (changes[key].description !== "") {
					return (
						<DescriptionOnlySummaryLine
							key={idx}
							name={key}
							description={changes[key].description}
							compareUrl={compareUrl}
						/>
					);
				}
				return (
					<UnchangedSummaryLine
						key={idx}
						name={key}
						value=""
					/>
				);

			} else if (changes[key].from !== changes[key].to) {
				return (
					<SummaryLine
						key={idx}
						name={key}
						from={changes[key].from}
						to={changes[key].to}
						compareUrl={compareUrl}
					/>
				);
			} else if (typeof changes[key].from !== 'undefined') {
				return (
					<UnchangedSummaryLine
						key={idx}
						name={key}
						value={changes[key].from}
					/>
				);
			}
			return null;
		});

		return (
			<table className="table table-striped table-hover">
				<tbody>
					{summaryLines}
				</tbody>
			</table>
		);
	}
});

function SummaryLine(props) {
	var from = props.from;
	var to = props.to;

	// naive git sha detection
	if (from !== null && from.length === 40) {
		from = from.substring(0, 7);
	}

	// naive git sha detection
	if (to !== null && to.length === 40) {
		to = to.substring(0, 7);
	}

	var compareUrl = null;
	if (props.compareUrl !== null) {
		compareUrl = (
			<a href={props.compareUrl}>
				View diff<i className="fa fa-external-link-square superscript"></i>
			</a>
		);
	}

	return (
		<tr>
			<th scope="row">{props.name}</th>
			<td>{from}</td>
			<td><span className="glyphicon glyphicon-arrow-right" /></td>
			<td>{to}</td>
			<td className="changeAction">{compareUrl}</td>
		</tr>
	);
}

function UnchangedSummaryLine(props) {
	var from = props.value;
	// naive git sha detection
	if (from !== null && from.length === 40) {
		from = from.substring(0, 7);
	}

	return (
		<tr>
			<th scope="row">{props.name}</th>
			<td>{from}</td>
			<td>&nbsp;</td>
			<td><span className="label label-success">Unchanged</span></td>
			<td>&nbsp;</td>
		</tr>
	);
}

function DescriptionOnlySummaryLine(props) {
	var compareColumn = null;
	var colSpan = "4";
	if (props.compareUrl !== null) {
		compareColumn = (
			<td className="changeAction">
				<a href={props.compareUrl}>
					View diff<i className="fa fa-external-link-square superscript"></i>
				</a>
			</td>
		);
		colSpan = "3";
	}

	return (
		<tr>
			<th scope="row">{props.name}</th>
			<td
				colSpan={colSpan}
				dangerouslySetInnerHTML={{__html: props.description}}

			/>
			{compareColumn}
		</tr>
	);
}

module.exports = SummaryTable;


1			var React = require("react");
2
3			var SummaryTable = React.createClass({
4
5			propTypes: {
6			changes: React.PropTypes.objectOf(React.PropTypes.shape(
7			React.PropTypes.objectOf(React.PropTypes.shape({
8			from: React.PropTypes.string,
9			to: React.PropTypes.string
10			})).isRequired
11			)).isRequired
12			},
13
14			render: function() {
15			var changes = this.props.changes;
16
17			var idx = 0;
18			var summaryLines = Object.keys(changes).map(function(key) {
19			idx++;
			0 ignored issues – show Coding Style introduced 2016-09-09 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, please do not use `++`, but use `+= 1` instead. Loading history...
20
21			var compareUrl = null;
22			if (typeof changes[key].compareUrl !== 'undefined') {
23			compareUrl = changes[key].compareUrl;
24			}
25
26			if (typeof changes[key].description !== 'undefined') {
27
28			if (changes[key].description !== "") {
29			return (
30			<DescriptionOnlySummaryLine
31			key={idx}
32			name={key}
33			description={changes[key].description}
34			compareUrl={compareUrl}
35			/>
36			);
37			}
38			return (
39			<UnchangedSummaryLine
40			key={idx}
41			name={key}
42			value=""
43			/>
44			);
45
46			} else if (changes[key].from !== changes[key].to) {
47			return (
48			<SummaryLine
49			key={idx}
50			name={key}
51			from={changes[key].from}
52			to={changes[key].to}
53			compareUrl={compareUrl}
54			/>
55			);
56			} else if (typeof changes[key].from !== 'undefined') {
57			return (
58			<UnchangedSummaryLine
59			key={idx}
60			name={key}
61			value={changes[key].from}
62			/>
63			);
64			}
65			return null;
66			});
67
68			return (
69			<table className="table table-striped table-hover">
70			<tbody>
71			{summaryLines}
72			</tbody>
73			</table>
74			);
75			}
76			});
77
78			function SummaryLine(props) {
79			var from = props.from;
80			var to = props.to;
81
82			// naive git sha detection
83			if (from !== null && from.length === 40) {
84			from = from.substring(0, 7);
85			}
86
87			// naive git sha detection
88			if (to !== null && to.length === 40) {
89			to = to.substring(0, 7);
90			}
91
92			var compareUrl = null;
93			if (props.compareUrl !== null) {
94			compareUrl = (
95			<a href={props.compareUrl}>
96			View diff<i className="fa fa-external-link-square superscript"></i>
97			</a>
98			);
99			}
100
101			return (
102			<tr>
103			<th scope="row">{props.name}</th>
104			<td>{from}</td>
105			<td><span className="glyphicon glyphicon-arrow-right" /></td>
106			<td>{to}</td>
107			<td className="changeAction">{compareUrl}</td>
108			</tr>
109			);
110			}
111
112			function UnchangedSummaryLine(props) {
113			var from = props.value;
114			// naive git sha detection
115			if (from !== null && from.length === 40) {
116			from = from.substring(0, 7);
117			}
118
119			return (
120			<tr>
121			<th scope="row">{props.name}</th>
122			<td>{from}</td>
123			<td> </td>
124			<td><span className="label label-success">Unchanged</span></td>
125			<td> </td>
126			</tr>
127			);
128			}
129
130			function DescriptionOnlySummaryLine(props) {
131			var compareColumn = null;
132			var colSpan = "4";
133			if (props.compareUrl !== null) {
134			compareColumn = (
135			<td className="changeAction">
136			<a href={props.compareUrl}>
137			View diff<i className="fa fa-external-link-square superscript"></i>
138			</a>
139			</td>
140			);
141			colSpan = "3";
142			}
143
144			return (
145			<tr>
146			<th scope="row">{props.name}</th>
147			<td
148			colSpan={colSpan}
149			dangerouslySetInnerHTML={{__html: props.description}}
			0 ignored issues – show introduced 2016-09-09 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Dangerous property 'dangerouslySetInnerHTML' found Loading history...
150			/>
151			{compareColumn}
152			</tr>
153			);
154			}
155
156			module.exports = SummaryTable;
157

silverstripe / deploynaut

Issues (524)

Security Analysis not enabled

js/SummaryTable.jsx (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like