Issues in FetchJob.php (master) - Issues in master - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Issues (524)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/jobs/FetchJob.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class FetchJob extends DeploynautJob {

	public $args;

	/**
	 * @var DNProject
	 */
	protected $project;

	/**
	 * @var \DeploynautLogFile
	 */
	protected $log;

	/**
	 * @var string
	 */
	protected $user;

	/**
	 * @global array $databaseConfig
	 */
	public function setUp() {
		global $databaseConfig;
function myFunction($a, $b) {
    // Do something
}
		DB::connect($databaseConfig);

		$this->updateStatus('Started');
		chdir(BASE_PATH);
	}

	public function perform() {
		set_time_limit(0);

		if(!empty($this->args['logfile'])) {
			$this->log = new DeploynautLogFile($this->args['logfile']);
		}

		$this->project = DNProject::get()->byId($this->args['projectID']);
		if(!($this->project && $this->project->exists())) {
			throw new RuntimeException(sprintf('Project ID %s not found', $this->args['projectID']));
		}

		$this->user = DNData::inst()->getGitUser() ?: null;

		// Disallow concurrent git fetches on the same project.
		// Only consider fetches started in the last 30 minutes (older jobs probably got stuck)
		try {
			if(!empty($this->args['fetchID'])) {
				$runningFetches = DNGitFetch::get()
					->filter(array(
						'ProjectID' => $this->project->ID,
						'Status' => array('Queued', 'Started'),
						'Created:GreaterThan' => strtotime('-30 minutes')
					))
					->exclude('ID', $this->args['fetchID']);

				if($runningFetches->count()) {
					$runningFetch = $runningFetches->first();
					$message = sprintf(
						'Another fetch is in progress (started at %s by %s)',
						$runningFetch->dbObject('Created')->Nice(),
						$runningFetch->Deployer()->Title
					);
					if($this->log) {
						$this->log->write($message);
					}
					throw new RuntimeException($message);
				}
			}

			// Decide whether we need to just update what we already have
			// or initiate a clone if no local repo exists.
			if($this->project->repoExists() && empty($this->args['forceClone'])) {

				$this->fetchRepo();
			} else {
				$this->cloneRepo();
			}
		} catch(Exception $e) {
			if($this->log) {
				$this->log->write($e->getMessage());
			}
			throw $e;
		}
		$this->project->clearGitCache();
		$this->updateStatus('Finished');
	}

	protected function fetchRepo() {
		$this->runCommand(
			'/usr/bin/git fetch -p origin +refs/heads/*:refs/heads/* --tags',
			$this->project->getLocalCVSPath()
		);
	}

	protected function cloneRepo() {
		if(file_exists($this->project->getLocalCVSPath())) {
			$this->runCommand(sprintf(
				'rm -rf %s',
				escapeshellarg($this->project->getLocalCVSPath())
			));
		}

		$this->runCommand(sprintf(
			'/usr/bin/git clone --bare -q %s %s',
			escapeshellarg($this->project->CVSPath),
			escapeshellarg($this->project->getLocalCVSPath())
		));
	}

	/**
	 * Run a shell command.
	 *
	 * @param string $command The command to run
	 * @param string|null $workingDir The working dir to run command in
	 * @throws RuntimeException
	 */
	protected function runCommand($command, $workingDir = null) {
		if(!empty($this->user)) {
			$command = sprintf('sudo -u %s %s', $this->user, $command);
		}
		if($this->log) {
			$this->log->write(sprintf('Running command: %s', $command));
		}
		$process = new AbortableProcess($command, $workingDir);
		$process->setEnv($this->project->getProcessEnv());
		$process->setTimeout(1800);
		$process->run();
		if(!$process->isSuccessful()) {
			throw new RuntimeException($process->getErrorOutput());
		}
	}

	/**
	 * @param string $status
	 * @global array $databaseConfig
	 */
	protected function updateStatus($status) {
		global $databaseConfig;
function myFunction($a, $b) {
    // Do something
}
		DB::connect($databaseConfig);

		if(!empty($this->args['fetchID'])) {
			$fetch = DNGitFetch::get()->byID($this->args['fetchID']);
			if($fetch && $fetch->exists()) {
				$fetch->Status = $status;
				$fetch->write();
			}
		}
	}

}


1			<?php
2
3			class FetchJob extends DeploynautJob {
4
5			public $args;
6
7			/**
8			* @var DNProject
9			*/
10			protected $project;
11
12			/**
13			* @var \DeploynautLogFile
14			*/
15			protected $log;
16
17			/**
18			* @var string
19			*/
20			protected $user;
21
22			/**
23			* @global array $databaseConfig
24			*/
25			public function setUp() {
26			global $databaseConfig;
			0 ignored issues – show Compatibility Best Practice introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
27			DB::connect($databaseConfig);
28
29			$this->updateStatus('Started');
30			chdir(BASE_PATH);
31			}
32
33			public function perform() {
34			set_time_limit(0);
35
36			if(!empty($this->args['logfile'])) {
37			$this->log = new DeploynautLogFile($this->args['logfile']);
38			}
39
40			$this->project = DNProject::get()->byId($this->args['projectID']);
41			if(!($this->project && $this->project->exists())) {
42			throw new RuntimeException(sprintf('Project ID %s not found', $this->args['projectID']));
43			}
44
45			$this->user = DNData::inst()->getGitUser() ?: null;
46
47			// Disallow concurrent git fetches on the same project.
48			// Only consider fetches started in the last 30 minutes (older jobs probably got stuck)
49			try {
50			if(!empty($this->args['fetchID'])) {
51			$runningFetches = DNGitFetch::get()
52			->filter(array(
53			'ProjectID' => $this->project->ID,
54			'Status' => array('Queued', 'Started'),
55			'Created:GreaterThan' => strtotime('-30 minutes')
56			))
57			->exclude('ID', $this->args['fetchID']);
58
59			if($runningFetches->count()) {
60			$runningFetch = $runningFetches->first();
61			$message = sprintf(
62			'Another fetch is in progress (started at %s by %s)',
63			$runningFetch->dbObject('Created')->Nice(),
64			$runningFetch->Deployer()->Title
65			);
66			if($this->log) {
67			$this->log->write($message);
68			}
69			throw new RuntimeException($message);
70			}
71			}
72
73			// Decide whether we need to just update what we already have
74			// or initiate a clone if no local repo exists.
75			if($this->project->repoExists() && empty($this->args['forceClone'])) {
			0 ignored issues – show Bug introduced 2015-11-24 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `repoExists()` does not exist on `DataObject`. Did you maybe mean `exists()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
76			$this->fetchRepo();
77			} else {
78			$this->cloneRepo();
79			}
80			} catch(Exception $e) {
81			if($this->log) {
82			$this->log->write($e->getMessage());
83			}
84			throw $e;
85			}
86			$this->project->clearGitCache();
87			$this->updateStatus('Finished');
88			}
89
90			protected function fetchRepo() {
91			$this->runCommand(
92			'/usr/bin/git fetch -p origin +refs/heads/:refs/heads/ --tags',
93			$this->project->getLocalCVSPath()
94			);
95			}
96
97			protected function cloneRepo() {
98			if(file_exists($this->project->getLocalCVSPath())) {
99			$this->runCommand(sprintf(
100			'rm -rf %s',
101			escapeshellarg($this->project->getLocalCVSPath())
102			));
103			}
104
105			$this->runCommand(sprintf(
106			'/usr/bin/git clone --bare -q %s %s',
107			escapeshellarg($this->project->CVSPath),
108			escapeshellarg($this->project->getLocalCVSPath())
109			));
110			}
111
112			/**
113			* Run a shell command.
114			*
115			* @param string $command The command to run
116			* @param string\|null $workingDir The working dir to run command in
117			* @throws RuntimeException
118			*/
119			protected function runCommand($command, $workingDir = null) {
120			if(!empty($this->user)) {
121			$command = sprintf('sudo -u %s %s', $this->user, $command);
122			}
123			if($this->log) {
124			$this->log->write(sprintf('Running command: %s', $command));
125			}
126			$process = new AbortableProcess($command, $workingDir);
127			$process->setEnv($this->project->getProcessEnv());
128			$process->setTimeout(1800);
129			$process->run();
130			if(!$process->isSuccessful()) {
131			throw new RuntimeException($process->getErrorOutput());
132			}
133			}
134
135			/**
136			* @param string $status
137			* @global array $databaseConfig
138			*/
139			protected function updateStatus($status) {
140			global $databaseConfig;
			0 ignored issues – show Compatibility Best Practice introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
141			DB::connect($databaseConfig);
142
143			if(!empty($this->args['fetchID'])) {
144			$fetch = DNGitFetch::get()->byID($this->args['fetchID']);
145			if($fetch && $fetch->exists()) {
146			$fetch->Status = $status;
147			$fetch->write();
148			}
149			}
150			}
151
152			}
153

silverstripe / deploynaut

Issues (524)

Security Analysis not enabled

code/jobs/FetchJob.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like