Issues in DataArchiveFileField.php (master) - Issues in master - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Issues (524)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/form/DataArchiveFileField.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Class DataArchiveFileField
 *
 * Overwrite field to save into a {@link DataArchive}, using generateFilepath().
 * This mainly just works around the limitation
 * of FileField to set the folder path *before* uploading the file,
 * at which point we don't have a {@link DataTransfer} ID yet, so can't generate the path.
 */
class DataArchiveFileField extends FileField {

	/**
	 * @param DataObjectInterface $record
	 * @return bool|DataArchiveFileField
	 */
	public function saveInto(DataObjectInterface $record) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		if(!isset($_FILES[$this->name])) {
			return false;
		}

		if(!($record instanceof DNDataArchive)) {
			throw new LogicException('Saving into wrong type, expected DNDataArchive');
		}

		$dataArchive = $record;

		/** @var DNDataTransfer $dataTransfer */
		$dataTransfer = $dataArchive->DataTransfers()->First();
		if(!$dataTransfer) {
			throw new LogicException('No transfer found');
		}

		$fileClass = File::get_class_for_file_extension(pathinfo($_FILES[$this->name]['name'], PATHINFO_EXTENSION));
		$file = new $fileClass();
		// Hack: loadIntoFile assumes paths relative to assets,
		//  otherwise it creates the whole structure *within* that folder
		$absolutePath = $dataArchive->generateFilepath($dataTransfer);
		$relativePath = preg_replace('#^' . preg_quote(ASSETS_PATH) . '/#', '', $absolutePath);
		$this->upload->loadIntoFile($_FILES[$this->name], $file, $relativePath);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		if($this->upload->isError()) {
			return false;
		}

		$file = $this->upload->getFile();
		if($this->relationAutoSetting) {
			// save to record
			$record->{$this->name . 'ID'} = $file->ID;
		}

		return $this;
	}
}


1			<?php
2
3			/**
4			* Class DataArchiveFileField
5			*
6			* Overwrite field to save into a {@link DataArchive}, using generateFilepath().
7			* This mainly just works around the limitation
8			* of FileField to set the folder path before uploading the file,
9			* at which point we don't have a {@link DataTransfer} ID yet, so can't generate the path.
10			*/
11			class DataArchiveFileField extends FileField {
12
13			/**
14			* @param DataObjectInterface $record
15			* @return bool\|DataArchiveFileField
16			*/
17			public function saveInto(DataObjectInterface $record) {
			0 ignored issues – show Coding Style introduced 2015-11-24 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `saveInto` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
18			if(!isset($_FILES[$this->name])) {
19			return false;
20			}
21
22			if(!($record instanceof DNDataArchive)) {
23			throw new LogicException('Saving into wrong type, expected DNDataArchive');
24			}
25
26			$dataArchive = $record;
27
28			/** @var DNDataTransfer $dataTransfer */
29			$dataTransfer = $dataArchive->DataTransfers()->First();
30			if(!$dataTransfer) {
31			throw new LogicException('No transfer found');
32			}
33
34			$fileClass = File::get_class_for_file_extension(pathinfo($_FILES[$this->name]['name'], PATHINFO_EXTENSION));
35			$file = new $fileClass();
36			// Hack: loadIntoFile assumes paths relative to assets,
37			// otherwise it creates the whole structure within that folder
38			$absolutePath = $dataArchive->generateFilepath($dataTransfer);
39			$relativePath = preg_replace('#^' . preg_quote(ASSETS_PATH) . '/#', '', $absolutePath);
40			$this->upload->loadIntoFile($_FILES[$this->name], $file, $relativePath);
			0 ignored issues – show Documentation introduced 2015-11-24 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$relativePath` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41			if($this->upload->isError()) {
42			return false;
43			}
44
45			$file = $this->upload->getFile();
46			if($this->relationAutoSetting) {
47			// save to record
48			$record->{$this->name . 'ID'} = $file->ID;
49			}
50
51			return $this;
52			}
53			}
54

silverstripe / deploynaut

Issues (524)

Security Analysis not enabled

code/form/DataArchiveFileField.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like