Issues in DeploynautAPI.php (master) - Issues in master - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Issues (524)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/api/DeploynautAPI.php (2 issues)

Labels

Coding Style 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Class DeploynautAPI
 *
 * Entry point for the deploynaut API
 *
 * /naut/api/projectname/
 * /naut/api/projectname/environmentname
 *
 * @todo It might be good to break this out to a controller chain so that
 * "/naut/api/projectname/environmentname" controller chain becomes
 * DeploynautAPI > APIProject > APIEnvironment
 *
 */
class DeploynautAPI extends APINoun {


	/**
	 * Default URL handlers - (Action)/(ID)//(OtherID)
	 *
	 * @var array
	 */
	private static $url_handlers = array(
		'' => 'listProjects',
		'$Project//fetch' => 'project',
		'$Project/$Environment!' => 'environment',
		'$Project/' => 'project',
	);

	/**
	 * @var array
	 */
	public static $allowed_actions = array(
		'project',
		'environment',
		'listProjects'
	);

	/**
	 * @var string
	 */
	protected $link = 'deploynaut/api';

	/**
	 * @param \SS_HTTPRequest $request
	 * @return \SS_HTTPResponse
	 */
	public function listProjects(\SS_HTTPRequest $request) {
		$response = array(
			'href' => Director::absoluteURL($this->Link()),
			'projects' => array(),
		);

		if($request->httpMethod() != 'GET') {
			return $this->message('API not found', 404);
		}

		foreach(DNProject::get() as $item) {
			if($item->canView($this->getMember())) {
				$response['projects'][] = array(
					"name" => $item->Name,
					"href" => Director::absoluteURL($item->APILink("")),
				);
			}
		}

		return $this->getAPIResponse($response);
	}

	/**
	 * Controller Action
	 *
	 * @param \SS_HTTPRequest $request
	 * @return APIProject
	 */
	public function project(\SS_HTTPRequest $request) {
		$project = $this->getProject();
		if(!$project) {
			return $this->project404Response();
		}
		return new APIProject($this, $project);
	}

	/**
	 * Controller Action
	 *
	 * @param \SS_HTTPRequest $request
	 * @return APIEnvironment
	 */
	public function environment(\SS_HTTPRequest $request) {
		$project = $this->getProject();
		if(!$project) {
			return $this->project404Response();
		}

		$environment = $this->getEnvironment();
		if(!$environment) {
			return $this->environment404Response();
		}
		return new APIEnvironment($this, $environment);
	}

	/**
	 * @return SS_HTTPResponse
	 */
	protected function project404Response() {
		$projectName = Convert::raw2xml($this->getRequest()->latestParam('Project'));
		return new SS_HTTPResponse('Project "' . $projectName . '" not found.', 404);
	}

	/**
	 * @return SS_HTTPResponse
	 */
	protected function environment404Response() {
		$envName = Convert::raw2xml($this->getRequest()->latestParam('Environment'));
		return new SS_HTTPResponse('Environment "' . $envName . '" not found.', 404);
	}

	/**
	 * Get project from URL
	 *
	 * @return DNProject
	 */
	protected function getProject() {
		$projectName = $this->getRequest()->param('Project');
		return DNProject::get()->filter('Name', $projectName)->first();
	}

	/**
	 * Get environment from URL
	 *
	 * @return DNEnvironment
	 */
	protected function getEnvironment() {
		$projectName = $this->getRequest()->param('Project');
		$project = DNProject::get()->filter('Name', $projectName)->first();
		$environmentName = $this->getRequest()->param('Environment');
		return $project->Environments()->filter('Name', $environmentName)->first();
	}

	/**
	 * @return string
	 */
	public function Link() {
		return 'naut/api';
	}
}


1			<?php
2
3			/**
4			* Class DeploynautAPI
5			*
6			* Entry point for the deploynaut API
7			*
8			* /naut/api/projectname/
9			* /naut/api/projectname/environmentname
10			*
11			* @todo It might be good to break this out to a controller chain so that
12			* "/naut/api/projectname/environmentname" controller chain becomes
13			* DeploynautAPI > APIProject > APIEnvironment
14			*
15			*/
16			class DeploynautAPI extends APINoun {
			0 ignored issues – show Coding Style introduced 2016-09-09 01:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property $url_handlers is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history... Coding Style introduced 2016-09-09 01:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property $allowed_actions is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
17
18			/**
19			* Default URL handlers - (Action)/(ID)//(OtherID)
20			*
21			* @var array
22			*/
23			private static $url_handlers = array(
24			'' => 'listProjects',
25			'$Project//fetch' => 'project',
26			'$Project/$Environment!' => 'environment',
27			'$Project/' => 'project',
28			);
29
30			/**
31			* @var array
32			*/
33			public static $allowed_actions = array(
34			'project',
35			'environment',
36			'listProjects'
37			);
38
39			/**
40			* @var string
41			*/
42			protected $link = 'deploynaut/api';
43
44			/**
45			* @param \SS_HTTPRequest $request
46			* @return \SS_HTTPResponse
47			*/
48			public function listProjects(\SS_HTTPRequest $request) {
49			$response = array(
50			'href' => Director::absoluteURL($this->Link()),
51			'projects' => array(),
52			);
53
54			if($request->httpMethod() != 'GET') {
55			return $this->message('API not found', 404);
56			}
57
58			foreach(DNProject::get() as $item) {
59			if($item->canView($this->getMember())) {
60			$response['projects'][] = array(
61			"name" => $item->Name,
62			"href" => Director::absoluteURL($item->APILink("")),
63			);
64			}
65			}
66
67			return $this->getAPIResponse($response);
68			}
69
70			/**
71			* Controller Action
72			*
73			* @param \SS_HTTPRequest $request
74			* @return APIProject
75			*/
76			public function project(\SS_HTTPRequest $request) {
77			$project = $this->getProject();
78			if(!$project) {
79			return $this->project404Response();
80			}
81			return new APIProject($this, $project);
82			}
83
84			/**
85			* Controller Action
86			*
87			* @param \SS_HTTPRequest $request
88			* @return APIEnvironment
89			*/
90			public function environment(\SS_HTTPRequest $request) {
91			$project = $this->getProject();
92			if(!$project) {
93			return $this->project404Response();
94			}
95
96			$environment = $this->getEnvironment();
97			if(!$environment) {
98			return $this->environment404Response();
99			}
100			return new APIEnvironment($this, $environment);
101			}
102
103			/**
104			* @return SS_HTTPResponse
105			*/
106			protected function project404Response() {
107			$projectName = Convert::raw2xml($this->getRequest()->latestParam('Project'));
108			return new SS_HTTPResponse('Project "' . $projectName . '" not found.', 404);
109			}
110
111			/**
112			* @return SS_HTTPResponse
113			*/
114			protected function environment404Response() {
115			$envName = Convert::raw2xml($this->getRequest()->latestParam('Environment'));
116			return new SS_HTTPResponse('Environment "' . $envName . '" not found.', 404);
117			}
118
119			/**
120			* Get project from URL
121			*
122			* @return DNProject
123			*/
124			protected function getProject() {
125			$projectName = $this->getRequest()->param('Project');
126			return DNProject::get()->filter('Name', $projectName)->first();
127			}
128
129			/**
130			* Get environment from URL
131			*
132			* @return DNEnvironment
133			*/
134			protected function getEnvironment() {
135			$projectName = $this->getRequest()->param('Project');
136			$project = DNProject::get()->filter('Name', $projectName)->first();
137			$environmentName = $this->getRequest()->param('Environment');
138			return $project->Environments()->filter('Name', $environmentName)->first();
139			}
140
141			/**
142			* @return string
143			*/
144			public function Link() {
145			return 'naut/api';
146			}
147			}
148

silverstripe / deploynaut

Issues (524)

Security Analysis not enabled

code/api/DeploynautAPI.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like