DNDeploymentHandlers::onNew() - Code Metrics - Inspection of "Adding approval functionality" - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#681)

by Sean

created 2016-10-06 01:54 UTC

DNDeploymentHandlers::onNew() A

↳ Parent: DNDeploymentHandlers

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1

<?php

use \Finite\Event\TransitionEvent;

class DNDeploymentHandlers extends Object {
namespace YourVendor;

class YourClass { }

	public function onNew(TransitionEvent $e) {
		/** @var DNDeployment $deployment */
		$deployment = $e->getStateMachine()->getObject();
		$deployment->DeployRequested = null;
		$deployment->write();
	}

	public function onSubmit(TransitionEvent $e) {
		/** @var DNDeployment $deployment */
		$deployment = $e->getStateMachine()->getObject();
		$deployment->DeployRequested = SS_Datetime::now()->Rfc2822();
		$deployment->write();
		$this->sendEmailToApprover($deployment);
	}

	public function onApprove(TransitionEvent $e) {

		// @todo send email to requester that it's approved
	}

	public function onReject(TransitionEvent $e) {

		// @todo send email to requester that it's rejected
	}

	public function onQueue(TransitionEvent $e) {
		/** @var DNDeployment $deployment */
		$deployment = $e->getStateMachine()->getObject();

		$token = $deployment->enqueueDeployment();
		$deployment->setResqueToken($token);
		$deployment->DeployStarted = SS_Datetime::now()->Rfc2822();
		$deployment->write();

		$log = $deployment->log();
		$log->write(sprintf(
			'Deploy queued as job %s (sigFile is %s)',
			$token,
			$deployment->getSigFile()
		));
	}

	public function onAbort(TransitionEvent $e) {
		$deployment = $e->getStateMachine()->getObject();

		// 2 is SIGINT - we can't use SIGINT constant in the mod_apache context.
		$deployment->setSignal(2);
	}

	protected function sendEmailToApprover(DNDeployment $deployment) {
		$deployer = $deployment->Deployer();
		$approver = $deployment->Approver();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
		if (!$approver || !$approver->exists()) {
			return false;
		}

		$email = Email::create();
		$email->setTo(sprintf('%s <%s>', $approver->Name, $approver->Email));
		$email->replyTo(sprintf('%s <%s>', $deployer->Name, $deployer->Email));

		$email->setSubject('Deployment has been submitted');
		$email->setTemplate('DeploymentNotificationSubmitted');
		$email->populateTemplate($deployment);
		$email->send();

		$log = $deployment->log();
		$log->write(sprintf(
			'Deployment submitted email sent to approver %s <%s>',
			$approver->Name,
			$approver->Email
		));
	}
}


1			<?php
2
3			use \Finite\Event\TransitionEvent;
4
5			class DNDeploymentHandlers extends Object {
			0 ignored issues – show Coding Style Compatibility introduced 2016-09-09 01:22 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6
7			public function onNew(TransitionEvent $e) {
8			/** @var DNDeployment $deployment */
9			$deployment = $e->getStateMachine()->getObject();
10			$deployment->DeployRequested = null;
11			$deployment->write();
12			}
13
14			public function onSubmit(TransitionEvent $e) {
15			/** @var DNDeployment $deployment */
16			$deployment = $e->getStateMachine()->getObject();
17			$deployment->DeployRequested = SS_Datetime::now()->Rfc2822();
18			$deployment->write();
19			$this->sendEmailToApprover($deployment);
20			}
21
22			public function onApprove(TransitionEvent $e) {
			0 ignored issues – show Unused Code introduced 2016-10-04 02:48 UTC by Report Bug Copy Issue Report The parameter `$e` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
23			// @todo send email to requester that it's approved
24			}
25
26			public function onReject(TransitionEvent $e) {
			0 ignored issues – show Unused Code introduced 2016-10-04 02:48 UTC by Report Bug Copy Issue Report The parameter `$e` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
27			// @todo send email to requester that it's rejected
28			}
29
30			public function onQueue(TransitionEvent $e) {
31			/** @var DNDeployment $deployment */
32			$deployment = $e->getStateMachine()->getObject();
33
34			$token = $deployment->enqueueDeployment();
35			$deployment->setResqueToken($token);
36			$deployment->DeployStarted = SS_Datetime::now()->Rfc2822();
37			$deployment->write();
38
39			$log = $deployment->log();
40			$log->write(sprintf(
41			'Deploy queued as job %s (sigFile is %s)',
42			$token,
43			$deployment->getSigFile()
44			));
45			}
46
47			public function onAbort(TransitionEvent $e) {
48			$deployment = $e->getStateMachine()->getObject();
49
50			// 2 is SIGINT - we can't use SIGINT constant in the mod_apache context.
51			$deployment->setSignal(2);
52			}
53
54			protected function sendEmailToApprover(DNDeployment $deployment) {
55			$deployer = $deployment->Deployer();
56			$approver = $deployment->Approver();
			0 ignored issues – show Documentation Bug introduced 2016-08-02 02:00 UTC by Report Bug Copy Issue Report The method `Approver` does not exist on `object<DNDeployment>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
57			if (!$approver \|\| !$approver->exists()) {
58			return false;
59			}
60
61			$email = Email::create();
62			$email->setTo(sprintf('%s <%s>', $approver->Name, $approver->Email));
63			$email->replyTo(sprintf('%s <%s>', $deployer->Name, $deployer->Email));
			0 ignored issues – show Deprecated Code introduced 2016-08-02 02:00 UTC by Report Bug Copy Issue Report The method `Email::replyTo()` has been deprecated with message: 4.0 Use the "setReplyTo" method instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
64			$email->setSubject('Deployment has been submitted');
65			$email->setTemplate('DeploymentNotificationSubmitted');
66			$email->populateTemplate($deployment);
67			$email->send();
68
69			$log = $deployment->log();
70			$log->write(sprintf(
71			'Deployment submitted email sent to approver %s <%s>',
72			$approver->Name,
73			$approver->Email
74			));
75			}
76			}
77

silverstripe / deploynaut

Pull Request — master (#681)

DNDeploymentHandlers::onNew() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like