CreateEnvJob::perform() - Code Metrics - Inspection of "Log create exceptions" - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#672)

by Sean

created 2016-09-28 20:28 UTC

CreateEnvJob::perform() B

↳ Parent: CreateEnvJob

Complexity

Conditions	4
Paths	4

Size

Total Lines	23
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	8.7972
c	0
b	0
f	0
cc	4
eloc	14
nc	4
nop	0

<?php
class CreateEnvJob extends DeploynautJob {

	/**
	 *
	 * @var array
	 */
	public $args;

	/**
	 *
	 */
	public function setUp() {
		$this->updateStatus('Started');
		chdir(BASE_PATH);
	}

	/**
	 *
	 */
	public function perform() {
		echo "[-] CreateEnvJob starting" . PHP_EOL;

		$log = new DeploynautLogFile($this->args['logfile']);
		$envCreate = DNCreateEnvironment::get()->byId($this->args['createID']);

		// This is a bit icky, but there is no easy way of capturing a failed deploy by using the PHP Resque
		try {
			if(!($envCreate && $envCreate->exists())) {
				throw new RuntimeException(sprintf('Could not find create environment record %s', $args['createID']));
			}

			// This will throw and exception if it fails.
			$envCreate->createEnvironment();

		} catch(Exception $e) {
			$log->write($e->getMessage());
			echo "[-] CreateEnvJob failed" . PHP_EOL;
			throw $e;
		}
		$this->updateStatus('Finished');
		echo "[-] CreateEnvJob finished" . PHP_EOL;
	}

	/**
	 *
	 * @param string $status
	 * @global array $databaseConfig
	 */
	protected function updateStatus($status) {
		global $databaseConfig;
function myFunction($a, $b) {
    // Do something
}
		DB::connect($databaseConfig);

		$record = DNCreateEnvironment::get()->byID($this->args['createID']);
		$record->Status = $status;
		$record->write();
	}

	/**
	 *
	 * @return DNData
	 */
	protected function DNData() {
		return DNData::inst();
	}
}



1			<?php
2			class CreateEnvJob extends DeploynautJob {
3
4			/**
5			*
6			* @var array
7			*/
8			public $args;
9
10			/**
11			*
12			*/
13			public function setUp() {
14			$this->updateStatus('Started');
15			chdir(BASE_PATH);
16			}
17
18			/**
19			*
20			*/
21			public function perform() {
22			echo "[-] CreateEnvJob starting" . PHP_EOL;
23
24			$log = new DeploynautLogFile($this->args['logfile']);
25			$envCreate = DNCreateEnvironment::get()->byId($this->args['createID']);
26
27			// This is a bit icky, but there is no easy way of capturing a failed deploy by using the PHP Resque
28			try {
29			if(!($envCreate && $envCreate->exists())) {
30			throw new RuntimeException(sprintf('Could not find create environment record %s', $args['createID']));
31			}
32
33			// This will throw and exception if it fails.
34			$envCreate->createEnvironment();
35
36			} catch(Exception $e) {
37			$log->write($e->getMessage());
38			echo "[-] CreateEnvJob failed" . PHP_EOL;
39			throw $e;
40			}
41			$this->updateStatus('Finished');
42			echo "[-] CreateEnvJob finished" . PHP_EOL;
43			}
44
45			/**
46			*
47			* @param string $status
48			* @global array $databaseConfig
49			*/
50			protected function updateStatus($status) {
51			global $databaseConfig;
			0 ignored issues – show Compatibility Best Practice introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
52			DB::connect($databaseConfig);
53
54			$record = DNCreateEnvironment::get()->byID($this->args['createID']);
55			$record->Status = $status;
56			$record->write();
57			}
58
59			/**
60			*
61			* @return DNData
62			*/
63			protected function DNData() {
64			return DNData::inst();
65			}
66			}
67
68

silverstripe / deploynaut

Pull Request — master (#672)

CreateEnvJob::perform() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like