Completed
Push — master ( d37947...f5a873 )
by Mateusz
1297:50 queued 1294:31
created
code/model/DNData.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 	 */
82 82
 	public function setEnvironmentDir($environmentDir) {
83 83
 		if($environmentDir[0] != "/") {
84
-			$environmentDir = BASE_PATH . '/' . $environmentDir;
84
+			$environmentDir = BASE_PATH.'/'.$environmentDir;
85 85
 		}
86 86
 		$this->environmentDir = realpath($environmentDir) ?: $environmentDir;
87 87
 	}
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	 */
103 103
 	public function setKeyDir($keyDir) {
104 104
 		if($keyDir[0] != "/") {
105
-			$keyDir = BASE_PATH . '/' . $keyDir;
105
+			$keyDir = BASE_PATH.'/'.$keyDir;
106 106
 		}
107 107
 		$this->keyDir = realpath($keyDir) ?: $keyDir;
108 108
 	}
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 */
145 145
 	public function setDataTransferDir($transferDir) {
146 146
 		if($transferDir[0] != "/") {
147
-			$transferDir = BASE_PATH . '/' . $transferDir;
147
+			$transferDir = BASE_PATH.'/'.$transferDir;
148 148
 		}
149 149
 		if(strpos($transferDir, ASSETS_PATH) === false) {
150 150
 			throw new LogicException(sprintf(
@@ -174,14 +174,14 @@  discard block
 block discarded – undo
174 174
 	public function getProjectPaths() {
175 175
 		$paths = array();
176 176
 		if(!file_exists($this->getEnvironmentDir())) {
177
-			$eMessage = 'The environment directory ' . $this->getEnvironmentDir() . ' doesn\'t exist. Create it '
177
+			$eMessage = 'The environment directory '.$this->getEnvironmentDir().' doesn\'t exist. Create it '
178 178
 			. 'first and add some projects to it.';
179 179
 			throw new Exception($eMessage);
180 180
 		}
181 181
 		foreach(scandir($this->getEnvironmentDir()) as $project) {
182 182
 			// Exlcude dot-prefixed directories (.git was getting in the way)
183 183
 			if(preg_match('/^[^\.]/', $project)) {
184
-				$path = $this->getEnvironmentDir() . '/' . $project;
184
+				$path = $this->getEnvironmentDir().'/'.$project;
185 185
 				if(is_dir($path) && $project != '.' && $project != '..') {
186 186
 					$paths[] = $project;
187 187
 				}
@@ -196,11 +196,11 @@  discard block
 block discarded – undo
196 196
 	 * Returns an array of paths
197 197
 	 */
198 198
 	public function getEnvironmentPaths($project) {
199
-		$baseDir = $this->getEnvironmentDir() . '/' . $project;
199
+		$baseDir = $this->getEnvironmentDir().'/'.$project;
200 200
 
201 201
 		$paths = array();
202 202
 		if(!file_exists($baseDir)) {
203
-			throw new Exception('Environment directory ' . $baseDir . ' doesn\'t exist. Create it first.');
203
+			throw new Exception('Environment directory '.$baseDir.' doesn\'t exist. Create it first.');
204 204
 		}
205 205
 		// Search the directory for config files.
206 206
 		foreach(scandir($baseDir) as $environmentFile) {
Please login to merge, or discard this patch.
code/model/jobs/DNPing.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 	 * @return string
38 38
 	 */
39 39
 	public function LogLink() {
40
-		return $this->Link() . '/log';
40
+		return $this->Link().'/log';
41 41
 	}
42 42
 
43 43
 	/**
Please login to merge, or discard this patch.
code/model/jobs/DNDeployment.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	}
74 74
 
75 75
 	public function LogLink() {
76
-		return $this->Link() . '/log';
76
+		return $this->Link().'/log';
77 77
 	}
78 78
 
79 79
 	public function canView($member = null) {
@@ -205,12 +205,12 @@  discard block
 block discarded – undo
205 205
 	 */
206 206
 	public function getFullDeployMessages() {
207 207
 		$strategy = $this->getDeploymentStrategy();
208
-		if ($strategy->getActionCode()!=='full') return null;
208
+		if($strategy->getActionCode() !== 'full') return null;
209 209
 
210 210
 		$changes = $strategy->getChangesModificationNeeded();
211 211
 		$messages = [];
212
-		foreach ($changes as $change => $details) {
213
-			if ($change==='Code version') continue;
212
+		foreach($changes as $change => $details) {
213
+			if($change === 'Code version') continue;
214 214
 
215 215
 			$messages[] = [
216 216
 				'Flag' => sprintf(
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 			];
222 222
 		}
223 223
 
224
-		if (empty($messages)) {
224
+		if(empty($messages)) {
225 225
 			$messages[] = [
226 226
 				'Flag' => '',
227 227
 				'Text' => '<i>Environment changes have been made.</i>'
Please login to merge, or discard this patch.
code/model/jobs/DNDataTransfer.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	}
113 113
 
114 114
 	public function getTitle() {
115
-		return $this->dbObject('Created')->Nice() . " (Status: {$this->Status})";
115
+		return $this->dbObject('Created')->Nice()." (Status: {$this->Status})";
116 116
 	}
117 117
 
118 118
 	public function Link() {
@@ -233,14 +233,14 @@  discard block
 block discarded – undo
233 233
 		$envName = $this->Environment()->getFullName();
234 234
 		if($this->Direction == 'get') {
235 235
 			if($this->Origin == 'ManualUpload') {
236
-				$description = 'Manual upload of ' . $this->getModeNice() . ' to ' . $envName;
236
+				$description = 'Manual upload of '.$this->getModeNice().' to '.$envName;
237 237
 			} elseif($this->IsBackupDataTransfer()) {
238
-				$description = 'Automated backup of ' . $this->getModeNice() . ' from ' . $envName;
238
+				$description = 'Automated backup of '.$this->getModeNice().' from '.$envName;
239 239
 			} else {
240
-				$description = 'Backup of ' . $this->getModeNice() . ' to ' . $envName;
240
+				$description = 'Backup of '.$this->getModeNice().' to '.$envName;
241 241
 			}
242 242
 		} else {
243
-			$description = 'Restore ' . $this->getModeNice() . ' to ' . $envName;
243
+			$description = 'Restore '.$this->getModeNice().' to '.$envName;
244 244
 		}
245 245
 
246 246
 		return $description;
Please login to merge, or discard this patch.
code/model/jobs/DNCreateEnvironment.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 	 * @return string
69 69
 	 */
70 70
 	public function LogLink() {
71
-		return $this->Link() . '/log';
71
+		return $this->Link().'/log';
72 72
 	}
73 73
 
74 74
 	/**
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 			if($env instanceof EnvironmentCreateBackend) {
191 191
 				return $env;
192 192
 			} else {
193
-				throw new Exception("Invalid backend: " . $data['EnvironmentType']);
193
+				throw new Exception("Invalid backend: ".$data['EnvironmentType']);
194 194
 			}
195 195
 		}
196 196
 		return null;
Please login to merge, or discard this patch.
code/control/DeploynautLogFile.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	 * @return string
40 40
 	 */
41 41
 	public function getRawFilePath() {
42
-		return $this->basePath . '/' . $this->logFile;
42
+		return $this->basePath.'/'.$this->logFile;
43 43
 	}
44 44
 
45 45
 	/**
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 	 * @return string
48 48
 	 */
49 49
 	public function getSanitisedLogFilePath() {
50
-		return $this->basePath . '/' . strtolower(FileNameFilter::create()->filter($this->logFile));
50
+		return $this->basePath.'/'.strtolower(FileNameFilter::create()->filter($this->logFile));
51 51
 	}
52 52
 
53 53
 	/**
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 		// Make sure we write into the old path for existing logs. New logs use the sanitised file path instead.
78 78
 		$path = file_exists($this->getRawFilePath()) ? $this->getRawFilePath() : $this->getSanitisedLogFilePath();
79 79
 
80
-		error_log('['.date('Y-m-d H:i:s').'] ' . $message .PHP_EOL, 3, $path);
80
+		error_log('['.date('Y-m-d H:i:s').'] '.$message.PHP_EOL, 3, $path);
81 81
 		@chmod($path, 0666);
82 82
 	}
83 83
 
Please login to merge, or discard this patch.
code/control/CheckPipelineStatus.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 
25 25
 		printf(
26 26
 			"%s Checking status of %d pipelines... ",
27
-			"[" . date("Y-m-d H:i:s") . "]",
27
+			"[".date("Y-m-d H:i:s")."]",
28 28
 			$runningPipelines->count()
29 29
 		);
30 30
 
@@ -32,6 +32,6 @@  discard block
 block discarded – undo
32 32
 			$pipeline->checkPipelineStatus();
33 33
 		}
34 34
 
35
-		echo "done!" . PHP_EOL;
35
+		echo "done!".PHP_EOL;
36 36
 	}
37 37
 }
Please login to merge, or discard this patch.
code/control/DeployForm.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 		if(!preg_match('/^[a-f0-9]{40}$/', $sha)) {
42 42
 			$this->validationError(
43 43
 				$field,
44
-				"Invalid release SHA: " . Convert::raw2xml($sha),
44
+				"Invalid release SHA: ".Convert::raw2xml($sha),
45 45
 				"error"
46 46
 			);
47 47
 			return false;
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 
166 166
 		// Generate actions allowed for this user
167 167
 		$actions = new FieldList(
168
-			FormAction::create('startPipeline', "Begin the release process on " . $environment->Name)
168
+			FormAction::create('startPipeline', "Begin the release process on ".$environment->Name)
169 169
 				->addExtraClass('btn btn-primary')
170 170
 				->setAttribute('onclick', "return confirm('This will begin a release pipeline. Continue?');")
171 171
 		);
@@ -175,9 +175,9 @@  discard block
 block discarded – undo
175 175
 					->addExtraClass('btn btn-info')
176 176
 					->setAttribute(
177 177
 						'onclick',
178
-						"return confirm('This will begin a release pipeline, but with the following exclusions:\\n" .
179
-						" - No messages will be sent\\n" .
180
-						" - No capistrano actions will be invoked\\n" .
178
+						"return confirm('This will begin a release pipeline, but with the following exclusions:\\n".
179
+						" - No messages will be sent\\n".
180
+						" - No capistrano actions will be invoked\\n".
181 181
 						" - No deployments or snapshots will be created.');"
182 182
 					)
183 183
 			);
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 					->addExtraClass('btn btn-warning')
189 189
 					->setAttribute(
190 190
 						'onclick',
191
-						"return confirm('This will start a direct deployment, bypassing the pipeline " .
191
+						"return confirm('This will start a direct deployment, bypassing the pipeline ".
192 192
 						"process in place.\\n\\nAre you sure this is necessary?');"
193 193
 					)
194 194
 			);
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 				substr($sha, 0, 8),
216 216
 				$branch->LastUpdated()->TimeDiff()
217 217
 			);
218
-			$branches[$sha . '-' . $name] = $branchValue;
218
+			$branches[$sha.'-'.$name] = $branchValue;
219 219
 		}
220 220
 
221 221
 		// Tags
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
 				substr($sha, 0, 8),
229 229
 				$branch->LastUpdated()->TimeDiff()
230 230
 			);
231
-			$tags[$sha . '-' . $tag] = $tagValue;
231
+			$tags[$sha.'-'.$tag] = $tagValue;
232 232
 		}
233 233
 		$tags = array_reverse($tags);
234 234
 
Please login to merge, or discard this patch.
code/form/DataArchiveFileField.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 		// Hack: loadIntoFile assumes paths relative to assets,
37 37
 		//  otherwise it creates the whole structure *within* that folder
38 38
 		$absolutePath = $dataArchive->generateFilepath($dataTransfer);
39
-		$relativePath = preg_replace('#^' . preg_quote(ASSETS_PATH) . '/#', '', $absolutePath);
39
+		$relativePath = preg_replace('#^'.preg_quote(ASSETS_PATH).'/#', '', $absolutePath);
40 40
 		$this->upload->loadIntoFile($_FILES[$this->name], $file, $relativePath);
41 41
 		if($this->upload->isError()) {
42 42
 			return false;
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 		$file = $this->upload->getFile();
46 46
 		if($this->relationAutoSetting) {
47 47
 			// save to record
48
-			$record->{$this->name . 'ID'} = $file->ID;
48
+			$record->{$this->name.'ID'} = $file->ID;
49 49
 		}
50 50
 
51 51
 		return $this;
Please login to merge, or discard this patch.