Completed
Pull Request — master (#852)
by Stig
05:04 queued 01:26
created
code/backends/DeploymentStrategy.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -75,6 +75,7 @@  discard block
 block discarded – undo
75 75
 	}
76 76
 
77 77
 	/**
78
+	 * @param string $code
78 79
 	 */
79 80
 	public function setActionCode($code) {
80 81
 		$this->actionCode = $code;
@@ -89,6 +90,7 @@  discard block
 block discarded – undo
89 90
 
90 91
 	/**
91 92
 	 * @param int
93
+	 * @param string $seconds
92 94
 	 */
93 95
 	public function setEstimatedTime($seconds) {
94 96
 		$this->estimatedTime = $seconds;
Please login to merge, or discard this patch.
code/control/DNRoot.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -961,7 +961,7 @@
 block discarded – undo
961 961
 	 * @param array $data
962 962
 	 * @param Form $form
963 963
 	 *
964
-	 * @return bool|HTMLText|SS_HTTPResponse
964
+	 * @return SS_HTTPResponse|null
965 965
 	 */
966 966
 	public function doCreateEnvironment($data, Form $form) {
967 967
 		$this->setCurrentActionType(self::ACTION_ENVIRONMENTS);
Please login to merge, or discard this patch.
code/control/DeployDispatcher.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 	 *
47 47
 	 * @param \SS_HTTPRequest $request
48 48
 	 *
49
-	 * @return \HTMLText|\SS_HTTPResponse
49
+	 * @return SS_HTTPResponse|null
50 50
 	 */
51 51
 	public function index(\SS_HTTPRequest $request) {
52 52
 		return $this->redirect(\Controller::join_links($this->Link(), 'history'), 302);
Please login to merge, or discard this patch.
code/control/GitDispatcher.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 	 *
48 48
 	 * @param \SS_HTTPRequest $request
49 49
 	 *
50
-	 * @return \HTMLText|\SS_HTTPResponse
50
+	 * @return SS_HTTPResponse|null
51 51
 	 */
52 52
 	public function index(\SS_HTTPRequest $request) {
53 53
 		return $this->redirect(\Controller::join_links($this->Link(), 'show'), 302);
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	/**
73 73
 	 * @param SS_HTTPRequest $request
74 74
 	 *
75
-	 * @return string
75
+	 * @return SS_HTTPResponse
76 76
 	 */
77 77
 	public function show(\SS_HTTPRequest $request) {
78 78
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 	}
167 167
 
168 168
 	/**
169
-	 * @param $project
169
+	 * @param DNProject $project
170 170
 	 *
171 171
 	 * @return array
172 172
 	 */
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 	}
183 183
 
184 184
 	/**
185
-	 * @param $project
185
+	 * @param DNProject $project
186 186
 	 *
187 187
 	 * @return array
188 188
 	 */
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 	}
199 199
 
200 200
 	/**
201
-	 * @param $project
201
+	 * @param DNProject $project
202 202
 	 *
203 203
 	 * @return array
204 204
 	 */
Please login to merge, or discard this patch.
code/model/jobs/DNDeployment.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -82,6 +82,9 @@
 block discarded – undo
82 82
 		'Deployer.Name' => 'Deployer'
83 83
 	);
84 84
 
85
+	/**
86
+	 * @param false|string $token
87
+	 */
85 88
 	public function setResqueToken($token) {
86 89
 		$this->ResqueToken = $token;
87 90
 	}
Please login to merge, or discard this patch.
code/SS_Datetimezone.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -6,8 +6,8 @@
 block discarded – undo
6 6
  */
7 7
 class SS_Datetimezone extends SS_Datetime {
8 8
 	/**
9
-	* Returns the date in the raw SQL-format specific to a given timezone passed from the Member class, e.g. “2006-01-18 16:32:04”
10
-	*/
9
+	 * Returns the date in the raw SQL-format specific to a given timezone passed from the Member class, e.g. “2006-01-18 16:32:04”
10
+	 */
11 11
 	public function Nice() {
12 12
 		//instantiate new DateTime object based off received timestamp in the default timezone
13 13
 		$timestamp = new DateTime($this->value, new DateTimeZone(date_default_timezone_get()));
Please login to merge, or discard this patch.
code/model/DNEnvironment.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -670,7 +670,7 @@
 block discarded – undo
670 670
 	/**
671 671
 	 * A list of past deployments.
672 672
 	 * @param string $orderBy - the name of a DB column to sort in descending order
673
-	 * @return \ArrayList
673
+	 * @return DataList
674 674
 	 */
675 675
 	public function DeployHistory($orderBy = '') {
676 676
 		$sort = [];
Please login to merge, or discard this patch.
code/api/DeploynautAPIFormatter.php 1 patch
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -117,7 +117,6 @@
 block discarded – undo
117 117
 
118 118
 	/**
119 119
 	 * Return data about a particular {@link Member} of the stack for use in API response.
120
-
121 120
 	 * Notes:
122 121
 	 * 1) This method returns null instead of an array if the member doesn't exists anymore
123 122
 	 * 2) 'role' can be null in the response. This is the case of an admin, or an operations
Please login to merge, or discard this patch.