Completed
Pull Request — master (#518)
by Michael
03:38
created
code/model/jobs/DNDeployment.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -201,12 +201,12 @@  discard block
 block discarded – undo
201 201
 	 */
202 202
 	public function getFullDeployMessages() {
203 203
 		$strategy = $this->getDeploymentStrategy();
204
-		if ($strategy->getActionCode()!=='full') return null;
204
+		if($strategy->getActionCode() !== 'full') return null;
205 205
 
206 206
 		$changes = $strategy->getChangesModificationNeeded();
207 207
 		$messages = [];
208
-		foreach ($changes as $change => $details) {
209
-			if ($change==='Code version') continue;
208
+		foreach($changes as $change => $details) {
209
+			if($change === 'Code version') continue;
210 210
 
211 211
 			$messages[] = [
212 212
 				'Flag' => sprintf(
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
 			];
218 218
 		}
219 219
 
220
-		if (empty($messages)) {
220
+		if(empty($messages)) {
221 221
 			$messages[] = [
222 222
 				'Flag' => '',
223 223
 				'Text' => '<i>Environment changes have been made.</i>'
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -201,12 +201,16 @@  discard block
 block discarded – undo
201 201
 	 */
202 202
 	public function getFullDeployMessages() {
203 203
 		$strategy = $this->getDeploymentStrategy();
204
-		if ($strategy->getActionCode()!=='full') return null;
204
+		if ($strategy->getActionCode()!=='full') {
205
+			return null;
206
+		}
205 207
 
206 208
 		$changes = $strategy->getChangesModificationNeeded();
207 209
 		$messages = [];
208 210
 		foreach ($changes as $change => $details) {
209
-			if ($change==='Code version') continue;
211
+			if ($change==='Code version') {
212
+				continue;
213
+			}
210 214
 
211 215
 			$messages[] = [
212 216
 				'Flag' => sprintf(
@@ -260,7 +264,9 @@  discard block
 block discarded – undo
260 264
 		$list = new ArrayList();
261 265
 		$strategy = $this->getDeploymentStrategy();
262 266
 		foreach($strategy->getChanges() as $name => $change) {
263
-			if(empty($change['to'])) continue;
267
+			if(empty($change['to'])) {
268
+				continue;
269
+			}
264 270
 
265 271
 			$list->push(new ArrayData([
266 272
 				'Name' => $name,
Please login to merge, or discard this patch.
code/model/steps/SmokeTestPipelineStep.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
 		curl_setopt($ch, CURLOPT_URL, $test['URL']);
128 128
 
129 129
 		// Allow individual tests to override number of attempts
130
-		$attempts = (int) $this->getConfigSetting('Attempts');
130
+		$attempts = (int)$this->getConfigSetting('Attempts');
131 131
 		if(!empty($test['Attempts'])) {
132 132
 			$attempts = $test['Attempts'];
133 133
 		}
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -282,7 +282,7 @@
 block discarded – undo
282 282
 	 */
283 283
 	public function startApproval() {
284 284
 		$this->Status = 'Started';
285
-		$this->log("Starting {$this->Title}...");
285
+		$this->log("starting {$this->Title}...");
286 286
 		// Determine if we should use delayed notification
287 287
 		$recipientGroup = 'all';
288 288
 		if($this->getConfigSetting('RecipientsDelay')) {
Please login to merge, or discard this patch.
code/model/steps/UserConfirmationStep.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -282,7 +282,7 @@
 block discarded – undo
282 282
 	 */
283 283
 	public function startApproval() {
284 284
 		$this->Status = 'Started';
285
-		$this->log("Starting {$this->Title}...");
285
+		$this->log("starting {$this->Title}...");
286 286
 		// Determine if we should use delayed notification
287 287
 		$recipientGroup = 'all';
288 288
 		if($this->getConfigSetting('RecipientsDelay')) {
Please login to merge, or discard this patch.
code/tasks/DNMigrate1_1to1_2.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Will convert the Filename to the version 1.2 of deploynaut where it
4
- * more or less is exactly is the same as the Name but with .rb
5
- */
3
+	 * Will convert the Filename to the version 1.2 of deploynaut where it
4
+	 * more or less is exactly is the same as the Name but with .rb
5
+	 */
6 6
 class DNMigrate1_1to1_2 extends BuildTask {
7 7
 	/**
8 8
 	 * @param SS_HTTPRequest $request
Please login to merge, or discard this patch.
code/tasks/FilesystemSyncTask.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Surface Filesystem::sync() as a dev task in case CMS has not been included.
4
- */
3
+	 * Surface Filesystem::sync() as a dev task in case CMS has not been included.
4
+	 */
5 5
 class CMSFilesystemSyncTask extends BuildTask {
6 6
 	public function run($request = null) {
7 7
 		Filesystem::sync();
Please login to merge, or discard this patch.
code/model/steps/TriggerDeployStep.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -282,7 +282,7 @@
 block discarded – undo
282 282
 	 */
283 283
 	public function startApproval() {
284 284
 		$this->Status = 'Started';
285
-		$this->log("Starting {$this->Title}...");
285
+		$this->log("starting {$this->Title}...");
286 286
 		// Determine if we should use delayed notification
287 287
 		$recipientGroup = 'all';
288 288
 		if($this->getConfigSetting('RecipientsDelay')) {
Please login to merge, or discard this patch.
code/model/jobs/DNPing.php 1 patch
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,14 +1,14 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This class will queue a ping job and also proxy to the log file of that output
4
- *
5
- * @property string $ResqueToken
6
- *
7
- * @method DNEnvironment Environment()
8
- * @property int EnvironmentID
9
- * @method Member Deployer()
10
- * @property int DeployerID
11
- */
3
+	 * This class will queue a ping job and also proxy to the log file of that output
4
+	 *
5
+	 * @property string $ResqueToken
6
+	 *
7
+	 * @method DNEnvironment Environment()
8
+	 * @property int EnvironmentID
9
+	 * @method Member Deployer()
10
+	 * @property int DeployerID
11
+	 */
12 12
 class DNPing extends DataObject {
13 13
 
14 14
 	/**
Please login to merge, or discard this patch.