Inspection of "Remove unncessary fetch of upcoming deployments" - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

deploynaut

Completed

Pull Request — master (#757)

by Stig

created 2016-11-07 02:00 UTC

Status

All Patches
66
New
3

Braces +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -685,7 +685,7 @@
 block discarded – undo
 			->where('"SHA" IS NOT NULL')
 			->sort($sort);
 
-		if($this->IsNewDeployEnabled()){
+		if($this->IsNewDeployEnabled()) {
 			$deployments->filter('State', [
 				DNDeployment::STATE_COMPLETED,
 				DNDeployment::STATE_FAILED,

Please login to merge, or discard this patch.

		@@ -685,7 +685,7 @@
		block discarded – undo
685	685	->where('"SHA" IS NOT NULL')
686	686	->sort($sort);
687	687
688		- if($this->IsNewDeployEnabled()){
	688	+ if($this->IsNewDeployEnabled()) {
689	689	$deployments->filter('State', [
690	690	DNDeployment::STATE_COMPLETED,
691	691	DNDeployment::STATE_FAILED,

silverstripe / deploynaut

Pull Request — master (#757)

Status

Category

Braces +1 added lines, -1 removed lines patch added patch discarded remove patch