ApprovalsDispatcher::reject() - Code Metrics - Inspection of "[wip] Adding approval functionality" - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#681)

by Sean

created 2016-10-05 00:53 UTC

ApprovalsDispatcher::reject() B

↳ Parent: ApprovalsDispatcher

Complexity

Conditions	5
Paths	5

Size

Total Lines	30
Code Lines	21

Duplication

Lines	30
Ratio	100 %

Importance

Changes

Metric	Value
dl	30
loc	30
rs	8.439
c	0
b	0
f	0
cc	5
eloc	21
nc	5
nop	1

<?php

class ApprovalsDispatcher extends Dispatcher {
namespace YourVendor;

class YourClass { }

	const ACTION_APPROVALS = 'approvals';

	const ALLOW_APPROVAL = 'ALLOW_APPROVAL';

	/**
	 * @var array
	 */
	public static $allowed_actions = [
		'approvers',
		'submit',
		'cancel',
		'approve',
		'reject'
	];

	/**
	 * @var \DNProject
	 */
	protected $project = null;

	/**
	 * @var \DNEnvironment
	 */
	protected $environment = null;

	/**
	 * @var array
	 */
	private static $action_types = [

		self::ACTION_APPROVALS
	];

	/**
	 * This is a per request cache of $this->project()->listMembers()
	 * @var null|array
	 */
	private static $_cache_project_members = null;

	public function init() {

		parent::init();

		$this->project = $this->getCurrentProject();
		if (!$this->project) {
			return $this->project404Response();
		}

		// Performs canView permission check by limiting visible projects
		$this->environment = $this->getCurrentEnvironment($this->project);
		if (!$this->environment) {
			return $this->environment404Response();
		}
	}

	/**
	 * @param \SS_HTTPRequest $request
	 * @return \SS_HTTPResponse
	 */
	public function approvers(SS_HTTPRequest $request) {
		$list = [];

		if (self::$_cache_project_members === null) {
			self::$_cache_project_members = $this->project->listMembers();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
		}

		foreach (self::$_cache_project_members as $data) {
			if ($this->project->allowed(self::ALLOW_APPROVAL, Member::get()->byId($data['MemberID']))) {

				$list[] = [
					'id' => $data['MemberID'],
					'email' => $data['Email'],
					'role' => $data['RoleTitle'],
					'name' => $data['FullName']
				];
			}
		}

		return $this->getAPIResponse([
			'approvers' => $list
		], 200);
	}

	/**
	 * @param \SS_HTTPRequest $request
	 * @return \SS_HTTPResponse
	 */
	public function submit(SS_HTTPRequest $request) {
		if ($request->httpMethod() !== 'POST') {
			return $this->getAPIResponse(['message' => 'Method not allowed, requires POST'], 405);
		}

		$deployment = DNDeployment::get()->byId($request->postVar('id'));
		$errorResponse = $this->validateDeployment($deployment);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		if ($errorResponse instanceof \SS_HTTPResponse) {
			return $errorResponse;
		}

		$approver = Member::get()->byId($request->postVar('approver_id'));
		if (!$approver || !$approver->exists()) {
			return $this->getAPIResponse(['message' => 'Invalid approver. Does not exist'], 403);
		}
		if (!$this->project->allowed(self::ALLOW_APPROVAL, $approver)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			return $this->getAPIResponse(['message' => 'The given approver does not have permissions to approve'], 403);
		}

		try {
			$deployment->ApproverID = $approver->ID;
			$deployment->write();

			$deployment->getMachine()->apply(DNDeployment::TR_SUBMIT);
		} catch (\Exception $e) {
			return $this->getAPIResponse([
				'status' => 'FAILED',
				'message' => $e->getMessage()
			], 400);
		}

		return $this->getAPIResponse([
			'status' => 'OK',
			'id' => $deployment->ID,
			'new_status' => DNDeployment::STATE_SUBMITTED
		], 200);
	}

	/**
	 * @param \SS_HTTPRequest $request
	 * @return \SS_HTTPResponse
	 */
	public function cancel(SS_HTTPRequest $request) {
		if ($request->httpMethod() !== 'POST') {
			return $this->getAPIResponse(['message' => 'Method not allowed, requires POST'], 405);
		}

		$deployment = DNDeployment::get()->byId($request->postVar('id'));
		$errorResponse = $this->validateDeployment($deployment);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		if ($errorResponse instanceof \SS_HTTPResponse) {
			return $errorResponse;
		}

		// @todo permission checking for cancelling an approval request

		try {
			$deployment->getMachine()->apply(DNDeployment::TR_NEW);
		} catch (\Exception $e) {
			return $this->getAPIResponse([
				'status' => 'FAILED',
				'message' => $e->getMessage()
			], 400);
		}

		return $this->getAPIResponse([
			'status' => 'OK',
			'id' => $deployment->ID,
			'new_status' => DNDeployment::STATE_NEW
		], 200);
	}

	/**
	 * @param \SS_HTTPRequest $request
	 * @return \SS_HTTPResponse
	 */
	public function approve(SS_HTTPRequest $request) {

		if ($request->httpMethod() !== 'POST') {
			return $this->getAPIResponse(['message' => 'Method not allowed, requires POST'], 405);
		}

		$deployment = DNDeployment::get()->byId($request->postVar('id'));
		$errorResponse = $this->validateDeployment($deployment);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		if ($errorResponse instanceof \SS_HTTPResponse) {
			return $errorResponse;
		}

		if (!$this->project->allowed(self::ALLOW_APPROVAL, Member::currentUser())) {

			return $this->getAPIResponse(['message' => 'You are not authorised to approve this deployment'], 403);
		}

		try {
			$deployment->getMachine()->apply(DNDeployment::TR_APPROVE);
		} catch (\Exception $e) {
			return $this->getAPIResponse([
				'status' => 'FAILED',
				'message' => $e->getMessage()
			], 400);
		}

		return $this->getAPIResponse([
			'status' => 'OK',
			'id' => $deployment->ID,
			'new_status' => DNDeployment::STATE_APPROVED
		], 200);
	}

	/**
	 * @param \SS_HTTPRequest $request
	 * @return \SS_HTTPResponse
	 */
	public function reject(SS_HTTPRequest $request) {

		if ($request->httpMethod() !== 'POST') {
			return $this->getAPIResponse(['message' => 'Method not allowed, requires POST'], 405);
		}

		$deployment = DNDeployment::get()->byId($request->postVar('id'));
		$errorResponse = $this->validateDeployment($deployment);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		if ($errorResponse instanceof \SS_HTTPResponse) {
			return $errorResponse;
		}
		// reject permissions are the same as can approve
		if (!$this->project->allowed(self::ALLOW_APPROVAL, Member::currentUser())) {

			return $this->getAPIResponse(['message' => 'You are not authorised to reject this deployment'], 403);
		}

		try {
			$deployment->getMachine()->apply(DNDeployment::TR_REJECT);
		} catch (\Exception $e) {
			return $this->getAPIResponse([
				'status' => 'FAILED',
				'message' => $e->getMessage()
			], 400);
		}

		return $this->getAPIResponse([
			'status' => 'OK',
			'id' => $deployment->ID,
			'new_status' => DNDeployment::STATE_REJECTED
		], 200);
	}

	/**
	 * Check if a DNDeployment exists and do permission checks on it. If there is something wrong it will return
	 * an APIResponse with the error, otherwise null.
	 *
	 * @param \DNDeployment $deployment
	 *
	 * @return null|SS_HTTPResponse
	 */
	protected function validateDeployment(\DNDeployment $deployment) {

		if (!$deployment || !$deployment->exists()) {
			return $this->getAPIResponse(['message' => 'This deployment does not exist'], 404);
		}
		if ($deployment->EnvironmentID != $this->environment->ID) {
			return $this->getAPIResponse(['message' => 'This deployment does not belong to the environment'], 403);
		}
		if (!$deployment->canView()) {
			return $this->getAPIResponse(['message' => 'You are not authorised to view this deployment'], 403);
		}
		return null;
	}

	/**
	 * @return ArrayList
	 */
	protected function getApprovers() {
		$list = new ArrayList();
		if (self::$_cache_project_members === null) {
			self::$_cache_project_members = $this->project->listMembers();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
		}
		foreach (self::$_cache_project_members as $data) {
			$list->push(new ArrayData([
				'ID' => $member->ID,

				'Role' => $data['RoleTitle']
			]));
		}
		return $list;
	}

	/**
	 * @param string $name
	 * @return array
	 */
	public function getModel($name = '') {
		return [];
	}

	/**
	 * @param string $action
	 * @return string
	 */
	public function Link($action = '') {
		return \Controller::join_links($this->environment->Link(), self::ACTION_APPROVALS, $action);
	}

}


1		<?php
2
3		class ApprovalsDispatcher extends Dispatcher {
		0 ignored issues – show Coding Style introduced 2016-10-04 02:48 UTC by Report Bug Copy Issue Report The property $allowed_actions is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history... Coding Style introduced 2016-10-04 02:48 UTC by Report Bug Copy Issue Report The property $action_types is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history... Coding Style Compatibility introduced 2016-10-04 02:48 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history... Coding Style introduced 2016-10-04 03:13 UTC by Report Bug Copy Issue Report The property $_cache_project_members is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
4
5		const ACTION_APPROVALS = 'approvals';
6
7		const ALLOW_APPROVAL = 'ALLOW_APPROVAL';
8
9		/**
10		* @var array
11		*/
12		public static $allowed_actions = [
13		'approvers',
14		'submit',
15		'cancel',
16		'approve',
17		'reject'
18		];
19
20		/**
21		* @var \DNProject
22		*/
23		protected $project = null;
24
25		/**
26		* @var \DNEnvironment
27		*/
28		protected $environment = null;
29
30		/**
31		* @var array
32		*/
33		private static $action_types = [
		0 ignored issues – show Comprehensibility introduced 2016-10-04 02:48 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-10-04 02:48 UTC by Report Bug Copy Issue Report The property `$action_types` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
34		self::ACTION_APPROVALS
35		];
36
37		/**
38		* This is a per request cache of $this->project()->listMembers()
39		* @var null\|array
40		*/
41		private static $_cache_project_members = null;
42
43	View Code Duplication	public function init() {
		0 ignored issues – show Duplication introduced 2016-10-04 03:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		parent::init();
45
46		$this->project = $this->getCurrentProject();
47		if (!$this->project) {
48		return $this->project404Response();
49		}
50
51		// Performs canView permission check by limiting visible projects
52		$this->environment = $this->getCurrentEnvironment($this->project);
53		if (!$this->environment) {
54		return $this->environment404Response();
55		}
56		}
57
58		/**
59		* @param \SS_HTTPRequest $request
60		* @return \SS_HTTPResponse
61		*/
62		public function approvers(SS_HTTPRequest $request) {
63		$list = [];
64
65		if (self::$_cache_project_members === null) {
66		self::$_cache_project_members = $this->project->listMembers();
		0 ignored issues – show Documentation Bug introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report The method `listMembers` does not exist on `object<DNProject>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
67		}
68
69		foreach (self::$_cache_project_members as $data) {
70		if ($this->project->allowed(self::ALLOW_APPROVAL, Member::get()->byId($data['MemberID']))) {
		0 ignored issues – show Bug introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report It seems like `\Member::get()->byId($data['MemberID'])` targeting `DataList::byID()` can also be of type `object<DataObject>`; however, `DNProject::allowed()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
71		$list[] = [
72		'id' => $data['MemberID'],
73		'email' => $data['Email'],
74		'role' => $data['RoleTitle'],
75		'name' => $data['FullName']
76		];
77		}
78		}
79
80		return $this->getAPIResponse([
81		'approvers' => $list
82		], 200);
83		}
84
85		/**
86		* @param \SS_HTTPRequest $request
87		* @return \SS_HTTPResponse
88		*/
89		public function submit(SS_HTTPRequest $request) {
90		if ($request->httpMethod() !== 'POST') {
91		return $this->getAPIResponse(['message' => 'Method not allowed, requires POST'], 405);
92		}
93
94		$deployment = DNDeployment::get()->byId($request->postVar('id'));
95		$errorResponse = $this->validateDeployment($deployment);
		0 ignored issues – show Documentation introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report `$deployment` is of type `object<DataObject>\|null`, but the function expects a `object<DNDeployment>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
96		if ($errorResponse instanceof \SS_HTTPResponse) {
97		return $errorResponse;
98		}
99
100		$approver = Member::get()->byId($request->postVar('approver_id'));
101		if (!$approver \|\| !$approver->exists()) {
102		return $this->getAPIResponse(['message' => 'Invalid approver. Does not exist'], 403);
103		}
104		if (!$this->project->allowed(self::ALLOW_APPROVAL, $approver)) {
		0 ignored issues – show Documentation introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report `$approver` is of type `object<DataObject>`, but the function expects a `object<Member>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
105		return $this->getAPIResponse(['message' => 'The given approver does not have permissions to approve'], 403);
106		}
107
108		try {
109		$deployment->ApproverID = $approver->ID;
110		$deployment->write();
111
112		$deployment->getMachine()->apply(DNDeployment::TR_SUBMIT);
113		} catch (\Exception $e) {
114		return $this->getAPIResponse([
115		'status' => 'FAILED',
116		'message' => $e->getMessage()
117		], 400);
118		}
119
120		return $this->getAPIResponse([
121		'status' => 'OK',
122		'id' => $deployment->ID,
123		'new_status' => DNDeployment::STATE_SUBMITTED
124		], 200);
125		}
126
127		/**
128		* @param \SS_HTTPRequest $request
129		* @return \SS_HTTPResponse
130		*/
131		public function cancel(SS_HTTPRequest $request) {
132		if ($request->httpMethod() !== 'POST') {
133		return $this->getAPIResponse(['message' => 'Method not allowed, requires POST'], 405);
134		}
135
136		$deployment = DNDeployment::get()->byId($request->postVar('id'));
137		$errorResponse = $this->validateDeployment($deployment);
		0 ignored issues – show Documentation introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report `$deployment` is of type `object<DataObject>\|null`, but the function expects a `object<DNDeployment>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
138		if ($errorResponse instanceof \SS_HTTPResponse) {
139		return $errorResponse;
140		}
141
142		// @todo permission checking for cancelling an approval request
143
144		try {
145		$deployment->getMachine()->apply(DNDeployment::TR_NEW);
146		} catch (\Exception $e) {
147		return $this->getAPIResponse([
148		'status' => 'FAILED',
149		'message' => $e->getMessage()
150		], 400);
151		}
152
153		return $this->getAPIResponse([
154		'status' => 'OK',
155		'id' => $deployment->ID,
156		'new_status' => DNDeployment::STATE_NEW
157		], 200);
158		}
159
160		/**
161		* @param \SS_HTTPRequest $request
162		* @return \SS_HTTPResponse
163		*/
164	View Code Duplication	public function approve(SS_HTTPRequest $request) {
		0 ignored issues – show Duplication introduced 2016-10-04 02:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
165		if ($request->httpMethod() !== 'POST') {
166		return $this->getAPIResponse(['message' => 'Method not allowed, requires POST'], 405);
167		}
168
169		$deployment = DNDeployment::get()->byId($request->postVar('id'));
170		$errorResponse = $this->validateDeployment($deployment);
		0 ignored issues – show Documentation introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report `$deployment` is of type `object<DataObject>\|null`, but the function expects a `object<DNDeployment>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
171		if ($errorResponse instanceof \SS_HTTPResponse) {
172		return $errorResponse;
173		}
174
175		if (!$this->project->allowed(self::ALLOW_APPROVAL, Member::currentUser())) {
		0 ignored issues – show Bug introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report It seems like `\Member::currentUser()` targeting `Member::currentUser()` can also be of type `object<DataObject>`; however, `DNProject::allowed()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
176		return $this->getAPIResponse(['message' => 'You are not authorised to approve this deployment'], 403);
177		}
178
179		try {
180		$deployment->getMachine()->apply(DNDeployment::TR_APPROVE);
181		} catch (\Exception $e) {
182		return $this->getAPIResponse([
183		'status' => 'FAILED',
184		'message' => $e->getMessage()
185		], 400);
186		}
187
188		return $this->getAPIResponse([
189		'status' => 'OK',
190		'id' => $deployment->ID,
191		'new_status' => DNDeployment::STATE_APPROVED
192		], 200);
193		}
194
195		/**
196		* @param \SS_HTTPRequest $request
197		* @return \SS_HTTPResponse
198		*/
199	View Code Duplication	public function reject(SS_HTTPRequest $request) {
		0 ignored issues – show Duplication introduced 2016-10-04 02:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
200		if ($request->httpMethod() !== 'POST') {
201		return $this->getAPIResponse(['message' => 'Method not allowed, requires POST'], 405);
202		}
203
204		$deployment = DNDeployment::get()->byId($request->postVar('id'));
205		$errorResponse = $this->validateDeployment($deployment);
		0 ignored issues – show Documentation introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report `$deployment` is of type `object<DataObject>\|null`, but the function expects a `object<DNDeployment>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
206		if ($errorResponse instanceof \SS_HTTPResponse) {
207		return $errorResponse;
208		}
209		// reject permissions are the same as can approve
210		if (!$this->project->allowed(self::ALLOW_APPROVAL, Member::currentUser())) {
		0 ignored issues – show Bug introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report It seems like `\Member::currentUser()` targeting `Member::currentUser()` can also be of type `object<DataObject>`; however, `DNProject::allowed()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
211		return $this->getAPIResponse(['message' => 'You are not authorised to reject this deployment'], 403);
212		}
213
214		try {
215		$deployment->getMachine()->apply(DNDeployment::TR_REJECT);
216		} catch (\Exception $e) {
217		return $this->getAPIResponse([
218		'status' => 'FAILED',
219		'message' => $e->getMessage()
220		], 400);
221		}
222
223		return $this->getAPIResponse([
224		'status' => 'OK',
225		'id' => $deployment->ID,
226		'new_status' => DNDeployment::STATE_REJECTED
227		], 200);
228		}
229
230		/**
231		* Check if a DNDeployment exists and do permission checks on it. If there is something wrong it will return
232		* an APIResponse with the error, otherwise null.
233		*
234		* @param \DNDeployment $deployment
235		*
236		* @return null\|SS_HTTPResponse
237		*/
238	View Code Duplication	protected function validateDeployment(\DNDeployment $deployment) {
		0 ignored issues – show Duplication introduced 2016-10-04 02:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
239		if (!$deployment \|\| !$deployment->exists()) {
240		return $this->getAPIResponse(['message' => 'This deployment does not exist'], 404);
241		}
242		if ($deployment->EnvironmentID != $this->environment->ID) {
243		return $this->getAPIResponse(['message' => 'This deployment does not belong to the environment'], 403);
244		}
245		if (!$deployment->canView()) {
246		return $this->getAPIResponse(['message' => 'You are not authorised to view this deployment'], 403);
247		}
248		return null;
249		}
250
251		/**
252		* @return ArrayList
253		*/
254		protected function getApprovers() {
255		$list = new ArrayList();
256		if (self::$_cache_project_members === null) {
257		self::$_cache_project_members = $this->project->listMembers();
		0 ignored issues – show Documentation Bug introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report The method `listMembers` does not exist on `object<DNProject>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
258		}
259		foreach (self::$_cache_project_members as $data) {
260		$list->push(new ArrayData([
261		'ID' => $member->ID,
		0 ignored issues – show Bug introduced 2016-10-05 01:05 UTC by Report Bug Copy Issue Report The variable `$member` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
262		'Role' => $data['RoleTitle']
263		]));
264		}
265		return $list;
266		}
267
268		/**
269		* @param string $name
270		* @return array
271		*/
272		public function getModel($name = '') {
273		return [];
274		}
275
276		/**
277		* @param string $action
278		* @return string
279		*/
280		public function Link($action = '') {
281		return \Controller::join_links($this->environment->Link(), self::ACTION_APPROVALS, $action);
282		}
283
284		}
285

silverstripe / deploynaut

Pull Request — master (#681)

ApprovalsDispatcher::reject() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like