Completed
Pull Request — 1.1 (#490)
by Mateusz
06:14
created
code/api/nouns/APINoun.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Base class for the APINouns
4
- */
3
+	 * Base class for the APINouns
4
+	 */
5 5
 class APINoun extends Controller {
6 6
 
7 7
 	/**
Please login to merge, or discard this patch.
code/tasks/DNMigrate1_1to1_2.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Will convert the Filename to the version 1.2 of deploynaut where it
4
- * more or less is exactly is the same as the Name but with .rb
5
- */
3
+	 * Will convert the Filename to the version 1.2 of deploynaut where it
4
+	 * more or less is exactly is the same as the Name but with .rb
5
+	 */
6 6
 class DNMigrate1_1to1_2 extends BuildTask {
7 7
 	/**
8 8
 	 * @param SS_HTTPRequest $request
Please login to merge, or discard this patch.
code/tasks/FilesystemSyncTask.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Surface Filesystem::sync() as a dev task in case CMS has not been included.
4
- */
3
+	 * Surface Filesystem::sync() as a dev task in case CMS has not been included.
4
+	 */
5 5
 class CMSFilesystemSyncTask extends BuildTask {
6 6
 	public function run($request = null) {
7 7
 		Filesystem::sync();
Please login to merge, or discard this patch.
code/api/DeploynautAPI.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
 	/**
42 42
 	 *
43 43
 	 * @param SS_HTTPRequest $request
44
-	 * @return string
44
+	 * @return SS_HTTPResponse
45 45
 	 */
46 46
 	public function listProjects(SS_HTTPRequest $request) {
47 47
 		$response = array(
Please login to merge, or discard this patch.
code/backends/CapistranoDeploymentBackend.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -300,6 +300,7 @@
 block discarded – undo
300 300
 	/**
301 301
 	 * Utility function for triggering the db rebuild and flush.
302 302
 	 * Also cleans up and generates new error pages.
303
+	 * @param DeploynautLogFile $log
303 304
 	 */
304 305
 	public function rebuild(DNEnvironment $environment, $log) {
305 306
 		$name = $environment->getFullName();
Please login to merge, or discard this patch.
code/backends/DeploymentBackend.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -10,6 +10,7 @@  discard block
 block discarded – undo
10 10
 	 * @param DeploynautLogFile $log
11 11
 	 * @param DNProject $project
12 12
 	 * @param type $leaveMaintenancePage
13
+	 * @return void
13 14
 	 */
14 15
 	public function deploy(DNEnvironment $environment, $sha, DeploynautLogFile $log, DNProject $project, $leaveMaintenancePage = false);
15 16
 
@@ -19,6 +20,7 @@  discard block
 block discarded – undo
19 20
 	 *
20 21
 	 * @param DNDataTransfer $dataTransfer
21 22
 	 * @param DeploynautLogFile $log
23
+	 * @return void
22 24
 	 */
23 25
 	public function dataTransfer(DNDataTransfer $dataTransfer, DeploynautLogFile $log);
24 26
 
@@ -28,6 +30,7 @@  discard block
 block discarded – undo
28 30
 	 * @param DNEnvironment $environment
29 31
 	 * @param DeploynautLogFile $log
30 32
 	 * @param DNProject $project
33
+	 * @return void
31 34
 	 */
32 35
 	public function enableMaintenance(DNEnvironment $environment, DeploynautLogFile $log, DNProject $project);
33 36
 
@@ -37,6 +40,7 @@  discard block
 block discarded – undo
37 40
 	 * @param DNEnvironment $environment
38 41
 	 * @param DeploynautLogFile $log
39 42
 	 * @param DNProject $project
43
+	 * @return void
40 44
 	 */
41 45
 	public function disableMaintenance(DNEnvironment $environment, DeploynautLogFile $log, DNProject $project);
42 46
 
@@ -46,6 +50,7 @@  discard block
 block discarded – undo
46 50
 	 * @param DNEnvironment $environment
47 51
 	 * @param DeploynautLogFile $log
48 52
 	 * @param DNProject $project
53
+	 * @return void
49 54
 	 */
50 55
 	public function ping(DNEnvironment $environment, DeploynautLogFile $log, DNProject $project);
51 56
 
Please login to merge, or discard this patch.
code/backends/PackageGenerator.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@
 block discarded – undo
13 13
 	/**
14 14
 	 * Generate the package file, saving to the given location
15 15
 	 *
16
-	 * @param $baseDir string The base directory of the project, checked out from git.
16
+	 * @param string $baseDir string The base directory of the project, checked out from git.
17 17
 	 * @param $outputFilename string The filename to write to.
18
+	 * @param string $sha
18 19
 	 *
19 20
 	 * @return boolean True on success
20 21
 	 */
Please login to merge, or discard this patch.
code/backends/SizeRestrictedPackageCache.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
 	/**
73 73
 	 * Take the identifier an make it safe to use as a directory name.
74 74
 	 *
75
-	 * @param string $identfiier The unsanitised directory name.
75
+	 * @param string $identifier The unsanitised directory name.
76 76
 	 */
77 77
 	protected function sanitiseDirName($identifier) {
78 78
 		$safe = preg_replace('/[^A-Za-z0-9_-]/', '', $identifier);
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
 		$files = glob($dir . '/*.tar.gz');
92 92
 		if(sizeof($files) > $count) {
93 93
 			usort($files, function($a, $b) {
94
-			    return filemtime($a) > filemtime($b);
94
+				return filemtime($a) > filemtime($b);
95 95
 			});
96 96
 
97 97
 			for($i=0;$i<sizeof($files)-$count;$i++) {
Please login to merge, or discard this patch.
code/control/DeployForm.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,6 +18,7 @@  discard block
 block discarded – undo
18 18
 	 * Validate a commit sha
19 19
 	 *
20 20
 	 * @param string $sha
21
+	 * @param string $field
21 22
 	 * @return boolean
22 23
 	 */
23 24
 	protected function validateCommit($sha, $field) {
@@ -100,6 +101,10 @@  discard block
 block discarded – undo
100 101
  */
101 102
 class DeployForm extends Form {
102 103
 
104
+	/**
105
+	 * @param DNRoot $controller
106
+	 * @param string $name
107
+	 */
103 108
 	public function __construct($controller, $name, DNEnvironment $environment, DNProject $project) {
104 109
 		if($environment->HasPipelineSupport()) {
105 110
 			// Determine if commits are filtered
@@ -261,7 +266,6 @@  discard block
 block discarded – undo
261 266
 	/**
262 267
 	 * Generate fields necessary to select from a filtered commit list
263 268
 	 *
264
-	 * @param DNEnvironment $environment
265 269
 	 * @param DataList $commits List of commits
266 270
 	 * @return FormField
267 271
 	 */
Please login to merge, or discard this patch.