Completed
Pull Request — 1.1 (#490)
by Mateusz
06:14
created
code/model/DNReferenceList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,6 @@  discard block
 block discarded – undo
55 55
 	}
56 56
 
57 57
 	/**
58
-	 * @param int $limit - defaults to the ten lates
59 58
 	 * @return array()
60 59
 	 */
61 60
 	protected function getReferences() {
@@ -106,6 +105,7 @@  discard block
 block discarded – undo
106 105
 
107 106
 	/**
108 107
 	 * Find a build in this set by hash.
108
+	 * @param string $hash
109 109
 	 */
110 110
 	public function byName($hash) {
111 111
 		if($this->loaded == false) {
Please login to merge, or discard this patch.
code/model/DNTag.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 	);
23 23
 
24 24
 	/**
25
-	 * @param Gitonomy\Git\Commit $commit
26 25
 	 * @param DNProject $project
27 26
 	 * @param DNData $data
28 27
 	 */
Please login to merge, or discard this patch.
code/model/jobs/DNDataTransfer.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -76,6 +76,9 @@
 block discarded – undo
76 76
 	 */
77 77
 	protected $backupBeforePush = true;
78 78
 
79
+	/**
80
+	 * @param boolean $value
81
+	 */
79 82
 	public function setBackupBeforePush($value) {
80 83
 		$this->backupBeforePush = $value;
81 84
 	}
Please login to merge, or discard this patch.
code/model/Pipeline.php 1 patch
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -368,7 +368,6 @@  discard block
 block discarded – undo
368 368
 	 * Retrieve the value of a specific config setting
369 369
 	 *
370 370
 	 * @param string $setting Settings
371
-	 * @param string $setting,... Sub-settings
372 371
 	 * @return mixed Value of setting, or null if not set
373 372
 	 */
374 373
 	public function getConfigSetting($setting) {
@@ -773,7 +772,7 @@  discard block
 block discarded – undo
773 772
 	 * Sends a specific message to all marked recipients, including the author of this pipeline
774 773
 	 *
775 774
 	 * @param string $messageID Message ID. One of 'Abort', 'Success', or 'Failure', or some custom message
776
-	 * @return boolean True if successful
775
+	 * @return boolean|null True if successful
777 776
 	 */
778 777
 	public function sendMessage($messageID) {
779 778
 		// Check message, subject, and additional arguments to include
@@ -922,7 +921,7 @@  discard block
 block discarded – undo
922 921
 	/**
923 922
 	 * Finds the next {@link PipelineStep} that needs to execute. Relies on $this->CurrentStep() being a valid step.
924 923
 	 *
925
-	 * @return PipelineStep|null The next step in the pipeline, or null if none remain.
924
+	 * @return DataObject|null The next step in the pipeline, or null if none remain.
926 925
 	 */
927 926
 	protected function findNextStep() {
928 927
 		// otherwise get next step in chain
@@ -939,7 +938,7 @@  discard block
 block discarded – undo
939 938
 	/**
940 939
 	 * Finds the previous {@link PipelineStep} that executed. Relies on $this->CurrentStep() being a valid step.
941 940
 	 *
942
-	 * @return PipelineStep|null The previous step in the pipeline, or null if this is the first.
941
+	 * @return DataObject|null The previous step in the pipeline, or null if this is the first.
943 942
 	 */
944 943
 	public function findPreviousStep() {
945 944
 		// otherwise get previous step in chain
@@ -1013,6 +1012,9 @@  discard block
 block discarded – undo
1013 1012
 		return $this->getField('DryRun');
1014 1013
 	}
1015 1014
 
1015
+	/**
1016
+	 * @param string $action
1017
+	 */
1016 1018
 	public function Link($action = null) {
1017 1019
 		return Controller::join_links($this->Environment()->Link(), 'pipeline', $this->ID, $action);
1018 1020
 	}
Please login to merge, or discard this patch.
code/model/steps/PipelineStep.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -119,7 +119,6 @@  discard block
 block discarded – undo
119 119
 	 * Retrieve the value of a specific config setting
120 120
 	 *
121 121
 	 * @param string $setting Settings
122
-	 * @param string $setting,... Sub-settings
123 122
 	 * @return mixed Value of setting, or null if not set
124 123
 	 */
125 124
 	public function getConfigSetting($setting) {
@@ -233,7 +232,7 @@  discard block
 block discarded – undo
233 232
 	 * Initialise the step unless it's already running (Started state).
234 233
 	 * The step will be expected to transition from here to Finished, Failed or Aborted state.
235 234
 	 *
236
-	 * @return boolean True if successfully started, false if error
235
+	 * @return boolean|null True if successfully started, false if error
237 236
 	 */
238 237
 	public function start() {
239 238
 		$this->Status = 'Started';
Please login to merge, or discard this patch.
code/model/steps/UserConfirmationStep.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -319,7 +319,7 @@
 block discarded – undo
319 319
 	 * @param string $messageID Message ID. One of 'Reject', 'Approve', 'TimeOut' or 'Request'
320 320
 	 * @param mixed $recipientGroup Either a numeric index of the next recipient to send to, or "all" for all
321 321
 	 * This is used for delayed notification so that failover recipients can be notified.
322
-	 * @return boolean True if successful
322
+	 * @return boolean|null True if successful
323 323
 	 */
324 324
 	protected function sendMessage($messageID, $recipientGroup = 'all') {
325 325
 		// Add additionally configured arguments
Please login to merge, or discard this patch.
code/model/DNBranch.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 	);
23 23
 
24 24
 	/**
25
-	 * @param Gitonomy\Git\Commit $commit
26 25
 	 * @param DNProject $project
27 26
 	 * @param DNData $data
28 27
 	 */
Please login to merge, or discard this patch.