silverstripe / deploynaut

code/model/DNDataArchive.php

Spacing +29 added lines, -29 removed lines

@@ -121,7 +121,7 @@ 
 	}
 
 	public function onBeforeWrite() {
-		if(!$this->AuthorID) {
+		if (!$this->AuthorID) {
 			$this->AuthorID = Member::currentUserID();
 		}
 
@@ -179,7 +179,7 @@ 
 	 * @return string The human-readable size of this archive file
 	 */
 	public function FileSize() {
-		if($this->ArchiveFile()->exists()) {
+		if ($this->ArchiveFile()->exists()) {
 			return $this->ArchiveFile()->getSize();
 		} else {
 			return "N/A";
@@ -187,7 +187,7 @@ 
 	}
 
 	public function getModeNice() {
-		if($this->Mode == 'all') {
+		if ($this->Mode == 'all') {
 			return 'database and assets';
 		} else {
 			return $this->Mode;
@@ -223,12 +223,12 @@ 
 	 */
 	public function canRestore($member = null) {
 		$memberID = $member ? $member->ID : Member::currentUserID();
-		if(!$memberID) {
+		if (!$memberID) {
 			return false;
 		}
 
-		$key = $memberID . '-' . $this->EnvironmentID;
-		if(!isset(self::$_cache_can_restore[$key])) {
+		$key = $memberID.'-'.$this->EnvironmentID;
+		if (!isset(self::$_cache_can_restore[$key])) {
 			self::$_cache_can_restore[$key] = $this->Environment()->canUploadArchive($member);
 		}
 
@@ -244,12 +244,12 @@ 
 	 */
 	public function canDownload($member = null) {
 		$memberID = $member ? $member->ID : Member::currentUserID();
-		if(!$memberID) {
+		if (!$memberID) {
 			return false;
 		}
 
-		$key = $memberID . '-' . $this->EnvironmentID;
-		if(!isset(self::$_cache_can_download[$key])) {
+		$key = $memberID.'-'.$this->EnvironmentID;
+		if (!isset(self::$_cache_can_download[$key])) {
 			self::$_cache_can_download[$key] = $this->Environment()->canDownloadArchive($member);
 		}
 		return self::$_cache_can_download[$key];
@@ -274,27 +274,27 @@ 
 	 * @return boolean true if $member can upload archives linked to this environment, false if they can't.
 	 */
 	public function canMoveTo($targetEnv, $member = null) {
-		if($this->Environment()->Project()->ID != $targetEnv->Project()->ID) {
+		if ($this->Environment()->Project()->ID != $targetEnv->Project()->ID) {
 			// We don't permit moving snapshots between projects at this stage.
 			return false;
 		}
 
-		if(!$member) {
+		if (!$member) {
 			$member = Member::currentUser();
 		}
 
 		// Must be logged in to check permissions
-		if(!$member) {
+		if (!$member) {
 			return false;
 		}
 
 		// Admin can always move.
-		if(Permission::checkMember($member, 'ADMIN')) {
+		if (Permission::checkMember($member, 'ADMIN')) {
 			return true;
 		}
 
 		// Checks if the user can actually access the archive.
-		if(!$this->canDownload($member)) {
+		if (!$this->canDownload($member)) {
 			return false;
 		}
 
@@ -403,7 +403,7 @@ 
 	 * @return bool
 	 */
 	public function extractArchive($workingDir = null) {
-		if(!is_dir($workingDir)) {
+		if (!is_dir($workingDir)) {
 			mkdir($workingDir, 0700, true);
 		}
 
@@ -422,28 +422,28 @@ 
 		));
 		$process->setTimeout(3600);
 		$process->run();
-		if(!$process->isSuccessful()) {
+		if (!$process->isSuccessful()) {
 			$cleanupFn();
 			throw new RuntimeException(sprintf('Could not extract the sspak file: %s', $process->getErrorOutput()));
 		}
 
 		// Extract database.sql.gz to <workingdir>/database.sql
-		if(file_exists($workingDir . DIRECTORY_SEPARATOR . 'database.sql.gz')) {
+		if (file_exists($workingDir.DIRECTORY_SEPARATOR.'database.sql.gz')) {
 			$process = new AbortableProcess('gunzip database.sql.gz', $workingDir);
 			$process->setTimeout(3600);
 			$process->run();
-			if(!$process->isSuccessful()) {
+			if (!$process->isSuccessful()) {
 				$cleanupFn();
 				throw new RuntimeException(sprintf('Could not extract the db archive: %s', $process->getErrorOutput()));
 			}
 		}
 
 		// Extract assets.tar.gz to <workingdir>/assets/
-		if(file_exists($workingDir . DIRECTORY_SEPARATOR . 'assets.tar.gz')) {
+		if (file_exists($workingDir.DIRECTORY_SEPARATOR.'assets.tar.gz')) {
 			$process = new AbortableProcess('tar xzf assets.tar.gz', $workingDir);
 			$process->setTimeout(3600);
 			$process->run();
-			if(!$process->isSuccessful()) {
+			if (!$process->isSuccessful()) {
 				$cleanupFn();
 				throw new RuntimeException(sprintf('Could not extract the assets archive: %s', $process->getErrorOutput()));
 			}
@@ -467,7 +467,7 @@ 
 
 		$file = $this->ArchiveFile()->FullPath;
 
-		if(!is_readable($file)) {
+		if (!is_readable($file)) {
 			$result->error(sprintf('SSPak file "%s" cannot be read.', $file));
 			return $result;
 		}
@@ -475,19 +475,19 @@ 
 		$process = new AbortableProcess(sprintf('tar -tf %s', escapeshellarg($file)));
 		$process->setTimeout(120);
 		$process->run();
-		if(!$process->isSuccessful()) {
+		if (!$process->isSuccessful()) {
 			throw new RuntimeException(sprintf('Could not list files in archive: %s', $process->getErrorOutput()));
 		}
 
 		$output = explode(PHP_EOL, $process->getOutput());
 		$files = array_filter($output);
 
-		if(in_array($mode, array('all', 'db')) && !in_array('database.sql.gz', $files)) {
+		if (in_array($mode, array('all', 'db')) && !in_array('database.sql.gz', $files)) {
 			$result->error('The snapshot is missing the database.');
 			return $result;
 		}
 
-		if(in_array($mode, array('all', 'assets')) && !in_array('assets.tar.gz', $files)) {
+		if (in_array($mode, array('all', 'assets')) && !in_array('assets.tar.gz', $files)) {
 			$result->error('The snapshot is missing assets.');
 			return $result;
 		}
@@ -517,11 +517,11 @@ 
 			sprintf('find %s -type f -exec chmod 644 {} +', escapeshellarg($workingDir))
 		);
 
-		foreach($fixCmds as $cmd) {
+		foreach ($fixCmds as $cmd) {
 			$process = new AbortableProcess($cmd);
 			$process->setTimeout(3600);
 			$process->run();
-			if(!$process->isSuccessful()) {
+			if (!$process->isSuccessful()) {
 				throw new RuntimeException($process->getErrorOutput());
 			}
 		}
@@ -540,11 +540,11 @@ 
 	 */
 	public function setArchiveFromFiles($workingDir) {
 		$commands = array();
-		if($this->Mode == 'db') {
+		if ($this->Mode == 'db') {
 			$commands[] = 'gzip database.sql';
 			$commands[] = sprintf('tar -cf %s database.sql.gz', $this->ArchiveFile()->FullPath);
 			$commands[] = 'rm -f database.sql.gz';
-		} elseif($this->Mode == 'assets') {
+		} elseif ($this->Mode == 'assets') {
 			$commands[] = 'GZIP=-1 tar --dereference -czf assets.tar.gz assets';
 			$commands[] = sprintf('tar -cf %s assets.tar.gz', $this->ArchiveFile()->FullPath);
 			$commands[] = 'rm -f assets.tar.gz';
@@ -558,7 +558,7 @@ 
 		$process = new AbortableProcess(implode(' && ', $commands), $workingDir);
 		$process->setTimeout(3600);
 		$process->run();
-		if(!$process->isSuccessful()) {
+		if (!$process->isSuccessful()) {
 			throw new RuntimeException($process->getErrorOutput());
 		}
 

code/model/jobs/DNCreateEnvironment.php

Spacing +9 added lines, -9 removed lines

@@ -68,7 +68,7 @@ 
 	 * @return string
 	 */
 	public function LogLink() {
-		return $this->Link() . '/log';
+		return $this->Link().'/log';
 	}
 
 	/**
@@ -110,9 +110,9 @@ 
 		$status = new Resque_Job_Status($this->ResqueToken);
 		$statusCode = $status->get();
 		// The Resque job can no longer be found, fallback to the DNDeployment.Status
-		if($statusCode === false) {
+		if ($statusCode === false) {
 			// Translate from the DNDeployment.Status to the Resque job status for UI purposes
-			switch($this->Status) {
+			switch ($this->Status) {
 				case 'Finished':
 					return 'Complete';
 				case 'Started':
@@ -139,11 +139,11 @@ 
 			'projectName' => $project->Name
 		);
 
-		if(!$this->CreatorID) {
+		if (!$this->CreatorID) {
 			$this->CreatorID = Member::currentUserID();
 		}
 
-		if($this->CreatorID) {
+		if ($this->CreatorID) {
 			$creator = $this->Creator();
 			$message = sprintf(
 				'Environment creation for project %s initiated by %s (%s), with IP address %s',
@@ -171,7 +171,7 @@ 
 
 	public function createEnvironment() {
 		$backend = $this->getBackend();
-		if($backend) {
+		if ($backend) {
 			return $backend->createEnvironment($this);
 		}
 		throw new Exception("Unable to find backend.");
@@ -185,12 +185,12 @@ 
 	 */
 	public function getBackend() {
 		$data = unserialize($this->Data);
-		if(isset($data['EnvironmentType']) && class_exists($data['EnvironmentType'])) {
+		if (isset($data['EnvironmentType']) && class_exists($data['EnvironmentType'])) {
 			$env = Injector::inst()->get($data['EnvironmentType']);
-			if($env instanceof EnvironmentCreateBackend) {
+			if ($env instanceof EnvironmentCreateBackend) {
 				return $env;
 			} else {
-				throw new Exception("Invalid backend: " . $data['EnvironmentType']);
+				throw new Exception("Invalid backend: ".$data['EnvironmentType']);
 			}
 		}
 		return null;

code/model/jobs/DNDataTransfer.php

Spacing +13 added lines, -13 removed lines

@@ -112,7 +112,7 @@ 
 	}
 
 	public function getTitle() {
-		return $this->dbObject('Created')->Nice() . " (Status: {$this->Status})";
+		return $this->dbObject('Created')->Nice()." (Status: {$this->Status})";
 	}
 
 	public function Link() {
@@ -169,11 +169,11 @@ 
 			'backupBeforePush' => $this->backupBeforePush
 		);
 
-		if(!$this->AuthorID) {
+		if (!$this->AuthorID) {
 			$this->AuthorID = Member::currentUserID();
 		}
 
-		if($this->AuthorID) {
+		if ($this->AuthorID) {
 			$author = $this->Author();
 			$message = sprintf(
 				'Data transfer on %s (%s, %s) initiated by %s (%s), with IP address %s',
@@ -231,23 +231,23 @@ 
 
 	public function getDescription() {
 		$envName = $this->Environment()->getFullName();
-		if($this->Direction == 'get') {
-			if($this->Origin == 'ManualUpload') {
-				$description = 'Manual upload of ' . $this->getModeNice() . ' to ' . $envName;
-			} elseif($this->IsBackupDataTransfer()) {
-				$description = 'Automated backup of ' . $this->getModeNice() . ' from ' . $envName;
+		if ($this->Direction == 'get') {
+			if ($this->Origin == 'ManualUpload') {
+				$description = 'Manual upload of '.$this->getModeNice().' to '.$envName;
+			} elseif ($this->IsBackupDataTransfer()) {
+				$description = 'Automated backup of '.$this->getModeNice().' from '.$envName;
 			} else {
-				$description = 'Backup of ' . $this->getModeNice() . ' to ' . $envName;
+				$description = 'Backup of '.$this->getModeNice().' to '.$envName;
 			}
 		} else {
-			$description = 'Restore ' . $this->getModeNice() . ' to ' . $envName;
+			$description = 'Restore '.$this->getModeNice().' to '.$envName;
 		}
 
 		return $description;
 	}
 
 	public function getModeNice() {
-		if($this->Mode == 'all') {
+		if ($this->Mode == 'all') {
 			return 'database and assets';
 		} else {
 			return $this->Mode;
@@ -287,9 +287,9 @@ 
 		$status = new Resque_Job_Status($this->ResqueToken);
 		$statusCode = $status->get();
 		// The Resque job can no longer be found, fallback to the DNDataTransfer.Status
-		if($statusCode === false) {
+		if ($statusCode === false) {
 			// Translate from the DNDataTransfer.Status to the Resque job status for UI purposes
-			switch($this->Status) {
+			switch ($this->Status) {
 				case 'Finished':
 					return 'Complete';
 				case 'Started':

code/model/jobs/DNGitFetch.php

Spacing +4 added lines, -4 removed lines

@@ -54,11 +54,11 @@ 
 		$project = $this->Project();
 		$log = $this->log();
 
-		if(!$this->DeployerID) {
+		if (!$this->DeployerID) {
 			$this->DeployerID = Member::currentUserID();
 		}
 
-		if($this->DeployerID) {
+		if ($this->DeployerID) {
 			$deployer = $this->Deployer();
 			$message = sprintf(
 				'Update repository job for %s initiated by %s (%s)',
@@ -131,9 +131,9 @@ 
 		$status = new Resque_Job_Status($this->ResqueToken);
 		$statusCode = $status->get();
 		// The Resque job can no longer be found, fallback to the DNDeployment.Status
-		if($statusCode === false) {
+		if ($statusCode === false) {
 			// Translate from the DNDeployment.Status to the Resque job status for UI purposes
-			switch($this->Status) {
+			switch ($this->Status) {
 				case 'Finished':
 					return 'Complete';
 				case 'Started':

code/model/jobs/DNPing.php

Spacing +3 added lines, -3 removed lines

@@ -37,7 +37,7 @@ 
 	 * @return string
 	 */
 	public function LogLink() {
-		return $this->Link() . '/log';
+		return $this->Link().'/log';
 	}
 
 	/**
@@ -107,11 +107,11 @@ 
 			'pingID' => $this->ID
 		);
 
-		if(!$this->DeployerID) {
+		if (!$this->DeployerID) {
 			$this->DeployerID = Member::currentUserID();
 		}
 
-		if($this->DeployerID) {
+		if ($this->DeployerID) {
 			$deployer = $this->Deployer();
 			$message = sprintf(
 				'Ping to %s initiated by %s (%s)',

code/model/jobs/DNDeployment.php

Spacing +16 added lines, -16 removed lines

@@ -101,7 +101,7 @@ 
 	}
 
 	public function LogLink() {
-		return $this->Link() . '/log';
+		return $this->Link().'/log';
 	}
 
 	public function canView($member = null) {
@@ -147,7 +147,7 @@ 
 	 * @return \Gitonomy\Git\Repository|null
 	 */
 	public function getRepository() {
-		if(!$this->SHA) {
+		if (!$this->SHA) {
 			return null;
 		}
 		return $this->Environment()->Project()->getRepository();
@@ -160,10 +160,10 @@ 
 	 */
 	public function getCommit() {
 		$repo = $this->getRepository();
-		if($repo) {
+		if ($repo) {
 			try {
 				return $repo->getCommit($this->SHA);
-			} catch(Gitonomy\Git\Exception\ReferenceNotFoundException $ex) {
+			} catch (Gitonomy\Git\Exception\ReferenceNotFoundException $ex) {
 				return null;
 			}
 		}
@@ -188,7 +188,7 @@ 
 		if (!$interface) {
 			return null;
 		}
-		return $interface->CommitURL . '/' . $this->SHA;
+		return $interface->CommitURL.'/'.$this->SHA;
 	}
 
 	/**
@@ -198,10 +198,10 @@ 
 	 */
 	public function getCommitMessage() {
 		$commit = $this->getCommit();
-		if($commit) {
+		if ($commit) {
 			try {
 				return Convert::raw2xml($commit->getMessage());
-			} catch(Gitonomy\Git\Exception\ReferenceNotFoundException $e) {
+			} catch (Gitonomy\Git\Exception\ReferenceNotFoundException $e) {
 				return null;
 			}
 		}
@@ -216,10 +216,10 @@ 
 	public function getTags() {
 		$returnTags = array();
 		$repo = $this->getRepository();
-		if($repo) {
+		if ($repo) {
 			$tags = $repo->getReferences()->resolveTags($this->SHA);
-			if(!empty($tags)) {
-				foreach($tags as $tag) {
+			if (!empty($tags)) {
+				foreach ($tags as $tag) {
 					$field = Varchar::create('Tag', '255');
 					$field->setValue($tag->getName());
 					$returnTags[] = $field;
@@ -237,12 +237,12 @@ 
 	 */
 	public function getFullDeployMessages() {
 		$strategy = $this->getDeploymentStrategy();
-		if ($strategy->getActionCode()!=='full') return null;
+		if ($strategy->getActionCode() !== 'full') return null;
 
 		$changes = $strategy->getChangesModificationNeeded();
 		$messages = [];
 		foreach ($changes as $change => $details) {
-			if ($change==='Code version') continue;
+			if ($change === 'Code version') continue;
 
 			$messages[] = [
 				'Flag' => sprintf(
@@ -270,7 +270,7 @@ 
 	 */
 	public function getTag() {
 		$tags = $this->getTags();
-		if($tags->count() > 0) {
+		if ($tags->count() > 0) {
 			return $tags->last();
 		}
 		return null;
@@ -295,7 +295,7 @@ 
 	public function getChanges() {
 		$list = new ArrayList();
 		$strategy = $this->getDeploymentStrategy();
-		foreach($strategy->getChanges() as $name => $change) {
+		foreach ($strategy->getChanges() as $name => $change) {
 			$changed = (isset($change['from']) && isset($change['to'])) ? $change['from'] != $change['to'] : null;
 			$description = isset($change['description']) ? $change['description'] : '';
 			$compareUrl = null;
@@ -345,11 +345,11 @@ 
 		// Make sure we use the SHA as it was written into this DNDeployment.
 		$args['sha'] = $this->SHA;
 
-		if(!$this->DeployerID) {
+		if (!$this->DeployerID) {
 			$this->DeployerID = Member::currentUserID();
 		}
 
-		if($this->DeployerID) {
+		if ($this->DeployerID) {
 			$deployer = $this->Deployer();
 			$message = sprintf(
 				'Deploy to %s initiated by %s (%s), with IP address %s',

code/model/DNData.php

Spacing +21 added lines, -21 removed lines

@@ -59,7 +59,7 @@ 
 		parent::__construct();
 
 		// Better to use injector to set these
-		if(func_num_args() == 0) {
+		if (func_num_args() == 0) {
 			return;
 		}
 		Deprecation::notice(
@@ -88,8 +88,8 @@ 
 	 * @param string $environmentDir
 	 */
 	public function setEnvironmentDir($environmentDir) {
-		if($environmentDir[0] != "/") {
-			$environmentDir = BASE_PATH . '/' . $environmentDir;
+		if ($environmentDir[0] != "/") {
+			$environmentDir = BASE_PATH.'/'.$environmentDir;
 		}
 		$this->environmentDir = realpath($environmentDir) ?: $environmentDir;
 	}
@@ -109,8 +109,8 @@ 
 	 * @param string $keyDir
 	 */
 	public function setKeyDir($keyDir) {
-		if($keyDir[0] != "/") {
-			$keyDir = BASE_PATH . '/' . $keyDir;
+		if ($keyDir[0] != "/") {
+			$keyDir = BASE_PATH.'/'.$keyDir;
 		}
 		$this->keyDir = realpath($keyDir) ?: $keyDir;
 	}
@@ -126,8 +126,8 @@ 
 	 * @param string $signalDir
 	 */
 	public function setSignalDir($signalDir) {
-		if($signalDir[0] != "/") {
-			$signalDir = BASE_PATH . '/' . $signalDir;
+		if ($signalDir[0] != "/") {
+			$signalDir = BASE_PATH.'/'.$signalDir;
 		}
 		$this->signalDir = realpath($signalDir) ?: $signalDir;
 	}
@@ -168,10 +168,10 @@ 
 	 * @param string $transferDir
 	 */
 	public function setDataTransferDir($transferDir) {
-		if($transferDir[0] != "/") {
-			$transferDir = BASE_PATH . '/' . $transferDir;
+		if ($transferDir[0] != "/") {
+			$transferDir = BASE_PATH.'/'.$transferDir;
 		}
-		if(strpos($transferDir, ASSETS_PATH) === false) {
+		if (strpos($transferDir, ASSETS_PATH) === false) {
 			throw new LogicException(sprintf(
 				'DNData::dataTransferDir needs to be located within <webroot>assets/ (location: %s)',
 				$transferDir
@@ -198,16 +198,16 @@ 
 	 */
 	public function getProjectPaths() {
 		$paths = array();
-		if(!file_exists($this->getEnvironmentDir())) {
-			$eMessage = 'The environment directory ' . $this->getEnvironmentDir() . ' doesn\'t exist. Create it '
+		if (!file_exists($this->getEnvironmentDir())) {
+			$eMessage = 'The environment directory '.$this->getEnvironmentDir().' doesn\'t exist. Create it '
 			. 'first and add some projects to it.';
 			throw new Exception($eMessage);
 		}
-		foreach(scandir($this->getEnvironmentDir()) as $project) {
+		foreach (scandir($this->getEnvironmentDir()) as $project) {
 			// Exlcude dot-prefixed directories (.git was getting in the way)
-			if(preg_match('/^[^\.]/', $project)) {
-				$path = $this->getEnvironmentDir() . '/' . $project;
-				if(is_dir($path) && $project != '.' && $project != '..') {
+			if (preg_match('/^[^\.]/', $project)) {
+				$path = $this->getEnvironmentDir().'/'.$project;
+				if (is_dir($path) && $project != '.' && $project != '..') {
 					$paths[] = $project;
 				}
 			}
@@ -221,15 +221,15 @@ 
 	 * Returns an array of paths
 	 */
 	public function getEnvironmentPaths($project) {
-		$baseDir = $this->getEnvironmentDir() . '/' . $project;
+		$baseDir = $this->getEnvironmentDir().'/'.$project;
 
 		$paths = array();
-		if(!file_exists($baseDir)) {
-			throw new Exception('Environment directory ' . $baseDir . ' doesn\'t exist. Create it first.');
+		if (!file_exists($baseDir)) {
+			throw new Exception('Environment directory '.$baseDir.' doesn\'t exist. Create it first.');
 		}
 		// Search the directory for config files.
-		foreach(scandir($baseDir) as $environmentFile) {
-			if(preg_match('/\.rb$/', $environmentFile)) {
+		foreach (scandir($baseDir) as $environmentFile) {
+			if (preg_match('/\.rb$/', $environmentFile)) {
 				// Config found, wrap it into an object.
 				$paths[] = "$baseDir/$environmentFile";
 			}

code/model/DNCommit.php

Spacing +11 added lines, -11 removed lines

@@ -74,7 +74,7 @@ 
 	 * @return string
 	 */
 	public function Name() {
-		if($this->name == null) {
+		if ($this->name == null) {
 			$this->name = $this->commit->getFixedShortHash(8);
 		}
 
@@ -94,7 +94,7 @@ 
 	 * @return string
 	 */
 	public function SubjectMessage() {
-		if($this->subjectMessage == null) {
+		if ($this->subjectMessage == null) {
 			$this->subjectMessage = $this->commit->getSubjectMessage();
 		}
 
@@ -102,7 +102,7 @@ 
 	}
 
 	public function BodyMessage() {
-		if($this->bodyMessage == null) {
+		if ($this->bodyMessage == null) {
 			$this->bodyMessage = $this->commit->getBodyMessage();
 		}
 
@@ -113,14 +113,14 @@ 
 	 * @return ArrayList
 	 */
 	public function References() {
-		if($this->references !== null) {
+		if ($this->references !== null) {
 			return $this->references;
 		}
 		$this->references = new ArrayList();
 
 		// Add tags
-		foreach($this->commit->resolveReferences() as $reference) {
-			if($reference instanceof \Gitonomy\Git\Reference\Tag) {
+		foreach ($this->commit->resolveReferences() as $reference) {
+			if ($reference instanceof \Gitonomy\Git\Reference\Tag) {
 				$this->references->push(new ArrayData(array(
 					'Name' => $reference->getName(),
 					'Type' => 'Tag',
@@ -151,16 +151,16 @@ 
 	public function CurrentlyDeployedTo() {
 		$environments = $this->project->Environments();
 		$envList = new ArrayList();
-		foreach($environments as $environment) {
+		foreach ($environments as $environment) {
 			$deployments = DNDeployment::get()
 				->filter('State', 'Completed')
 				->filter('EnvironmentID', $environment->ID)
 				->sort('LastEdited DESC');
-			if(!$deployments->count()) {
+			if (!$deployments->count()) {
 				continue;
 			}
 			$latest = $deployments->first();
-			if($latest->SHA === $this->commit->getHash()) {
+			if ($latest->SHA === $this->commit->getHash()) {
 				$envList->push($environment);
 			}
 		}
@@ -173,7 +173,7 @@ 
 	 */
 	public function EverDeployedTo($environmentName) {
 		$environments = $this->project->Environments()->filter('Name', $environmentName);
-		if(!$environments->count()) {
+		if (!$environments->count()) {
 			return false;
 		}
 
@@ -183,7 +183,7 @@ 
 				->filter('State', 'Completed')
 				->filter('EnvironmentID', $environment->ID);
 
-		if($deployments->count()) {
+		if ($deployments->count()) {
 			return true;
 		}
 

code/model/DNReferenceList.php

Spacing +18 added lines, -18 removed lines

@@ -100,24 +100,24 @@ 
 	protected function getReferences() {
 		try {
 			$repository = new Gitonomy\Git\Repository($this->project->getLocalCVSPath());
-		} catch(Exception $e) {
+		} catch (Exception $e) {
 			return array();
 		}
 
-		if($this->getTags) {
-			if($this->reference) {
+		if ($this->getTags) {
+			if ($this->reference) {
 				throw new LogicException("Can't have \$reference and \$getTags both set");
 			}
 			$log = $repository->getReferences()->getTags();
 
-		} else if($this->reference) {
+		} else if ($this->reference) {
 			$log = $this->reference->getLog();
 		} else {
 			$log = $repository->getLog();
 		}
 
-		if($this->limit) {
-			if(is_array($log)) {
+		if ($this->limit) {
+			if (is_array($log)) {
 				$limitedLog = array_slice($log, 0, $this->limit);
 			} else {
 				$limitedLog = $log->setLimit($this->limit);
@@ -128,18 +128,18 @@ 
 
 		// cache them for look up in byName
 		$builds = array();
-		foreach($limitedLog as $reference) {
-			if(!empty($this->blockBranch)) {
+		foreach ($limitedLog as $reference) {
+			if (!empty($this->blockBranch)) {
 				$branchesIncluding = GitonomyCache::getIncludingBranches($reference);
-				foreach($branchesIncluding as $candidate) {
-					if($candidate->getName() == $this->blockBranch) {
+				foreach ($branchesIncluding as $candidate) {
+					if ($candidate->getName() == $this->blockBranch) {
 						// Break out of the function
 						return $builds;
 					}
 				}
 			}
 
-			if($this->getTags) {
+			if ($this->getTags) {
 				$builds[] = DNTag::create($reference, $this->project, $this->data);
 			} else {
 				$name = $this->reference ? $this->reference->getName() : '';
@@ -157,7 +157,7 @@ 
 	 * @return DNCommit
 	 */
 	public function byName($hash) {
-		if($this->loaded === false) {
+		if ($this->loaded === false) {
 			$this->items = $this->getReferences();
 			$this->loaded = true;
 		}
@@ -165,14 +165,14 @@ 
 		// The item might not be in the list because of the limit, try to find
 		// in an older version and add it to the list.
 		$found = null;
-		foreach($this->items as $item) {
-			if($item->SHA() == $hash) {
+		foreach ($this->items as $item) {
+			if ($item->SHA() == $hash) {
 				$found = $item;
 				break;
 			}
 		}
 
-		if($found === null) {
+		if ($found === null) {
 			$repository = new Gitonomy\Git\Repository($this->project->getLocalCVSPath());
 			$commit = new Gitonomy\Git\Commit($repository, $hash);
 			$found = DNCommit::create($commit, $this->project, $this->data);
@@ -193,12 +193,12 @@ 
 	 * @return ArrayIterator
 	 */
 	public function getIterator() {
-		if($this->loaded === false) {
+		if ($this->loaded === false) {
 			$this->items = $this->getReferences();
 			$this->loaded = true;
 		}
-		foreach($this->items as $item) {
-			if(is_array($item)) {
+		foreach ($this->items as $item) {
+			if (is_array($item)) {
 				$this->items[] = new ArrayData($item);
 			}
 		}