Completed
Push — master ( 077859...60e689 )
by Mateusz
07:31
created
code/backends/DemoDeploymentBackend.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 
42 42
 		$file = sprintf('%s/%s.deploy-history.txt', DEPLOYNAUT_LOG_PATH, $environment->getFullName());
43 43
 		$CLI_file = escapeshellarg($file);
44
-		$CLI_line = escapeshellarg(date('Y-m-d H:i:s') . " => $sha");
44
+		$CLI_line = escapeshellarg(date('Y-m-d H:i:s')." => $sha");
45 45
 
46 46
 		// Put maintenance page up
47 47
 		$this->enableMaintenance($environment, $log, $project);
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 		$log->write("Well, that was a waste of time");
55 55
 
56 56
 		// Once the deployment has run it's necessary to update the maintenance page status
57
-		if(!empty($options['leaveMaintenancePage'])) {
57
+		if (!empty($options['leaveMaintenancePage'])) {
58 58
 			$this->enableMaintenance($environment, $log, $project);
59 59
 		} else {
60 60
 			// Remove maintenance page if we want it to
Please login to merge, or discard this patch.
code/backends/DeploymentStrategy.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
110 110
 		// Normalise "empty" values into dashes so comparisons are done properly.
111 111
 		// This means there is no diference between an empty string and a null
112 112
 		// but "0" is considered to be non-empty.
113
-		if(empty($from) && !strlen($from)) $from = '-';
114
-		if(empty($to) && !strlen($to)) $to = '-';
113
+		if (empty($from) && !strlen($from)) $from = '-';
114
+		if (empty($to) && !strlen($to)) $to = '-';
115 115
 
116 116
 		return $this->changes[$title] = array(
117 117
 			'from' => $from,
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 	 */
171 171
 	public function getChange($key) {
172 172
 		$changes = $this->getChanges();
173
-		if(array_key_exists($key, $changes)) {
173
+		if (array_key_exists($key, $changes)) {
174 174
 			return new ArrayData($changes[$key]);
175 175
 		}
176 176
 		return null;
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 	 * @return string|null
190 190
 	 */
191 191
 	public function getOption($option) {
192
-		if(!empty($this->options[$option])) {
192
+		if (!empty($this->options[$option])) {
193 193
 			return $this->options[$option];
194 194
 		}
195 195
 	}
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 			DeploymentStrategy::WARNING_CODE => 1,
231 231
 			DeploymentStrategy::ERROR_CODE => 2
232 232
 		];
233
-		if($map[$current] < $map[$code]) {
233
+		if ($map[$current] < $map[$code]) {
234 234
 			$this->setValidationCode($code);
235 235
 		}
236 236
 	}
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 		);
260 260
 
261 261
 		$output = array();
262
-		foreach($fields as $field) {
262
+		foreach ($fields as $field) {
263 263
 			$output[$field] = $this->$field;
264 264
 		}
265 265
 		return $output;
@@ -300,8 +300,8 @@  discard block
 block discarded – undo
300 300
 			'messages'
301 301
 		);
302 302
 
303
-		foreach($fields as $field) {
304
-			if(!empty($data[$field])) {
303
+		foreach ($fields as $field) {
304
+			if (!empty($data[$field])) {
305 305
 				$this->$field = $data[$field];
306 306
 			}
307 307
 		}
Please login to merge, or discard this patch.
code/events/GenericEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 	 * @return string
71 71
 	 */
72 72
 	public function get($keyname) {
73
-		if(array_key_exists($keyname, $this->data)) {
73
+		if (array_key_exists($keyname, $this->data)) {
74 74
 			return $this->data[$keyname];
75 75
 		}
76 76
 		return '';
Please login to merge, or discard this patch.
code/api/nouns/APINoun.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 	 */
60 60
 	protected function getAPIResponse($output) {
61 61
 		$response = $this->getResponse();
62
-		if($this->respondWithText()) {
62
+		if ($this->respondWithText()) {
63 63
 			$body = print_r($output, true);
64 64
 			$response->addHeader('Content-Type', 'text/plain');
65 65
 		} else {
@@ -74,10 +74,10 @@  discard block
 block discarded – undo
74 74
 	 * @return boolean
75 75
 	 */
76 76
 	protected function respondWithJSON() {
77
-		if($this->getRequest()->getExtension() == 'json') {
77
+		if ($this->getRequest()->getExtension() == 'json') {
78 78
 			return true;
79 79
 		}
80
-		if(strpos($this->getRequest()->getHeader('Accept'), 'application/json') !== false) {
80
+		if (strpos($this->getRequest()->getHeader('Accept'), 'application/json') !== false) {
81 81
 			return true;
82 82
 		}
83 83
 		return false;
@@ -87,10 +87,10 @@  discard block
 block discarded – undo
87 87
 	 * @return boolean
88 88
 	 */
89 89
 	protected function respondWithText() {
90
-		if($this->getRequest()->getExtension() == 'txt') {
90
+		if ($this->getRequest()->getExtension() == 'txt') {
91 91
 			return true;
92 92
 		}
93
-		if(strpos($this->getRequest()->getHeader('Accept'), 'text/plain') !== false) {
93
+		if (strpos($this->getRequest()->getHeader('Accept'), 'text/plain') !== false) {
94 94
 			return true;
95 95
 		}
96 96
 		return false;
Please login to merge, or discard this patch.
code/api/nouns/APIProject.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -15,11 +15,11 @@  discard block
 block discarded – undo
15 15
 	 * @return SS_HTTPResponse
16 16
 	 */
17 17
 	public function index(SS_HTTPRequest $request) {
18
-		if(!$this->record->canView($this->getMember())) {
18
+		if (!$this->record->canView($this->getMember())) {
19 19
 			return $this->message('You are not authorized to this environment', 403);
20 20
 		}
21 21
 
22
-		switch($request->httpMethod()) {
22
+		switch ($request->httpMethod()) {
23 23
 			case 'GET':
24 24
 				$response = array(
25 25
 					"name" => $this->record->Name,
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 					"disk-quota-mb" => $this->record->DiskQuotaMB,
30 30
 					"environments" => array(),
31 31
 				);
32
-				foreach($this->record->DNEnvironmentList() as $environment) {
32
+				foreach ($this->record->DNEnvironmentList() as $environment) {
33 33
 					$response['environments'][] = array(
34 34
 						'name' => $environment->Name,
35 35
 						'href' => Director::absoluteURL($this->record->APILink($environment->Name)),
@@ -47,10 +47,10 @@  discard block
 block discarded – undo
47 47
 	 * @return SS_HTTPResponse
48 48
 	 */
49 49
 	public function fetch(SS_HTTPRequest $request) {
50
-		if(!$this->record->canView($this->getMember())) {
50
+		if (!$this->record->canView($this->getMember())) {
51 51
 			return $this->message('You are not authorized to do that on this environment', 403);
52 52
 		}
53
-		switch($request->httpMethod()) {
53
+		switch ($request->httpMethod()) {
54 54
 			case 'GET':
55 55
 				return $this->getFetch($this->getRequest()->param('ID'));
56 56
 			case 'POST':
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 */
67 67
 	protected function getFetch($ID) {
68 68
 		$ping = DNGitFetch::get()->byID($ID);
69
-		if(!$ping) {
69
+		if (!$ping) {
70 70
 			return $this->message('Fetch not found', 404);
71 71
 		}
72 72
 		$output = array(
@@ -87,9 +87,9 @@  discard block
 block discarded – undo
87 87
 		$fetch->write();
88 88
 		$fetch->start();
89 89
 
90
-		$location = Director::absoluteBaseURL() . $this->Link() . '/fetch/' . $fetch->ID;
90
+		$location = Director::absoluteBaseURL().$this->Link().'/fetch/'.$fetch->ID;
91 91
 		$output = array(
92
-			'message' => 'Fetch queued as job ' . $fetch->ResqueToken,
92
+			'message' => 'Fetch queued as job '.$fetch->ResqueToken,
93 93
 			'href' => $location,
94 94
 		);
95 95
 
Please login to merge, or discard this patch.
code/api/nouns/APIEnvironment.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -15,10 +15,10 @@  discard block
 block discarded – undo
15 15
 	 * @return SS_HTTPResponse
16 16
 	 */
17 17
 	public function index(SS_HTTPRequest $request) {
18
-		if(!$this->record->canView($this->getMember())) {
18
+		if (!$this->record->canView($this->getMember())) {
19 19
 			return $this->message('You are not authorized to view this environment', 403);
20 20
 		}
21
-		switch($request->httpMethod()) {
21
+		switch ($request->httpMethod()) {
22 22
 			case 'GET':
23 23
 				$href = Director::absoluteURL($this->record->Project()->APILink($this->record->Name));
24 24
 				return $this->getAPIResponse(array(
@@ -51,10 +51,10 @@  discard block
 block discarded – undo
51 51
 	 * @return SS_HTTPResponse
52 52
 	 */
53 53
 	public function ping(SS_HTTPRequest $request) {
54
-		if(!$this->record->canView($this->getMember())) {
54
+		if (!$this->record->canView($this->getMember())) {
55 55
 			return $this->message('You are not authorized to do that on this environment', 403);
56 56
 		}
57
-		switch($request->httpMethod()) {
57
+		switch ($request->httpMethod()) {
58 58
 			case 'GET':
59 59
 				return $this->getPing($this->getRequest()->param('ID'));
60 60
 			case 'POST':
@@ -71,10 +71,10 @@  discard block
 block discarded – undo
71 71
 	 * @return SS_HTTPResponse
72 72
 	 */
73 73
 	public function deploy(SS_HTTPRequest $request) {
74
-		if(!$this->record->canView($this->getMember())) {
74
+		if (!$this->record->canView($this->getMember())) {
75 75
 			return $this->message('You are not authorized to do that on this environment', 403);
76 76
 		}
77
-		switch($request->httpMethod()) {
77
+		switch ($request->httpMethod()) {
78 78
 			case 'GET':
79 79
 				return $this->getDeploy($this->getRequest()->param('ID'));
80 80
 			case 'POST':
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 	 * @return SS_HTTPResponse
107 107
 	 */
108 108
 	protected function createPing() {
109
-		if(!$this->record->canDeploy($this->getMember())) {
109
+		if (!$this->record->canDeploy($this->getMember())) {
110 110
 			return $this->message('You are not authorized to do that on this environment', 403);
111 111
 		}
112 112
 		$ping = DNPing::create();
@@ -114,9 +114,9 @@  discard block
 block discarded – undo
114 114
 		$ping->write();
115 115
 		$ping->start();
116 116
 
117
-		$location = Director::absoluteBaseURL() . $this->Link() . '/ping/' . $ping->ID;
117
+		$location = Director::absoluteBaseURL().$this->Link().'/ping/'.$ping->ID;
118 118
 		$output = array(
119
-			'message' => 'Ping queued as job ' . $ping->ResqueToken,
119
+			'message' => 'Ping queued as job '.$ping->ResqueToken,
120 120
 			'href' => $location,
121 121
 		);
122 122
 
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 	 */
133 133
 	protected function getPing($ID) {
134 134
 		$ping = DNPing::get()->byID($ID);
135
-		if(!$ping) {
135
+		if (!$ping) {
136 136
 			return $this->message('Ping not found', 404);
137 137
 		}
138 138
 		$output = array(
@@ -149,17 +149,17 @@  discard block
 block discarded – undo
149 149
 	 * @return SS_HTTPResponse
150 150
 	 */
151 151
 	protected function createDeploy() {
152
-		if(!$this->record->canDeploy($this->getMember())) {
152
+		if (!$this->record->canDeploy($this->getMember())) {
153 153
 			return $this->message('You are not authorized to do that on this environment', 403);
154 154
 		}
155 155
 
156 156
 		$reqBody = $this->getRequestBody();
157 157
 
158
-		if($reqBody === null) {
158
+		if ($reqBody === null) {
159 159
 			return $this->message('the request body did not contain a valid JSON object.', 400);
160 160
 		}
161 161
 
162
-		if(empty($reqBody['release'])) {
162
+		if (empty($reqBody['release'])) {
163 163
 			return $this->message('deploy requires a {"release": "sha1"} in the body of the request.', 400);
164 164
 		}
165 165
 
@@ -168,9 +168,9 @@  discard block
 block discarded – undo
168 168
 		));
169 169
 		$deploy = $strategy->createDeployment();
170 170
 		$deploy->start();
171
-		$location = Director::absoluteBaseURL() . $this->Link() . '/deploy/' . $deploy->ID;
171
+		$location = Director::absoluteBaseURL().$this->Link().'/deploy/'.$deploy->ID;
172 172
 		$output = array(
173
-			'message' => 'Deploy queued as job ' . $deploy->ResqueToken,
173
+			'message' => 'Deploy queued as job '.$deploy->ResqueToken,
174 174
 			'href' => $location,
175 175
 		);
176 176
 		$response = $this->getAPIResponse($output);
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 	 */
188 188
 	protected function getDeploy($id) {
189 189
 		$deploy = DNDeployment::get()->byID($id);
190
-		if(!$deploy) {
190
+		if (!$deploy) {
191 191
 			return $this->message('Deploy not found', 404);
192 192
 		}
193 193
 		$output = array(
Please login to merge, or discard this patch.
code/api/DeploynautAPI.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -51,12 +51,12 @@  discard block
 block discarded – undo
51 51
 			'projects' => array(),
52 52
 		);
53 53
 
54
-		if($request->httpMethod() != 'GET') {
54
+		if ($request->httpMethod() != 'GET') {
55 55
 			return $this->message('API not found', 404);
56 56
 		}
57 57
 
58
-		foreach(DNProject::get() as $item) {
59
-			if($item->canView($this->getMember())) {
58
+		foreach (DNProject::get() as $item) {
59
+			if ($item->canView($this->getMember())) {
60 60
 				$response['projects'][] = array(
61 61
 					"name" => $item->Name,
62 62
 					"href" => Director::absoluteURL($item->APILink("")),
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	 */
76 76
 	public function project(SS_HTTPRequest $request) {
77 77
 		$project = $this->getProject();
78
-		if(!$project) {
78
+		if (!$project) {
79 79
 			return $this->project404Response();
80 80
 		}
81 81
 		return new APIProject($this, $project);
@@ -89,12 +89,12 @@  discard block
 block discarded – undo
89 89
 	 */
90 90
 	public function environment(SS_HTTPRequest $request) {
91 91
 		$project = $this->getProject();
92
-		if(!$project) {
92
+		if (!$project) {
93 93
 			return $this->project404Response();
94 94
 		}
95 95
 
96 96
 		$environment = $this->getEnvironment();
97
-		if(!$environment) {
97
+		if (!$environment) {
98 98
 			return $this->environment404Response();
99 99
 		}
100 100
 		return new APIEnvironment($this, $environment);
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 	 */
106 106
 	protected function project404Response() {
107 107
 		$projectName = Convert::raw2xml($this->getRequest()->latestParam('Project'));
108
-		return new SS_HTTPResponse('Project "' . $projectName . '" not found.', 404);
108
+		return new SS_HTTPResponse('Project "'.$projectName.'" not found.', 404);
109 109
 	}
110 110
 
111 111
 	/**
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 	 */
114 114
 	protected function environment404Response() {
115 115
 		$envName = Convert::raw2xml($this->getRequest()->latestParam('Environment'));
116
-		return new SS_HTTPResponse('Environment "' . $envName . '" not found.', 404);
116
+		return new SS_HTTPResponse('Environment "'.$envName.'" not found.', 404);
117 117
 	}
118 118
 
119 119
 	/**
Please login to merge, or discard this patch.
code/tasks/MigrateDeploymentStatusTask.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@
 block discarded – undo
4 4
 
5 5
 	public function run($request) {
6 6
 		$log = function($message) {
7
-			$message = sprintf('[%s] ', date('Y-m-d H:i:s')) . $message;
8
-			echo $message . PHP_EOL;
7
+			$message = sprintf('[%s] ', date('Y-m-d H:i:s')).$message;
8
+			echo $message.PHP_EOL;
9 9
 		};
10 10
 
11 11
 		if (!Director::is_cli()) {
Please login to merge, or discard this patch.
code/model/GitonomyCache.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -7,8 +7,8 @@
 block discarded – undo
7 7
 	public static $cache = array();
8 8
 
9 9
 	public static function getIncludingBranches($commit) {
10
-		$cacheKey = 'getIncludingBranches-' . $commit->getRepository()->getPath() . '-' . $commit->gethash();
11
-		if(!isset(self::$cache[$cacheKey])) {
10
+		$cacheKey = 'getIncludingBranches-'.$commit->getRepository()->getPath().'-'.$commit->gethash();
11
+		if (!isset(self::$cache[$cacheKey])) {
12 12
 			self::$cache[$cacheKey] = $commit->getIncludingBranches();
13 13
 		}
14 14
 		return self::$cache[$cacheKey];
Please login to merge, or discard this patch.