DNDeploymentDispatcher

Complexity

Total Complexity

12

Size/Duplication

Total Lines	92
Duplicated Lines	18.48 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getModel()	0	7	1
A	apply()	0	19	3
A	canApply()	17	17	3
B	getMachine()	0	29	5

<?php

use Finite\StateMachine\StateMachine;

class DNDeploymentDispatcher extends Dispatcher {

	const ALLOW_DNDEPLOYMENT_APPROVE = 'ALLOW_DNDEPLOYMENT_APPROVE';
	const ALLOW_DNDEPLOYMENT_QUEUE = 'ALLOW_DNDEPLOYMENT_QUEUE';

	private static $allowed_actions = [
		'apply',
		'canApply',
	];

	private static $url_handlers = [
		'$Id/apply/$State' => 'apply',
		'$Id/can/$State' => 'canApply',
	];

	public function getModel($name) {
		$id = $this->request->param('Id');
		$deployment = DNDeployment::get()->byId($id);
		return [
			'Status' => $deployment->Status
		];
	}

	public function apply(SS_HTTPRequest $request) {
		$this->checkSecurityToken();

		$project = $this->getCurrentProject();
		if(!$project) {
			return $this->project404Response();
		}

		$env = $this->getCurrentEnvironment($project);
		if(!$env) {
			return $this->environment404Response();
		}

		$machine = $this->getMachine();
		$machine->apply($request->param('State'));

		$model = $this->getModel('DNDeployment');
		return $this->asJSON($model);
	}

	public function canApply(SS_HTTPRequest $request) {

This method seems to be duplicated in your project.

		$this->checkSecurityToken();

		$project = $this->getCurrentProject();
		if(!$project) {
			return $this->project404Response();
		}

		$env = $this->getCurrentEnvironment($project);
		if(!$env) {
			return $this->environment404Response();
		}

		return $this->asJSON([
			'Can' => $this->getMachine()->can($request->param('State'))
		]);
	}

	private function getMachine() {
		$id = $this->request->param('Id');
		$deployment = DNDeployment::get()->byId($id);
		$project = $deployment->Environment()->Project();
		$machine = $deployment->getMachine();

		// Map authorisation rules to selected transitions.
		$machine->getDispatcher()->addListener(
			'finite.test_transition',
			function (Finite\Event\TransitionEvent $e) use ($project) {
				$code = null;

				switch ($e->getTransition()->getName()) {
				case 'approve':
					$code = self::ALLOW_DNDEPLOYMENT_APPROVE;
					break;
				case 'queue':
					$code = self::ALLOW_DNDEPLOYMENT_QUEUE;
					break;
				}

				if (!$code || !$project->allowed($code)) {

The expression $code of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

					$e->reject();
				}
			}
		);

		return $machine;
	}

}