silverstripe / deploynaut

code/model/steps/SmokeTestPipelineStep.php

Braces +9 added lines, -3 removed lines

@@ -74,7 +74,9 @@ 
 		} elseif(!$tests && $defaultTests) {
 			$tests = $defaultTests;
 		}
-		if($tests) return $tests;
+		if($tests) {
+			return $tests;
+		}
 
 		// if there's no tests to check for, fallback to trying to find the
 		// site's homepage by looking at the DNEnvironment fields.
@@ -126,7 +128,9 @@ 
 
 		// Allow individual tests to override number of attempts
 		$attempts = (int) $this->getConfigSetting('Attempts');
-		if(!empty($test['Attempts'])) $attempts = $test['Attempts'];
+		if(!empty($test['Attempts'])) {
+			$attempts = $test['Attempts'];
+		}
 
 		// Run through each attempt
 		for($i = 0; $i < $attempts; $i++) {
@@ -189,7 +193,9 @@ 
 		}
 
 		// Run out of re-attempts
-		if($attempts > 1) $this->log("Failed after {$attempts} attempts");
+		if($attempts > 1) {
+			$this->log("Failed after {$attempts} attempts");
+		}
  		return false;
 	}
 

code/model/steps/TriggerDeployStep.php

Braces +6 added lines, -2 removed lines

@@ -103,7 +103,9 @@ 
 	 */
 	public function StartDeployment() {
 		$this->Status = 'Started';
-		if (!$this->Started) $this->Started = SS_Datetime::now()->Rfc2822();
+		if (!$this->Started) {
+			$this->Started = SS_Datetime::now()->Rfc2822();
+		}
 		$this->log("Starting {$this->Title}...");
 		$this->write();
 		return true;
@@ -111,7 +113,9 @@ 
 
 	public function getRunningDescription() {
 		// Don't show options if this step has already been confirmed
-		if($this->Deployed) return;
+		if($this->Deployed) {
+			return;
+		}
 
 		return _t('TriggerDeployStep.RUNNINGDESCRIPTION',
 			'Please press the "Deploy" button to continue deployment');

code/model/steps/UserConfirmationStep.php

Braces +9 added lines, -3 removed lines

@@ -179,7 +179,9 @@ 
 		}
 
 		// Skip subsequent approvals if already approved / rejected
-		if($this->hasResponse()) return;
+		if($this->hasResponse()) {
+			return;
+		}
 
 		// Approve
 		$this->Approval = 'Approved';
@@ -205,7 +207,9 @@ 
 		}
 
 		// Skip subsequent approvals if already approved / rejected
-		if($this->hasResponse()) return;
+		if($this->hasResponse()) {
+			return;
+		}
 
 		// Reject
 		$this->Approval = 'Rejected';
@@ -363,7 +367,9 @@ 
 	public function getRunningDescription() {
 
 		// Don't show options if this step has already been confirmed
-		if($this->hasResponse() || !$this->isRunning()) return;
+		if($this->hasResponse() || !$this->isRunning()) {
+			return;
+		}
 
 		return 'This deployment is currently awaiting approval before it can complete.';
 	}