Complex classes like DeploymentStrategy often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DeploymentStrategy, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
3 | class DeploymentStrategy extends ViewableData { |
||
4 | |||
5 | const SUCCESS_CODE = 'success'; |
||
6 | |||
7 | const WARNING_CODE = 'warning'; |
||
8 | |||
9 | const ERROR_CODE = 'error'; |
||
10 | |||
11 | /** |
||
12 | * @var DNEnvironment |
||
13 | */ |
||
14 | protected $environment; |
||
15 | |||
16 | /** |
||
17 | * @var string |
||
18 | */ |
||
19 | protected $actionTitle = 'Deploy'; |
||
20 | |||
21 | /** |
||
22 | * @var string |
||
23 | */ |
||
24 | protected $actionCode = 'default'; |
||
25 | |||
26 | /** |
||
27 | * @var int |
||
28 | */ |
||
29 | protected $estimatedTime = 0; |
||
30 | |||
31 | /** |
||
32 | * @var array |
||
33 | */ |
||
34 | protected $changes = []; |
||
35 | |||
36 | /** |
||
37 | * @var array |
||
38 | */ |
||
39 | protected $options; |
||
40 | |||
41 | /** |
||
42 | * Validation code |
||
43 | * |
||
44 | * @var string |
||
45 | */ |
||
46 | protected $validationCode = DeploymentStrategy::SUCCESS_CODE; |
||
47 | |||
48 | /** |
||
49 | * @var array |
||
50 | */ |
||
51 | protected $messages = []; |
||
52 | |||
53 | |||
54 | /** |
||
55 | * @param DNEnvironment $environment |
||
56 | * @param array $options |
||
57 | */ |
||
58 | public function __construct(DNEnvironment $environment, $options = array()) { |
||
62 | |||
63 | /** |
||
64 | * @param string $title |
||
65 | */ |
||
66 | public function setActionTitle($title) { |
||
69 | |||
70 | /** |
||
71 | * @return string |
||
72 | */ |
||
73 | public function getActionTitle() { |
||
76 | |||
77 | /** |
||
78 | */ |
||
79 | public function setActionCode($code) { |
||
82 | |||
83 | /** |
||
84 | * @return string |
||
85 | */ |
||
86 | public function getActionCode() { |
||
89 | |||
90 | /** |
||
91 | * @param int |
||
92 | */ |
||
93 | public function setEstimatedTime($seconds) { |
||
96 | |||
97 | /** |
||
98 | * @return int Time in minutes |
||
99 | */ |
||
100 | public function getEstimatedTime() { |
||
103 | |||
104 | /** |
||
105 | * @param string $title |
||
106 | * @param string $from |
||
107 | * @param string $to |
||
108 | */ |
||
109 | public function setChange($title, $from, $to) { |
||
110 | return $this->changes[$title] = array( |
||
111 | 'from' => $from, |
||
112 | 'to' => $to |
||
113 | ); |
||
114 | } |
||
115 | |||
116 | /** |
||
117 | * @param string $title |
||
118 | * @param string $desc |
||
119 | */ |
||
120 | public function setChangeDescriptionOnly($title, $desc) { |
||
125 | |||
126 | /** |
||
127 | * Filter the changeset where modification was not required. |
||
128 | * |
||
129 | * @return array |
||
130 | */ |
||
131 | public function getChangesModificationNeeded() { |
||
146 | |||
147 | /** |
||
148 | * @return array Associative array of changes, e.g. |
||
149 | * array( |
||
150 | * 'SHA' => array( |
||
151 | * 'from' => 'abc', |
||
152 | * 'to' => 'def' |
||
153 | * ) |
||
154 | * ) |
||
155 | */ |
||
156 | public function getChanges() { |
||
170 | |||
171 | /** |
||
172 | * Returns a change or a given key. |
||
173 | * |
||
174 | * @return ArrayData|null |
||
175 | */ |
||
176 | public function getChange($key) { |
||
183 | |||
184 | /** |
||
185 | * @param string $option |
||
186 | * @param string $value |
||
187 | */ |
||
188 | public function setOption($option, $value) { |
||
191 | |||
192 | /** |
||
193 | * @param string $option |
||
194 | * @return string|null |
||
195 | */ |
||
196 | public function getOption($option) { |
||
201 | |||
202 | /** |
||
203 | * @return string |
||
204 | */ |
||
205 | public function getOptions() { |
||
208 | |||
209 | /** |
||
210 | * @param string $code |
||
211 | */ |
||
212 | public function setValidationCode($code) { |
||
215 | |||
216 | /** |
||
217 | * @return string |
||
218 | */ |
||
219 | public function getValidationCode() { |
||
222 | |||
223 | /** |
||
224 | * @param string $msg |
||
225 | */ |
||
226 | public function setMessage($msg, $code = self::ERROR_CODE) { |
||
242 | |||
243 | /** |
||
244 | * @return array |
||
245 | */ |
||
246 | public function getMessages() { |
||
249 | |||
250 | /** |
||
251 | * Transform the deployment strategy to an array. |
||
252 | * |
||
253 | * @return array |
||
254 | */ |
||
255 | public function toArray() { |
||
276 | |||
277 | /** |
||
278 | * @return string |
||
279 | */ |
||
280 | public function toJSON() { |
||
283 | |||
284 | /** |
||
285 | * Load from JSON associative array. |
||
286 | * Environment must be set by the callee when creating this object. |
||
287 | * |
||
288 | * @param string $json |
||
289 | */ |
||
290 | public function fromJSON($json) { |
||
294 | |||
295 | /** |
||
296 | * Load from array. |
||
297 | * Environment must be set by the callee when creating this object. |
||
298 | * |
||
299 | * @param string $data |
||
300 | */ |
||
301 | public function fromArray($data) { |
||
318 | |||
319 | /** |
||
320 | * @return DNDeployment |
||
321 | */ |
||
322 | public function createDeployment() { |
||
332 | |||
333 | } |
||
334 | |||
335 |
Since your code implements the magic setter
_set
, this function will be called for any write access on an undefined variable. You can add the@property
annotation to your class or interface to document the existence of this variable.Since the property has write access only, you can use the @property-write annotation instead.
Of course, you may also just have mistyped another name, in which case you should fix the error.
See also the PhpDoc documentation for @property.