silverstripe / deploynaut

code/backends/DeploymentStrategy.php

Doc Comments +2 added lines

@@ -75,6 +75,7 @@ 
 	}
 
 	/**
+	 * @param string $code
 	 */
 	public function setActionCode($code) {
 		$this->actionCode = $code;
@@ -89,6 +90,7 @@ 
 
 	/**
 	 * @param int
+	 * @param string $seconds
 	 */
 	public function setEstimatedTime($seconds) {
 		$this->estimatedTime = $seconds;

Braces +6 added lines, -2 removed lines

@@ -110,8 +110,12 @@
 		// Normalise "empty" values into dashes so comparisons are done properly.
 		// This means there is no diference between an empty string and a null
 		// but "0" is considered to be non-empty.
-		if(empty($from) && !strlen($from)) $from = '-';
-		if(empty($to) && !strlen($to)) $to = '-';
+		if(empty($from) && !strlen($from)) {
+			$from = '-';
+		}
+		if(empty($to) && !strlen($to)) {
+			$to = '-';
+		}
 
 		return $this->changes[$title] = array(
 			'from' => $from,

code/control/DNRoot.php

Doc Comments +1 added lines, -1 removed lines

@@ -961,7 +961,7 @@
 	 * @param array $data
 	 * @param Form $form
 	 *
-	 * @return bool|HTMLText|SS_HTTPResponse
+	 * @return SS_HTTPResponse|null
 	 */
 	public function doCreateEnvironment($data, Form $form) {
 		$this->setCurrentActionType(self::ACTION_ENVIRONMENTS);

code/model/jobs/DNDeployment.php

Braces +6 added lines, -2 removed lines

@@ -205,12 +205,16 @@
 	 */
 	public function getFullDeployMessages() {
 		$strategy = $this->getDeploymentStrategy();
-		if ($strategy->getActionCode()!=='full') return null;
+		if ($strategy->getActionCode()!=='full') {
+			return null;
+		}
 
 		$changes = $strategy->getChangesModificationNeeded();
 		$messages = [];
 		foreach ($changes as $change => $details) {
-			if ($change==='Code version') continue;
+			if ($change==='Code version') {
+				continue;
+			}
 
 			$messages[] = [
 				'Flag' => sprintf(

Doc Comments +3 added lines

@@ -82,6 +82,9 @@
 		'Deployer.Name' => 'Deployer'
 	);
 
+	/**
+	 * @param false|string $token
+	 */
 	public function setResqueToken($token) {
 		$this->ResqueToken = $token;
 	}

code/model/StateMachineFactory.php

Braces +3 added lines, -1 removed lines

@@ -58,7 +58,9 @@
 
 	protected function addHandlers($machine) {
 		$class = get_class($machine->getObject());
-		if (empty($this->config()->handlers[$class])) return;
+		if (empty($this->config()->handlers[$class])) {
+			return;
+		}
 
 		$transitions = $this->config()->handlers[$class];
 		foreach ($transitions as $transName => $handlers) {

code/control/DeployDispatcher.php

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 	 *
 	 * @param \SS_HTTPRequest $request
 	 *
-	 * @return \HTMLText|\SS_HTTPResponse
+	 * @return SS_HTTPResponse|null
 	 */
 	public function index(\SS_HTTPRequest $request) {
 		return $this->redirect(\Controller::join_links($this->Link(), 'history'), 302);

code/control/GitDispatcher.php

Doc Comments +5 added lines, -5 removed lines

@@ -47,7 +47,7 @@ 
 	 *
 	 * @param \SS_HTTPRequest $request
 	 *
-	 * @return \HTMLText|\SS_HTTPResponse
+	 * @return SS_HTTPResponse|null
 	 */
 	public function index(\SS_HTTPRequest $request) {
 		return $this->redirect(\Controller::join_links($this->Link(), 'show'), 302);
@@ -72,7 +72,7 @@ 
 	/**
 	 * @param SS_HTTPRequest $request
 	 *
-	 * @return string
+	 * @return SS_HTTPResponse
 	 */
 	public function show(\SS_HTTPRequest $request) {
 
@@ -166,7 +166,7 @@ 
 	}
 
 	/**
-	 * @param $project
+	 * @param DNProject $project
 	 *
 	 * @return array
 	 */
@@ -182,7 +182,7 @@ 
 	}
 
 	/**
-	 * @param $project
+	 * @param DNProject $project
 	 *
 	 * @return array
 	 */
@@ -198,7 +198,7 @@ 
 	}
 
 	/**
-	 * @param $project
+	 * @param DNProject $project
 	 *
 	 * @return array
 	 */

code/extensions/TimezoneMemberExtension.php

Braces +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 		return array_combine($timezones, $timezones);
 	}
 
-	public function updateCMSFields(FieldList $fields) {   
+	public function updateCMSFields(FieldList $fields) {
 		$fields->removeFieldFromTab('Root', 'Timezone');
 		$field = DropdownField::create(
 		  'Timezone',

code/SS_Datetimezone.php

Braces +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 	* Returns the date in the raw SQL-format specific to a given timezone passed from the Member class, e.g. “2006-01-18 16:32:04”
 	*/
 	public function Format($format) {
-		if($this->value){
+		if($this->value) {
 			$date = new DateTime($this->value);
 			//if the current user has set a timezone that is not the default then use that
 			$member = Member::currentUser();

code/model/DNEnvironment.php

Doc Comments +1 added lines, -1 removed lines

@@ -670,7 +670,7 @@
 	/**
 	 * A list of past deployments.
 	 * @param string $orderBy - the name of a DB column to sort in descending order
-	 * @return \ArrayList
+	 * @return DataList
 	 */
 	public function DeployHistory($orderBy = '') {
 		$sort = [];