silverstripe / deploynaut

code/control/CheckPipelineStatus.php

Spacing +2 added lines, -2 removed lines

@@ -13,7 +13,7 @@ 
     public function index()
     {
         // @TODO Check that we have been called via the daemon
-        if (php_sapi_name() != "cli") {
+        if(php_sapi_name() != "cli") {
             throw new Exception("CheckPipelineStatus must be run from the command-line.");
         }
 
@@ -31,7 +31,7 @@ 
             $runningPipelines->count()
         );
 
-        foreach ($runningPipelines as $pipeline) {
+        foreach($runningPipelines as $pipeline) {
             $pipeline->checkPipelineStatus();
         }
 

code/control/DNRoot.php

Spacing +193 added lines, -193 removed lines

@@ -191,8 +191,8 @@ 
         Requirements::javascript('deploynaut/javascript/material.js');
 
         // Load the buildable dependencies only if not loaded centrally.
-        if (!is_dir(BASE_PATH . DIRECTORY_SEPARATOR . 'static')) {
-            if (\Director::isDev()) {
+        if(!is_dir(BASE_PATH . DIRECTORY_SEPARATOR . 'static')) {
+            if(\Director::isDev()) {
                 \Requirements::javascript('deploynaut/static/bundle-debug.js');
             } else {
                 \Requirements::javascript('deploynaut/static/bundle.js');
@@ -211,13 +211,13 @@ 
      */
     public static function FlagSnapshotsEnabled()
     {
-        if (defined('FLAG_SNAPSHOTS_ENABLED') && FLAG_SNAPSHOTS_ENABLED) {
+        if(defined('FLAG_SNAPSHOTS_ENABLED') && FLAG_SNAPSHOTS_ENABLED) {
             return true;
         }
-        if (defined('FLAG_SNAPSHOTS_ENABLED_FOR_MEMBERS') && FLAG_SNAPSHOTS_ENABLED_FOR_MEMBERS) {
+        if(defined('FLAG_SNAPSHOTS_ENABLED_FOR_MEMBERS') && FLAG_SNAPSHOTS_ENABLED_FOR_MEMBERS) {
             $allowedMembers = explode(';', FLAG_SNAPSHOTS_ENABLED_FOR_MEMBERS);
             $member = Member::currentUser();
-            if ($allowedMembers && $member && in_array($member->Email, $allowedMembers)) {
+            if($allowedMembers && $member && in_array($member->Email, $allowedMembers)) {
                 return true;
             }
         }
@@ -230,7 +230,7 @@ 
     public static function get_support_links()
     {
         $supportLinks = self::config()->support_links;
-        if ($supportLinks) {
+        if($supportLinks) {
             return new ArrayList($supportLinks);
         }
     }
@@ -254,7 +254,7 @@ 
     {
         parent::init();
 
-        if (!Member::currentUser() && !Session::get('AutoLoginHash')) {
+        if(!Member::currentUser() && !Session::get('AutoLoginHash')) {
             return Security::permissionFailure();
         }
 
@@ -341,11 +341,11 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
-        if (!$project->canBackup()) {
+        if(!$project->canBackup()) {
             return new SS_HTTPResponse("Not allowed to create snapshots on any environments", 401);
         }
 
@@ -368,11 +368,11 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
-        if (!$project->canUploadArchive()) {
+        if(!$project->canUploadArchive()) {
             return new SS_HTTPResponse("Not allowed to upload", 401);
         }
 
@@ -405,22 +405,22 @@ 
     {
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
-        if (!$project->canUploadArchive()) {
+        if(!$project->canUploadArchive()) {
             return new SS_HTTPResponse("Not allowed to upload", 401);
         }
 
         // Framing an environment as a "group of people with download access"
         // makes more sense to the user here, while still allowing us to enforce
         // environment specific restrictions on downloading the file later on.
-        $envs = $project->DNEnvironmentList()->filterByCallback(function ($item) {
+        $envs = $project->DNEnvironmentList()->filterByCallback(function($item) {
             return $item->canUploadArchive();
         });
         $envsMap = array();
-        foreach ($envs as $env) {
+        foreach($envs as $env) {
             $envsMap[$env->ID] = $env->Name;
         }
 
@@ -465,18 +465,18 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         $validEnvs = $project->DNEnvironmentList()
-            ->filterByCallback(function ($item) {
+            ->filterByCallback(function($item) {
                 return $item->canUploadArchive();
             });
 
         // Validate $data['EnvironmentID'] by checking against $validEnvs.
         $environment = $validEnvs->find('ID', $data['EnvironmentID']);
-        if (!$environment) {
+        if(!$environment) {
             throw new LogicException('Invalid environment');
         }
 
@@ -501,7 +501,7 @@ 
         $dataArchive->write();
         $workingDir = TEMP_FOLDER . DIRECTORY_SEPARATOR . 'deploynaut-transfer-' . $dataTransfer->ID;
 
-        $cleanupFn = function () use ($workingDir, $dataTransfer, $dataArchive) {
+        $cleanupFn = function() use ($workingDir, $dataTransfer, $dataArchive) {
             $process = new Process(sprintf('rm -rf %s', escapeshellarg($workingDir)));
             $process->run();
             $dataTransfer->delete();
@@ -511,7 +511,7 @@ 
         // extract the sspak contents so we can inspect them
         try {
             $dataArchive->extractArchive($workingDir);
-        } catch (Exception $e) {
+        } catch(Exception $e) {
             $cleanupFn();
             $form->sessionMessage(
                 'There was a problem trying to open your snapshot for processing. Please try uploading again',
@@ -522,7 +522,7 @@ 
 
         // validate that the sspak contents match the declared contents
         $result = $dataArchive->validateArchiveContents();
-        if (!$result->valid()) {
+        if(!$result->valid()) {
             $cleanupFn();
             $form->sessionMessage($result->message(), 'bad');
             return $this->redirectBack();
@@ -532,7 +532,7 @@ 
         try {
             $dataArchive->fixArchivePermissions($workingDir);
             $dataArchive->setArchiveFromFiles($workingDir);
-        } catch (Exception $e) {
+        } catch(Exception $e) {
             $cleanupFn();
             $form->sessionMessage(
                 'There was a problem processing your snapshot. Please try uploading again',
@@ -563,22 +563,22 @@ 
     {
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
-        if (!$project->canUploadArchive()) {
+        if(!$project->canUploadArchive()) {
             return new SS_HTTPResponse("Not allowed to upload", 401);
         }
 
         // Framing an environment as a "group of people with download access"
         // makes more sense to the user here, while still allowing us to enforce
         // environment specific restrictions on downloading the file later on.
-        $envs = $project->DNEnvironmentList()->filterByCallback(function ($item) {
+        $envs = $project->DNEnvironmentList()->filterByCallback(function($item) {
             return $item->canUploadArchive();
         });
         $envsMap = array();
-        foreach ($envs as $env) {
+        foreach($envs as $env) {
             $envsMap[$env->ID] = $env->Name;
         }
 
@@ -616,17 +616,17 @@ 
         $this->setCurrentActionType(self::ACTION_SNAPSHOT);
 
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
-        $validEnvs = $project->DNEnvironmentList()->filterByCallback(function ($item) {
+        $validEnvs = $project->DNEnvironmentList()->filterByCallback(function($item) {
                 return $item->canUploadArchive();
         });
 
         // Validate $data['EnvironmentID'] by checking against $validEnvs.
         $environment = $validEnvs->find('ID', $data['EnvironmentID']);
-        if (!$environment) {
+        if(!$environment) {
             throw new LogicException('Invalid environment');
         }
 
@@ -666,20 +666,20 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
-        if (!$project->canUploadArchive()) {
+        if(!$project->canUploadArchive()) {
             return new SS_HTTPResponse("Not allowed to upload", 401);
         }
 
         $dataArchive = DNDataArchive::get()->byId($request->param('DataArchiveID'));
-        if (!$dataArchive) {
+        if(!$dataArchive) {
             return new SS_HTTPResponse("Archive not found.", 404);
         }
 
-        if (!$dataArchive->canRestore()) {
+        if(!$dataArchive->canRestore()) {
             throw new SS_HTTPResponse_Exception('Not allowed to restore archive', 403);
         }
 
@@ -710,19 +710,19 @@ 
     public function toggleprojectstar(SS_HTTPRequest $request)
     {
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         $member = Member::currentUser();
-        if ($member === null) {
+        if($member === null) {
             return $this->project404Response();
         }
         $favProject = $member->StarredProjects()
             ->filter('DNProjectID', $project->ID)
             ->first();
 
-        if ($favProject) {
+        if($favProject) {
             $member->StarredProjects()->remove($favProject);
         } else {
             $member->StarredProjects()->add($project);
@@ -737,13 +737,13 @@ 
     public function branch(SS_HTTPRequest $request)
     {
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         $branchName = $request->getVar('name');
         $branch = $project->DNBranchList()->byName($branchName);
-        if (!$branch) {
+        if(!$branch) {
             return new SS_HTTPResponse("Branch '" . Convert::raw2xml($branchName) . "' not found.", 404);
         }
 
@@ -760,13 +760,13 @@ 
     {
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         // Performs canView permission check by limiting visible projects
         $env = $this->getCurrentEnvironment($project);
-        if (!$env) {
+        if(!$env) {
             return $this->environment404Response();
         }
 
@@ -816,17 +816,17 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         // Performs canView permission check by limiting visible projects
         $environment = $this->getCurrentEnvironment($project);
-        if (!$environment) {
+        if(!$environment) {
             return $this->environment404Response();
         }
 
-        if (!$environment->DryRunEnabled && $isDryRun) {
+        if(!$environment->DryRunEnabled && $isDryRun) {
             return new SS_HTTPResponse("Dry-run for pipelines is not enabled for this environment", 404);
         }
 
@@ -838,7 +838,7 @@ 
         $pipeline->AuthorID = Member::currentUserID();
         $pipeline->SHA = $sha->FullName();
         // Record build at time of execution
-        if ($currentBuild = $environment->CurrentBuild()) {
+        if($currentBuild = $environment->CurrentBuild()) {
             $pipeline->PreviousDeploymentID = $currentBuild->ID;
         }
         $pipeline->start(); // start() will call write(), so no need to do it here as well.
@@ -856,20 +856,20 @@ 
         $params = $request->params();
         $pipeline = Pipeline::get()->byID($params['Identifier']);
 
-        if (!$pipeline || !$pipeline->ID || !$pipeline->Environment()) {
+        if(!$pipeline || !$pipeline->ID || !$pipeline->Environment()) {
             throw new SS_HTTPResponse_Exception('Pipeline not found', 404);
         }
-        if (!$pipeline->Environment()->canView()) {
+        if(!$pipeline->Environment()->canView()) {
             return Security::permissionFailure();
         }
 
         $environment = $pipeline->Environment();
         $project = $pipeline->Environment()->Project();
 
-        if ($environment->Name != $params['Environment']) {
+        if($environment->Name != $params['Environment']) {
             throw new LogicException("Environment in URL doesn't match this pipeline");
         }
-        if ($project->Name != $params['Project']) {
+        if($project->Name != $params['Project']) {
             throw new LogicException("Project in URL doesn't match this pipeline");
         }
 
@@ -886,22 +886,22 @@ 
     public function createenv(SS_HTTPRequest $request)
     {
         $params = $request->params();
-        if ($params['Identifier']) {
+        if($params['Identifier']) {
             $record = DNCreateEnvironment::get()->byId($params['Identifier']);
 
-            if (!$record || !$record->ID) {
+            if(!$record || !$record->ID) {
                 throw new SS_HTTPResponse_Exception('Create environment not found', 404);
             }
-            if (!$record->canView()) {
+            if(!$record->canView()) {
                 return Security::permissionFailure();
             }
 
             $project = $this->getCurrentProject();
-            if (!$project) {
+            if(!$project) {
                 return $this->project404Response();
             }
 
-            if ($project->Name != $params['Project']) {
+            if($project->Name != $params['Project']) {
                 throw new LogicException("Project in URL doesn't match this creation");
             }
 
@@ -920,21 +920,21 @@ 
         $params = $request->params();
         $env = DNCreateEnvironment::get()->byId($params['Identifier']);
 
-        if (!$env || !$env->ID) {
+        if(!$env || !$env->ID) {
             throw new SS_HTTPResponse_Exception('Log not found', 404);
         }
-        if (!$env->canView()) {
+        if(!$env->canView()) {
             return Security::permissionFailure();
         }
 
         $project = $env->Project();
 
-        if ($project->Name != $params['Project']) {
+        if($project->Name != $params['Project']) {
             throw new LogicException("Project in URL doesn't match this deploy");
         }
 
         $log = $env->log();
-        if ($log->exists()) {
+        if($log->exists()) {
             $content = $log->content();
         } else {
             $content = 'Waiting for action to start';
@@ -952,27 +952,27 @@ 
         $this->setCurrentActionType(self::ACTION_ENVIRONMENTS);
 
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         $envType = $project->AllowedEnvironmentType;
-        if (!$envType || !class_exists($envType)) {
+        if(!$envType || !class_exists($envType)) {
             return null;
         }
 
         $backend = Injector::inst()->get($envType);
-        if (!($backend instanceof EnvironmentCreateBackend)) {
+        if(!($backend instanceof EnvironmentCreateBackend)) {
             // Only allow this for supported backends.
             return null;
         }
 
         $fields = $backend->getCreateEnvironmentFields($project);
-        if (!$fields) {
+        if(!$fields) {
             return null;
         }
 
-        if (!$project->canCreateEnvironments()) {
+        if(!$project->canCreateEnvironments()) {
             return new SS_HTTPResponse('Not allowed to create environments for this project', 401);
         }
 
@@ -1004,11 +1004,11 @@ 
         $this->setCurrentActionType(self::ACTION_ENVIRONMENTS);
 
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
-        if (!$project->canCreateEnvironments()) {
+        if(!$project->canCreateEnvironments()) {
             return new SS_HTTPResponse('Not allowed to create environments for this project', 401);
         }
 
@@ -1034,13 +1034,13 @@ 
     {
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         // Performs canView permission check by limiting visible projects
         $env = $this->getCurrentEnvironment($project);
-        if (!$env) {
+        if(!$env) {
             return $this->environment404Response();
         }
 
@@ -1065,11 +1065,11 @@ 
     public function DNProjectList()
     {
         $memberId = Member::currentUserID();
-        if (!$memberId) {
+        if(!$memberId) {
             return new ArrayList();
         }
 
-        if (Permission::check('ADMIN')) {
+        if(Permission::check('ADMIN')) {
             return DNProject::get();
         }
 
@@ -1084,7 +1084,7 @@ 
     public function getPlatformSpecificStrings()
     {
         $strings = $this->config()->platform_specific_strings;
-        if ($strings) {
+        if($strings) {
             return new ArrayList($strings);
         }
     }
@@ -1097,15 +1097,15 @@ 
     public function getStarredProjects()
     {
         $member = Member::currentUser();
-        if ($member === null) {
+        if($member === null) {
             return new ArrayList();
         }
 
         $favProjects = $member->StarredProjects();
 
         $list = new ArrayList();
-        foreach ($favProjects as $project) {
-            if ($project->canView($member)) {
+        foreach($favProjects as $project) {
+            if($project->canView($member)) {
                 $list->add($project);
             }
         }
@@ -1126,24 +1126,24 @@ 
         $currentProject = $this->getCurrentProject();
 
         $projects = $this->getStarredProjects();
-        if ($projects->count() < 1) {
+        if($projects->count() < 1) {
             $projects = $this->DNProjectList();
         } else {
             $limit = -1;
         }
 
-        if ($projects->count() > 0) {
+        if($projects->count() > 0) {
             $activeProject = false;
 
-            if ($limit > 0) {
+            if($limit > 0) {
                 $limitedProjects = $projects->limit($limit);
             } else {
                 $limitedProjects = $projects;
             }
 
-            foreach ($limitedProjects as $project) {
+            foreach($limitedProjects as $project) {
                 $isActive = $currentProject && $currentProject->ID == $project->ID;
-                if ($isActive) {
+                if($isActive) {
                     $activeProject = true;
                 }
 
@@ -1154,12 +1154,12 @@ 
             }
 
             // Ensure the current project is in the list
-            if (!$activeProject && $currentProject) {
+            if(!$activeProject && $currentProject) {
                 $navigation->unshift(array(
                     'Project' => $currentProject,
                     'IsActive' => true,
                 ));
-                if ($limit > 0 && $navigation->count() > $limit) {
+                if($limit > 0 && $navigation->count() > $limit) {
                     $navigation->pop();
                 }
             }
@@ -1178,17 +1178,17 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         // Performs canView permission check by limiting visible projects
         $environment = $this->getCurrentEnvironment($project);
-        if (!$environment) {
+        if(!$environment) {
             return $this->environment404Response();
         }
 
-        if (!$environment->canDeploy()) {
+        if(!$environment->canDeploy()) {
             return new SS_HTTPResponse("Not allowed to deploy", 401);
         }
 
@@ -1196,7 +1196,7 @@ 
         $form = new DeployForm($this, 'DeployForm', $environment, $project);
 
         // If this is an ajax request we don't want to submit the form - we just want to retrieve the markup.
-        if (
+        if(
             $request &&
             !$request->requestVar('action_showDeploySummary') &&
             $this->getRequest()->isAjax() &&
@@ -1225,19 +1225,19 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         // Performs canView permission check by limiting visible projects
         $env = $this->getCurrentEnvironment($project);
-        if (!$env) {
+        if(!$env) {
             return $this->environment404Response();
         }
 
         // For now only permit advanced options on one environment type, because we hacked the "full-deploy"
         // checkbox in. Other environments such as the fast or capistrano one wouldn't know what to do with it.
-        if (get_class($env) === 'RainforestEnvironment') {
+        if(get_class($env) === 'RainforestEnvironment') {
             $advanced = Permission::check('DEPLOYNAUT_ADVANCED_DEPLOY_OPTIONS') ? 'true' : 'false';
         } else {
             $advanced = 'false';
@@ -1254,7 +1254,7 @@ 
             'field_data' => array(),
             'advanced_opts' => $advanced
         );
-        foreach ($project->DNBranchList() as $branch) {
+        foreach($project->DNBranchList() as $branch) {
             $sha = $branch->SHA();
             $name = $branch->Name();
             $branchValue = sprintf("%s (%s, %s old)",
@@ -1279,7 +1279,7 @@ 
             'advanced_opts' => $advanced
         );
 
-        foreach ($project->DNTagList()->setLimit(null) as $tag) {
+        foreach($project->DNTagList()->setLimit(null) as $tag) {
             $name = $tag->Name();
             $data['field_data'][] = array(
                 'id' => $tag->SHA(),
@@ -1305,15 +1305,15 @@ 
         // We are aiming at the format:
         // [{text: 'optgroup text', children: [{id: '<sha>', text: '<inner text>'}]}]
         $redeploy = array();
-        foreach ($project->DNEnvironmentList() as $dnEnvironment) {
+        foreach($project->DNEnvironmentList() as $dnEnvironment) {
             $envName = $dnEnvironment->Name;
             $perEnvDeploys = array();
 
-            foreach ($dnEnvironment->DeployHistory() as $deploy) {
+            foreach($dnEnvironment->DeployHistory() as $deploy) {
                 $sha = $deploy->SHA;
 
                 // Check if exists to make sure the newest deployment date is used.
-                if (!isset($perEnvDeploys[$sha])) {
+                if(!isset($perEnvDeploys[$sha])) {
                     $pastValue = sprintf("%s (deployed %s)",
                         substr($sha, 0, 8),
                         $deploy->obj('LastEdited')->Ago()
@@ -1325,12 +1325,12 @@ 
                 }
             }
 
-            if (!empty($perEnvDeploys)) {
+            if(!empty($perEnvDeploys)) {
                 $redeploy[$envName] = array_values($perEnvDeploys);
             }
         }
         // Convert the array to the frontend format (i.e. keyed to regular array)
-        foreach ($redeploy as $env => $descr) {
+        foreach($redeploy as $env => $descr) {
             $data['field_data'][] = array('text'=>$env, 'children'=>$descr);
         }
         $tabs[] = $data;
@@ -1352,7 +1352,7 @@ 
             ->filter('ProjectID', $project->ID)
             ->sort('LastEdited', 'DESC')
             ->first();
-        if ($fetch) {
+        if($fetch) {
             $lastFetched = $fetch->dbObject('LastEdited')->Ago();
         }
 
@@ -1378,7 +1378,7 @@ 
 
         // Ensure the submitted token has a value
         $submittedToken = $request->postVar('SecurityID');
-        if (!$submittedToken) {
+        if(!$submittedToken) {
             return false;
         }
 
@@ -1386,7 +1386,7 @@ 
         $check = $token->check($submittedToken);
 
         // Reset the token after we've checked the existing token
-        if ($resetToken) {
+        if($resetToken) {
             $token->reset();
         }
 
@@ -1404,13 +1404,13 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         // Performs canView permission check by limiting visible projects
         $environment = $this->getCurrentEnvironment($project);
-        if (!$environment) {
+        if(!$environment) {
             return $this->environment404Response();
         }
 
@@ -1424,7 +1424,7 @@ 
         // Add in a URL for comparing from->to code changes. Ensure that we have
         // two proper 40 character SHAs, otherwise we can't show the compare link.
         $interface = $project->getRepositoryInterface();
-        if (
+        if(
             !empty($interface) && !empty($interface->URL)
             && !empty($data['changes']['Code version']['from'])
             && strlen($data['changes']['Code version']['from']) == '40'
@@ -1462,20 +1462,20 @@ 
     {
 
         // Ensure the CSRF Token is correct
-        if (!$this->checkCsrfToken($request)) {
+        if(!$this->checkCsrfToken($request)) {
             // CSRF token didn't match
             return $this->httpError(400, 'Bad Request');
         }
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         // Performs canView permission check by limiting visible projects
         $environment = $this->getCurrentEnvironment($project);
-        if (!$environment) {
+        if(!$environment) {
             return $this->environment404Response();
         }
 
@@ -1507,20 +1507,20 @@ 
         $params = $request->params();
         $deployment = DNDeployment::get()->byId($params['Identifier']);
 
-        if (!$deployment || !$deployment->ID) {
+        if(!$deployment || !$deployment->ID) {
             throw new SS_HTTPResponse_Exception('Deployment not found', 404);
         }
-        if (!$deployment->canView()) {
+        if(!$deployment->canView()) {
             return Security::permissionFailure();
         }
 
         $environment = $deployment->Environment();
         $project = $environment->Project();
 
-        if ($environment->Name != $params['Environment']) {
+        if($environment->Name != $params['Environment']) {
             throw new LogicException("Environment in URL doesn't match this deploy");
         }
-        if ($project->Name != $params['Project']) {
+        if($project->Name != $params['Project']) {
             throw new LogicException("Project in URL doesn't match this deploy");
         }
 
@@ -1543,25 +1543,25 @@ 
         $params = $request->params();
         $deployment = DNDeployment::get()->byId($params['Identifier']);
 
-        if (!$deployment || !$deployment->ID) {
+        if(!$deployment || !$deployment->ID) {
             throw new SS_HTTPResponse_Exception('Deployment not found', 404);
         }
-        if (!$deployment->canView()) {
+        if(!$deployment->canView()) {
             return Security::permissionFailure();
         }
 
         $environment = $deployment->Environment();
         $project = $environment->Project();
 
-        if ($environment->Name != $params['Environment']) {
+        if($environment->Name != $params['Environment']) {
             throw new LogicException("Environment in URL doesn't match this deploy");
         }
-        if ($project->Name != $params['Project']) {
+        if($project->Name != $params['Project']) {
             throw new LogicException("Project in URL doesn't match this deploy");
         }
 
         $log = $deployment->log();
-        if ($log->exists()) {
+        if($log->exists()) {
             $content = $log->content();
         } else {
             $content = 'Waiting for action to start';
@@ -1578,11 +1578,11 @@ 
     public function getDataTransferForm(SS_HTTPRequest $request = null)
     {
         // Performs canView permission check by limiting visible projects
-        $envs = $this->getCurrentProject()->DNEnvironmentList()->filterByCallback(function ($item) {
+        $envs = $this->getCurrentProject()->DNEnvironmentList()->filterByCallback(function($item) {
             return $item->canBackup();
         });
 
-        if (!$envs) {
+        if(!$envs) {
             return $this->environment404Response();
         }
 
@@ -1618,21 +1618,21 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         $dataArchive = null;
 
         // Validate direction.
-        if ($data['Direction'] == 'get') {
+        if($data['Direction'] == 'get') {
             $validEnvs = $this->getCurrentProject()->DNEnvironmentList()
-                ->filterByCallback(function ($item) {
+                ->filterByCallback(function($item) {
                     return $item->canBackup();
                 });
-        } elseif ($data['Direction'] == 'push') {
+        } elseif($data['Direction'] == 'push') {
             $validEnvs = $this->getCurrentProject()->DNEnvironmentList()
-                ->filterByCallback(function ($item) {
+                ->filterByCallback(function($item) {
                     return $item->canRestore();
                 });
         } else {
@@ -1641,7 +1641,7 @@ 
 
         // Validate $data['EnvironmentID'] by checking against $validEnvs.
         $environment = $validEnvs->find('ID', $data['EnvironmentID']);
-        if (!$environment) {
+        if(!$environment) {
             throw new LogicException('Invalid environment');
         }
 
@@ -1649,17 +1649,17 @@ 
 
 
         // Only 'push' direction is allowed an association with an existing archive.
-        if (
+        if(
             $data['Direction'] == 'push'
             && isset($data['DataArchiveID'])
             && is_numeric($data['DataArchiveID'])
         ) {
             $dataArchive = DNDataArchive::get()->byId($data['DataArchiveID']);
-            if (!$dataArchive) {
+            if(!$dataArchive) {
                 throw new LogicException('Invalid data archive');
             }
 
-            if (!$dataArchive->canDownload()) {
+            if(!$dataArchive->canDownload()) {
                 throw new SS_HTTPResponse_Exception('Not allowed to access archive', 403);
             }
         }
@@ -1669,7 +1669,7 @@ 
         $transfer->Direction = $data['Direction'];
         $transfer->Mode = $data['Mode'];
         $transfer->DataArchiveID = $dataArchive ? $dataArchive->ID : null;
-        if ($data['Direction'] == 'push') {
+        if($data['Direction'] == 'push') {
             $transfer->setBackupBeforePush(!empty($data['BackupBeforePush']));
         }
         $transfer->write();
@@ -1693,17 +1693,17 @@ 
         $params = $request->params();
         $transfer = DNDataTransfer::get()->byId($params['Identifier']);
 
-        if (!$transfer || !$transfer->ID) {
+        if(!$transfer || !$transfer->ID) {
             throw new SS_HTTPResponse_Exception('Transfer not found', 404);
         }
-        if (!$transfer->canView()) {
+        if(!$transfer->canView()) {
             return Security::permissionFailure();
         }
 
         $environment = $transfer->Environment();
         $project = $environment->Project();
 
-        if ($project->Name != $params['Project']) {
+        if($project->Name != $params['Project']) {
             throw new LogicException("Project in URL doesn't match this deploy");
         }
 
@@ -1728,22 +1728,22 @@ 
         $params = $request->params();
         $transfer = DNDataTransfer::get()->byId($params['Identifier']);
 
-        if (!$transfer || !$transfer->ID) {
+        if(!$transfer || !$transfer->ID) {
             throw new SS_HTTPResponse_Exception('Transfer not found', 404);
         }
-        if (!$transfer->canView()) {
+        if(!$transfer->canView()) {
             return Security::permissionFailure();
         }
 
         $environment = $transfer->Environment();
         $project = $environment->Project();
 
-        if ($project->Name != $params['Project']) {
+        if($project->Name != $params['Project']) {
             throw new LogicException("Project in URL doesn't match this deploy");
         }
 
         $log = $transfer->log();
-        if ($log->exists()) {
+        if($log->exists()) {
             $content = $log->content();
         } else {
             $content = 'Waiting for action to start';
@@ -1767,22 +1767,22 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        $envs = $project->DNEnvironmentList()->filterByCallback(function ($item) {
+        $envs = $project->DNEnvironmentList()->filterByCallback(function($item) {
             return $item->canRestore();
         });
 
-        if (!$envs) {
+        if(!$envs) {
             return $this->environment404Response();
         }
 
         $modesMap = array();
-        if (in_array($dataArchive->Mode, array('all'))) {
+        if(in_array($dataArchive->Mode, array('all'))) {
             $modesMap['all'] = 'Database and Assets';
         };
-        if (in_array($dataArchive->Mode, array('all', 'db'))) {
+        if(in_array($dataArchive->Mode, array('all', 'db'))) {
             $modesMap['db'] = 'Database only';
         };
-        if (in_array($dataArchive->Mode, array('all', 'assets'))) {
+        if(in_array($dataArchive->Mode, array('all', 'assets'))) {
             $modesMap['assets'] = 'Assets only';
         };
 
@@ -1828,13 +1828,13 @@ 
         /** @var DNDataArchive $dataArchive */
         $dataArchive = DNDataArchive::get()->byId($request->param('DataArchiveID'));
 
-        if (!$dataArchive) {
+        if(!$dataArchive) {
             throw new SS_HTTPResponse_Exception('Archive not found', 404);
         }
 
         // We check for canDownload because that implies access to the data.
         // canRestore is later checked on the actual restore action per environment.
-        if (!$dataArchive->canDownload()) {
+        if(!$dataArchive->canDownload()) {
             throw new SS_HTTPResponse_Exception('Not allowed to access archive', 403);
         }
 
@@ -1861,11 +1861,11 @@ 
         /** @var DNDataArchive $dataArchive */
         $dataArchive = DNDataArchive::get()->byId($request->param('DataArchiveID'));
 
-        if (!$dataArchive) {
+        if(!$dataArchive) {
             throw new SS_HTTPResponse_Exception('Archive not found', 404);
         }
 
-        if (!$dataArchive->canDelete()) {
+        if(!$dataArchive->canDelete()) {
             throw new SS_HTTPResponse_Exception('Not allowed to delete archive', 403);
         }
 
@@ -1887,7 +1887,7 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
@@ -1925,24 +1925,24 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         $dataArchive = null;
 
-        if (
+        if(
             isset($data['DataArchiveID'])
             && is_numeric($data['DataArchiveID'])
         ) {
             $dataArchive = DNDataArchive::get()->byId($data['DataArchiveID']);
         }
 
-        if (!$dataArchive) {
+        if(!$dataArchive) {
             throw new LogicException('Invalid data archive');
         }
 
-        if (!$dataArchive->canDelete()) {
+        if(!$dataArchive->canDelete()) {
             throw new SS_HTTPResponse_Exception('Not allowed to delete archive', 403);
         }
 
@@ -1966,12 +1966,12 @@ 
         /** @var DNDataArchive $dataArchive */
         $dataArchive = DNDataArchive::get()->byId($request->param('DataArchiveID'));
 
-        if (!$dataArchive) {
+        if(!$dataArchive) {
             throw new SS_HTTPResponse_Exception('Archive not found', 404);
         }
 
         // We check for canDownload because that implies access to the data.
-        if (!$dataArchive->canDownload()) {
+        if(!$dataArchive->canDownload()) {
             throw new SS_HTTPResponse_Exception('Not allowed to access archive', 403);
         }
 
@@ -1994,7 +1994,7 @@ 
         $dataArchive = $dataArchive ? $dataArchive : DNDataArchive::get()->byId($request->requestVar('DataArchiveID'));
 
         $envs = $dataArchive->validTargetEnvironments();
-        if (!$envs) {
+        if(!$envs) {
             return $this->environment404Response();
         }
 
@@ -2036,25 +2036,25 @@ 
 
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
 
         /** @var DNDataArchive $dataArchive */
         $dataArchive = DNDataArchive::get()->byId($data['DataArchiveID']);
-        if (!$dataArchive) {
+        if(!$dataArchive) {
             throw new LogicException('Invalid data archive');
         }
 
         // We check for canDownload because that implies access to the data.
-        if (!$dataArchive->canDownload()) {
+        if(!$dataArchive->canDownload()) {
             throw new SS_HTTPResponse_Exception('Not allowed to access archive', 403);
         }
 
         // Validate $data['EnvironmentID'] by checking against $validEnvs.
         $validEnvs = $dataArchive->validTargetEnvironments();
         $environment = $validEnvs->find('ID', $data['EnvironmentID']);
-        if (!$environment) {
+        if(!$environment) {
             throw new LogicException('Invalid environment');
         }
 
@@ -2073,7 +2073,7 @@ 
     {
         try {
             Resque::queues();
-        } catch (Exception $e) {
+        } catch(Exception $e) {
             return $e->getMessage();
         }
         return '';
@@ -2140,10 +2140,10 @@ 
     public function getCurrentProject()
     {
         $projectName = trim($this->getRequest()->param('Project'));
-        if (!$projectName) {
+        if(!$projectName) {
             return null;
         }
-        if (empty(self::$_project_cache[$projectName])) {
+        if(empty(self::$_project_cache[$projectName])) {
             self::$_project_cache[$projectName] = $this->DNProjectList()->filter('Name', $projectName)->First();
         }
         return self::$_project_cache[$projectName];
@@ -2155,14 +2155,14 @@ 
      */
     public function getCurrentEnvironment(DNProject $project = null)
     {
-        if ($this->getRequest()->param('Environment') === null) {
+        if($this->getRequest()->param('Environment') === null) {
             return null;
         }
-        if ($project === null) {
+        if($project === null) {
             $project = $this->getCurrentProject();
         }
         // project can still be null
-        if ($project === null) {
+        if($project === null) {
             return null;
         }
         return $project->DNEnvironmentList()->filter('Name', $this->getRequest()->param('Environment'))->First();
@@ -2204,23 +2204,23 @@ 
      */
     public function CanViewArchives(Member $member = null)
     {
-        if ($member === null) {
+        if($member === null) {
             $member = Member::currentUser();
         }
 
-        if (Permission::checkMember($member, 'ADMIN')) {
+        if(Permission::checkMember($member, 'ADMIN')) {
             return true;
         }
 
         $allProjects = $this->DNProjectList();
-        if (!$allProjects) {
+        if(!$allProjects) {
             return false;
         }
 
-        foreach ($allProjects as $project) {
-            if ($project->Environments()) {
-                foreach ($project->Environments() as $environment) {
-                    if (
+        foreach($allProjects as $project) {
+            if($project->Environments()) {
+                foreach($project->Environments() as $environment) {
+                    if(
                         $environment->canRestore($member) ||
                         $environment->canBackup($member) ||
                         $environment->canUploadArchive($member) ||
@@ -2242,7 +2242,7 @@ 
     public function CreateEnvironmentList()
     {
         $project = $this->getCurrentProject();
-        if ($project) {
+        if($project) {
             return new PaginatedList($project->CreateEnvironments()->sort("Created DESC"), $this->request);
         }
         return new PaginatedList(new ArrayList(), $this->request);
@@ -2259,9 +2259,9 @@ 
         $archives = new ArrayList();
 
         $archiveList = $project->Environments()->relation("DataArchives");
-        if ($archiveList->count() > 0) {
-            foreach ($archiveList as $archive) {
-                if ($archive->canView() && !$archive->isPending()) {
+        if($archiveList->count() > 0) {
+            foreach($archiveList as $archive) {
+                if($archive->canView() && !$archive->isPending()) {
                     $archives->push($archive);
                 }
             }
@@ -2277,9 +2277,9 @@ 
     {
         $project = $this->getCurrentProject();
         $archives = new ArrayList();
-        foreach ($project->DNEnvironmentList() as $env) {
-            foreach ($env->DataArchives() as $archive) {
-                if ($archive->canView() && $archive->isPending()) {
+        foreach($project->DNEnvironmentList() as $env) {
+            foreach($env->DataArchives() as $archive) {
+                if($archive->canView() && $archive->isPending()) {
                     $archives->push($archive);
                 }
             }
@@ -2294,7 +2294,7 @@ 
     {
         $project = $this->getCurrentProject();
 
-        $transfers = DNDataTransfer::get()->filterByCallback(function ($record) use ($project) {
+        $transfers = DNDataTransfer::get()->filterByCallback(function($record) use ($project) {
             return
                 $record->Environment()->Project()->ID == $project->ID && // Ensure only the current Project is shown
                 (
@@ -2313,9 +2313,9 @@ 
      */
     public function DeployHistory()
     {
-        if ($env = $this->getCurrentEnvironment()) {
+        if($env = $this->getCurrentEnvironment()) {
             $history = $env->DeployHistory();
-            if ($history->count() > 0) {
+            if($history->count() > 0) {
                 $pagination = new PaginatedList($history, $this->getRequest());
                 $pagination->setPageLength(8);
                 return $pagination;
@@ -2358,7 +2358,7 @@ 
         $sendJSON = (strpos($this->getRequest()->getHeader('Accept'), 'application/json') !== false)
             || $this->getRequest()->getExtension() == 'json';
 
-        if (!$sendJSON) {
+        if(!$sendJSON) {
             $this->response->addHeader("Content-type", "text/plain");
             return $content;
         }
@@ -2376,7 +2376,7 @@ 
      */
     protected function validateSnapshotMode($mode)
     {
-        if (!in_array($mode, array('all', 'assets', 'db'))) {
+        if(!in_array($mode, array('all', 'assets', 'db'))) {
             throw new LogicException('Invalid mode');
         }
     }
@@ -2391,12 +2391,12 @@ 
     {
         // Performs canView permission check by limiting visible projects
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->project404Response();
         }
         $data[$sectionName] = 1;
 
-        if ($this !== '') {
+        if($this !== '') {
             $data['Title'] = $title;
         }
 
@@ -2412,7 +2412,7 @@ 
     {
         $list = new ArrayList();
 
-        if (Member::currentUserID()) {
+        if(Member::currentUserID()) {
             $list->push(new ArrayData(array(
                 'Classes' => 'logout',
                 'FaIcon' => 'sign-out',
@@ -2434,7 +2434,7 @@ 
      */
     public function createproject(SS_HTTPRequest $request)
     {
-        if ($this->canCreateProjects()) {
+        if($this->canCreateProjects()) {
             return $this->render(['CurrentTitle' => 'Create Stack']);
         }
         return $this->httpError(403);
@@ -2447,10 +2447,10 @@ 
      */
     public function canCreateProjects($member = null)
     {
-        if (!$member) {
+        if(!$member) {
             $member = Member::currentUser();
         }
-        if (!$member) {
+        if(!$member) {
             return false;
         }
 
@@ -2515,11 +2515,11 @@ 
         $form->saveInto($project);
         $this->extend('onBeforeCreateProject', $project, $data, $form);
         try {
-            if ($project->write() > 0) {
+            if($project->write() > 0) {
                 $this->extend('onAfterCreateProject', $project, $data, $form);
 
                 // If an extension hasn't redirected us, we'll redirect to the project.
-                if (!$this->redirectedTo()) {
+                if(!$this->redirectedTo()) {
                     return $this->redirect($project->Link());
                 } else {
                     return $this->response;
@@ -2527,7 +2527,7 @@ 
             } else {
                 $form->sessionMessage('Unable to write the stack to the database.', 'bad');
             }
-        } catch (ValidationException $e) {
+        } catch(ValidationException $e) {
             $form->sessionMessage($e->getMessage(), 'bad');
         }
         return $this->redirectBack();
@@ -2543,7 +2543,7 @@ 
     public function createprojectprogress(SS_HTTPRequest $request)
     {
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->httpError(404);
         }
 
@@ -2551,13 +2551,13 @@ 
         $complete = array();
         $inProgress = array();
         $failed = array();
-        if ($envCreations->count() > 0) {
-            foreach ($envCreations as $env) {
+        if($envCreations->count() > 0) {
+            foreach($envCreations as $env) {
                 $data = unserialize($env->Data);
-                if (!isset($data['Name'])) {
+                if(!isset($data['Name'])) {
                     $data['Name'] = 'Unknown';
                 }
-                switch ($env->ResqueStatus()) {
+                switch($env->ResqueStatus()) {
                     case "Queued":
                     case "Running":
                         $inProgress[$env->ID] = Convert::raw2xml($env->ResqueStatus());
@@ -2594,17 +2594,17 @@ 
     public function checkrepoaccess(SS_HTTPRequest $request)
     {
         $project = $this->getCurrentProject();
-        if (!$project) {
+        if(!$project) {
             return $this->httpError(404);
         }
 
-        if ($project->CVSPath) {
+        if($project->CVSPath) {
             $fetch = new FetchJob();
             $fetch->args = array('projectID' => $project->ID);
             try {
                 $fetch->perform();
                 $canAccessRepo = true;
-            } catch (RuntimeException $e) {
+            } catch(RuntimeException $e) {
                 $canAccessRepo = false;
             }
             $data = ['canAccessRepo' => $canAccessRepo];

code/control/DeployForm.php

Spacing +22 added lines, -22 removed lines

@@ -31,7 +31,7 @@ 
     protected function validateCommit($sha, $field)
     {
         // Check selected commit
-        if (empty($sha)) {
+        if(empty($sha)) {
             $this->validationError(
                 $field,
                 "No valid release selected",
@@ -41,7 +41,7 @@ 
         }
 
         // Check validity of commit
-        if (!preg_match('/^[a-f0-9]{40}$/', $sha)) {
+        if(!preg_match('/^[a-f0-9]{40}$/', $sha)) {
             $this->validationError(
                 $field,
                 "Invalid release SHA: " . Convert::raw2xml($sha),
@@ -66,7 +66,7 @@ 
     public function php($data)
     {
         // Check release method
-        if (empty($data['SelectRelease'])
+        if(empty($data['SelectRelease'])
             || !in_array($data['SelectRelease'], array('Tag', 'Branch', 'Redeploy', 'SHA', 'FilteredCommits'))
         ) {
             $method = empty($data['SelectRelease']) ? '(blank)' : $data['SelectRelease'];
@@ -121,7 +121,7 @@ 
      */
     public function __construct($controller, $name, DNEnvironment $environment, DNProject $project)
     {
-        if ($environment->HasPipelineSupport()) {
+        if($environment->HasPipelineSupport()) {
             list($field, $validator, $actions) = $this->setupPipeline($environment, $project);
         } else {
             list($field, $validator, $actions) = $this->setupSimpleDeploy($project);
@@ -159,11 +159,11 @@ 
         $canBypass = Permission::check(DNRoot::DEPLOYNAUT_BYPASS_PIPELINE);
         $canDryrun = $environment->DryRunEnabled && Permission::check(DNRoot::DEPLOYNAUT_DRYRUN_PIPELINE);
         $commits = $environment->getDependentFilteredCommits();
-        if (empty($commits)) {
+        if(empty($commits)) {
             // There are no filtered commits, so show all commits
             $field = $this->buildCommitSelector($project);
             $validator = new DeployForm_CommitValidator();
-        } elseif ($canBypass) {
+        } elseif($canBypass) {
             // Build hybrid selector that allows users to follow pipeline or use any commit
             $field = $this->buildCommitSelector($project, $commits);
             $validator = new DeployForm_CommitValidator();
@@ -179,7 +179,7 @@ 
                 ->addExtraClass('btn btn-primary')
                 ->setAttribute('onclick', "return confirm('This will begin a release pipeline. Continue?');")
         );
-        if ($canDryrun) {
+        if($canDryrun) {
             $actions->push(
                 FormAction::create('doDryRun', "Dry-run release process")
                     ->addExtraClass('btn btn-info')
@@ -192,7 +192,7 @@ 
                     )
             );
         }
-        if ($canBypass) {
+        if($canBypass) {
             $actions->push(
                 FormAction::create('showDeploySummary', "Direct deployment (bypass pipeline)")
                     ->addExtraClass('btn btn-warning')
@@ -218,7 +218,7 @@ 
     {
         // Branches
         $branches = array();
-        foreach ($project->DNBranchList() as $branch) {
+        foreach($project->DNBranchList() as $branch) {
             $sha = $branch->SHA();
             $name = $branch->Name();
             $branchValue = sprintf("%s (%s, %s old)",
@@ -231,7 +231,7 @@ 
 
         // Tags
         $tags = array();
-        foreach ($project->DNTagList()->setLimit(null) as $tag) {
+        foreach($project->DNTagList()->setLimit(null) as $tag) {
             $sha = $tag->SHA();
             $name = $tag->Name();
             $tagValue = sprintf("%s (%s, %s old)",
@@ -245,14 +245,14 @@ 
 
         // Past deployments
         $redeploy = array();
-        foreach ($project->DNEnvironmentList() as $dnEnvironment) {
+        foreach($project->DNEnvironmentList() as $dnEnvironment) {
             $envName = $dnEnvironment->Name;
-            foreach ($dnEnvironment->DeployHistory() as $deploy) {
+            foreach($dnEnvironment->DeployHistory() as $deploy) {
                 $sha = $deploy->SHA;
-                if (!isset($redeploy[$envName])) {
+                if(!isset($redeploy[$envName])) {
                     $redeploy[$envName] = array();
                 }
-                if (!isset($redeploy[$envName][$sha])) {
+                if(!isset($redeploy[$envName][$sha])) {
                     $pastValue = sprintf("%s (deployed %s)",
                         substr($sha, 0, 8),
                         $deploy->obj('LastEdited')->Ago()
@@ -264,28 +264,28 @@ 
 
         // Merge fields
         $releaseMethods = array();
-        if ($pipelineCommits) {
+        if($pipelineCommits) {
             $releaseMethods[] = new SelectionGroup_Item(
                 'FilteredCommits',
                 $this->buildPipelineField($pipelineCommits),
                 'Deploy a commit prepared for this pipeline'
             );
         }
-        if (!empty($branches)) {
+        if(!empty($branches)) {
             $releaseMethods[] = new SelectionGroup_Item(
                 'Branch',
                 new DropdownField('Branch', 'Select a branch', $branches),
                 'Deploy the latest version of a branch'
             );
         }
-        if ($tags) {
+        if($tags) {
             $releaseMethods[] = new SelectionGroup_Item(
                 'Tag',
                 new DropdownField('Tag', 'Select a tag', $tags),
                 'Deploy a tagged release'
             );
         }
-        if ($redeploy) {
+        if($redeploy) {
             $releaseMethods[] = new SelectionGroup_Item(
                 'Redeploy',
                 new GroupedDropdownField('Redeploy', 'Redeploy', $redeploy),
@@ -314,7 +314,7 @@ 
     {
         // Get filtered commits
         $filteredCommits = array();
-        foreach ($commits as $commit) {
+        foreach($commits as $commit) {
             $title = sprintf(
                 "%s (%s, %s old)",
                 $commit->Message,
@@ -323,7 +323,7 @@ 
             );
             $filteredCommits[$commit->SHA] = $title;
         }
-        if ($filteredCommits) {
+        if($filteredCommits) {
             return new DropdownField('FilteredCommits', '', $filteredCommits);
         } else {
             return DropdownField::create('FilteredCommits)', '')
@@ -340,12 +340,12 @@ 
      */
     public function getSelectedBuild($data)
     {
-        if (isset($data['SelectRelease']) && !empty($data[$data['SelectRelease']])) {
+        if(isset($data['SelectRelease']) && !empty($data[$data['SelectRelease']])) {
             // Filter out the tag/branch name if required
             $array = explode('-', $data[$data['SelectRelease']]);
             return reset($array);
         }
-        if (isset($data['FilteredCommits']) && !empty($data['FilteredCommits'])) {
+        if(isset($data['FilteredCommits']) && !empty($data['FilteredCommits'])) {
             return $data['FilteredCommits'];
         }
     }

code/control/DeploynautLogFile.php

Spacing +3 added lines, -3 removed lines

@@ -65,10 +65,10 @@ 
         $path = $this->getSanitisedLogFilePath();
 
         // for backwards compatibility on old logs
-        if (!file_exists($path)) {
+        if(!file_exists($path)) {
             $path = $this->getRawFilePath();
 
-            if (!file_exists($path)) {
+            if(!file_exists($path)) {
                 return null;
             }
         }
@@ -85,7 +85,7 @@ 
         // Make sure we write into the old path for existing logs. New logs use the sanitised file path instead.
         $path = file_exists($this->getRawFilePath()) ? $this->getRawFilePath() : $this->getSanitisedLogFilePath();
 
-        error_log('['.date('Y-m-d H:i:s').'] ' . $message .PHP_EOL, 3, $path);
+        error_log('[' . date('Y-m-d H:i:s') . '] ' . $message . PHP_EOL, 3, $path);
         @chmod($path, 0666);
     }
 

code/control/Dispatcher.php

Spacing +9 added lines, -9 removed lines

@@ -39,7 +39,7 @@ 
 
     protected function getSecurityToken($name = null)
     {
-        if (is_null($name)) {
+        if(is_null($name)) {
             $name = sprintf('%sSecurityID', get_class($this));
         }
         return new \SecurityToken($name);
@@ -48,7 +48,7 @@ 
     protected function checkSecurityToken($name = null)
     {
         $postVar = is_null($name) ? 'SecurityID' : $name;
-        if (is_null($name)) {
+        if(is_null($name)) {
             $name = sprintf('%sSecurityID', get_class($this));
         }
         $securityToken = $this->getSecurityToken($name);
@@ -56,7 +56,7 @@ 
         // By default the security token is always represented by a "SecurityID" post var,
         // even if the backend uses different names for the token. This too means only one security token
         // can be managed by one dispatcher if the default is used.
-        if (!$securityToken->check($this->request->postVar($postVar))) {
+        if(!$securityToken->check($this->request->postVar($postVar))) {
             $this->httpError(400, 'Invalid security token, try reloading the page.');
         }
     }
@@ -72,7 +72,7 @@ 
     public function asJSONValidatorErrors($code, $validatorErrors)
     {
         $fieldErrors = [];
-        foreach ($validatorErrors as $error) {
+        foreach($validatorErrors as $error) {
             $fieldErrors[$error['fieldName']] = $error['message'];
         }
         return $this->asJSONFormFieldErrors($code, $fieldErrors);
@@ -116,7 +116,7 @@ 
         // To get around that, upon spotting an active redirect, we change the response code to 200,
         // and move the redirect into the "RedirectTo" field in the JSON response. Frontend can
         // then interpret this and trigger a redirect.
-        if ($this->redirectedTo()) {
+        if($this->redirectedTo()) {
             $data['RedirectTo'] = $this->response->getHeader('Location');
             // Pop off the header - we are no longer redirecting via the usual mechanism.
             $this->response->removeHeader('Location');
@@ -144,8 +144,8 @@ 
      */
     protected function trimWhitespace($val)
     {
-        if (is_array($val)) {
-            foreach ($val as $k => $v) {
+        if(is_array($val)) {
+            foreach($val as $k => $v) {
                 $val[$k] = $this->trimWhitespace($v);
             }
             return $val;
@@ -162,8 +162,8 @@ 
      */
     protected function stripNonPrintables($val)
     {
-        if (is_array($val)) {
-            foreach ($val as $k => $v) {
+        if(is_array($val)) {
+            foreach($val as $k => $v) {
                 $val[$k] = $this->stripNonPrintables($v);
             }
             return $val;

code/control/EmailMessagingService.php

Spacing +6 added lines, -6 removed lines

@@ -45,20 +45,20 @@ 
     protected function sendIndividualMessages($source, $message, $recipients, $from, $subject)
     {
         // Split recipients that are comma separated
-        if (is_string($recipients) && stripos($recipients, ',')) {
+        if(is_string($recipients) && stripos($recipients, ',')) {
             $recipients = explode(',', $recipients);
             return $this->sendIndividualMessages($source, $message, $recipients, $from, $subject);
         }
 
         // Iterate through arrays
-        if (is_array($recipients) || $recipients instanceof SS_List) {
-            foreach ($recipients as $recipient) {
+        if(is_array($recipients) || $recipients instanceof SS_List) {
+            foreach($recipients as $recipient) {
                 $this->sendIndividualMessages($source, $message, $recipient, $from, $subject);
             }
             return true;
         }
 
-        if ($recipients) {
+        if($recipients) {
             $this->sendMessageTo($source, $from, $recipients, $subject, $message);
             return true;
         }
@@ -79,7 +79,7 @@ 
      */
     protected function sendMessageTo($source, $from, $to, $subject, $body)
     {
-        if ($to instanceof Member) {
+        if($to instanceof Member) {
             $to = $to->Email;
         }
         $this->sendViaEmail($source, $from, $to, $subject, $body);
@@ -97,7 +97,7 @@ 
     protected function sendViaEmail($source, $from, $to, $subject, $body)
     {
         $email = new Email($from, $to, $subject, $body);
-        if ($source->getDryRun()) {
+        if($source->getDryRun()) {
             $source->log("[Skipped] Sent message to $to (subject: $subject)");
         } else {
             $email->sendPlain();

code/control/PipelineController.php

Spacing +4 added lines, -4 removed lines

@@ -36,7 +36,7 @@ 
     public function log()
     {
         $log = $this->pipeline->getLogger();
-        if ($log->exists()) {
+        if($log->exists()) {
             $content = $log->content();
         } else {
             $content = 'Waiting for action to start';
@@ -46,7 +46,7 @@ 
             || $this->request->getExtension() == 'json';
 
         $content = preg_replace('/(?:(?:\r\n|\r|\n)\s*){2}/s', "\n", $content);
-        if ($sendJSON) {
+        if($sendJSON) {
             $this->response->addHeader("Content-type", "application/json");
             return json_encode(array(
                 'status' => $this->pipeline->Status,
@@ -63,7 +63,7 @@ 
      */
     public function abort()
     {
-        if ($this->pipeline->canAbort()) {
+        if($this->pipeline->canAbort()) {
             $this->pipeline->markAborted();
         }
         return $this->redirect($this->pipeline->Environment()->Link());
@@ -78,7 +78,7 @@ 
         $step = $this->pipeline->CurrentStep();
 
         // Check if the action is available on this step
-        if ($step && ($actions = $step->allowedActions()) && isset($actions[$action])) {
+        if($step && ($actions = $step->allowedActions()) && isset($actions[$action])) {
             // Execute this action, allowing it to override the httpresponse given
             $step->$action();
         }

code/events/GenericEvent.php

Spacing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
      */
     public function get($keyname)
     {
-        if (array_key_exists($keyname, $this->data)) {
+        if(array_key_exists($keyname, $this->data)) {
             return $this->data[$keyname];
         }
         return '';

code/extensions/DeploynautFileExtension.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
         $file = $this->owner;
         $archive = DNDataArchive::get()->filter('ArchiveFileID', $file->ID)->First();
 
-        if ($archive) {
+        if($archive) {
             return $archive->canDownload($member);
         }