Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
2 | View Code Duplication | class NoRollbackDeployOption implements DeployOption { |
|
3 | |||
4 | protected $name = 'no_rollback'; |
||
5 | |||
6 | protected $title = 'No rollback on deploy failure'; |
||
7 | |||
8 | protected $defaultValue; |
||
9 | |||
10 | public function __construct($defaultValue = false) { |
||
13 | |||
14 | public function __get($name) { |
||
20 | |||
21 | public function getName() { |
||
24 | |||
25 | public function getTitle() { |
||
28 | |||
29 | public function getDefaultValue() { |
||
32 | |||
33 | } |
||
34 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.