EnvironmentOverview - Code Metrics - Inspection of "split the DeployPlan dispatcher into smaller dispa..." - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( beafec...bac082 )

by Sean

created 2016-09-06 00:05 UTC

EnvironmentOverview A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	70
Duplicated Lines	12.86 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	6
c	1
b	0
f	0
lcom	2
cbo	4
dl	9
loc	70
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	9	9	2
A	index()	0	11	2
A	Link()	0	3	1
A	getModel()	0	14	1

How to fix Duplicated Code

<?php

/**
 * This aims to be a simple controller that only kicks off the rendering on the react
 * components. It passes a model to the frontend with URLS to dispatchers that takes
 * care of various actions, like git fetching, planning, approvals and so on.
 */
class EnvironmentOverview extends Dispatcher {

	const ACTION_OVERVIEW = 'overview';

	/**
	 * @var array
	 */
	private static $action_types = [
		self::ACTION_OVERVIEW
	];

	public function init() {

		parent::init();
		$this->project = $this->getCurrentProject();

		if(!$this->project) {

			return $this->project404Response();
		}
		// Performs canView permission check by limiting visible projects
		$this->environment = $this->getCurrentEnvironment($this->project);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
	}

	/**
	 *
	 * @param \SS_HTTPRequest $request
	 *
	 * @return \HTMLText|\SS_HTTPResponse
	 */
	public function index(\SS_HTTPRequest $request) {
		if(!$this->environment) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			return $this->environment404Response();
		}

		$this->setCurrentActionType(self::ACTION_OVERVIEW);

		return $this->customise([
			'Environment' => $this->environment
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		])->renderWith(['EnvironmentOverview', 'DNRoot']);
	}

	/**
	 * @return string
	 */
	public function Link() {
		return $this->environment->Link();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
	}

	/**
	 * The model includes the CSRF tokens and the various API
	 * endpoints that the front end might be interested in.
	 *
	 * @param string $name
	 *
	 * @return array
	 */
	public function getModel($name = '') {
		$base = Director::absoluteBaseURL();
		return [
			'dispatchers' => [
				'git' => $base.$this->getCurrentProject()->Link('git'),
				'plan' => $base.$this->getCurrentEnvironment()->Link('plan'),
				'deploys' => $base.$this->getCurrentEnvironment()->Link('deploys')
			],
			'api_auth' => [
				'name' => $this->getSecurityToken()->getName(),
				'value' => $this->getSecurityToken()->getValue()
			]
		];
	}

}


1		<?php
2
3		/**
4		* This aims to be a simple controller that only kicks off the rendering on the react
5		* components. It passes a model to the frontend with URLS to dispatchers that takes
6		* care of various actions, like git fetching, planning, approvals and so on.
7		*/
8		class EnvironmentOverview extends Dispatcher {
9
10		const ACTION_OVERVIEW = 'overview';
11
12		/**
13		* @var array
14		*/
15		private static $action_types = [
16		self::ACTION_OVERVIEW
17		];
18
19	View Code Duplication	public function init() {
		0 ignored issues – show Duplication introduced 2016-09-05 23:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20		parent::init();
21		$this->project = $this->getCurrentProject();
		0 ignored issues – show Bug introduced 2016-09-05 23:47 UTC by Report Bug Copy Issue Report The property `project` does not seem to exist. Did you mean `_project_cache`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
22		if(!$this->project) {
		0 ignored issues – show Bug introduced 2016-09-05 23:47 UTC by Report Bug Copy Issue Report The property `project` does not seem to exist. Did you mean `_project_cache`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
23		return $this->project404Response();
24		}
25		// Performs canView permission check by limiting visible projects
26		$this->environment = $this->getCurrentEnvironment($this->project);
		0 ignored issues – show Documentation introduced 2016-09-05 23:47 UTC by Report Bug Copy Issue Report The property `environment` does not exist on `object<EnvironmentOverview>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-09-05 23:47 UTC by Report Bug Copy Issue Report The property `project` does not seem to exist. Did you mean `_project_cache`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
27		}
28
29		/**
30		*
31		* @param \SS_HTTPRequest $request
32		*
33		* @return \HTMLText\|\SS_HTTPResponse
34		*/
35		public function index(\SS_HTTPRequest $request) {
36		if(!$this->environment) {
		0 ignored issues – show Documentation introduced 2016-09-05 23:47 UTC by Report Bug Copy Issue Report The property `environment` does not exist on `object<EnvironmentOverview>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
37		return $this->environment404Response();
38		}
39
40		$this->setCurrentActionType(self::ACTION_OVERVIEW);
41
42		return $this->customise([
43		'Environment' => $this->environment
		0 ignored issues – show Documentation introduced 2016-09-05 23:47 UTC by Report Bug Copy Issue Report The property `environment` does not exist on `object<EnvironmentOverview>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44		])->renderWith(['EnvironmentOverview', 'DNRoot']);
45		}
46
47		/**
48		* @return string
49		*/
50		public function Link() {
51		return $this->environment->Link();
		0 ignored issues – show Documentation introduced 2016-09-05 23:47 UTC by Report Bug Copy Issue Report The property `environment` does not exist on `object<EnvironmentOverview>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
52		}
53
54		/**
55		* The model includes the CSRF tokens and the various API
56		* endpoints that the front end might be interested in.
57		*
58		* @param string $name
59		*
60		* @return array
61		*/
62		public function getModel($name = '') {
63		$base = Director::absoluteBaseURL();
64		return [
65		'dispatchers' => [
66		'git' => $base.$this->getCurrentProject()->Link('git'),
67		'plan' => $base.$this->getCurrentEnvironment()->Link('plan'),
68		'deploys' => $base.$this->getCurrentEnvironment()->Link('deploys')
69		],
70		'api_auth' => [
71		'name' => $this->getSecurityToken()->getName(),
72		'value' => $this->getSecurityToken()->getValue()
73		]
74		];
75		}
76
77		}
78

silverstripe / deploynaut

Push — master ( beafec...bac082 )

EnvironmentOverview A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like